mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-11-17 09:31:45 +00:00
The review question sentence was written in four places and the URL safety rules in three. Collapse each to one definition. - Add `ReviewTarget::question_text_with_link` as the single definition of the question wording. `question_text()` and the Slack header both use it, so a wording change is now one edit. - Delete `ReviewTargetKind::noun()`. The enum already derives `strum::Display` with the same snake_case output. - Share one `review_target_line` helper between the console interviewer and the CLI attach client, which held a byte-identical copy. Print only the URL: `question.text` already carries the label and the noun. - Trim the web-side check to the URL scheme, host, and credentials, which are what a raw `href` can act on. Label length and control characters cannot affect the DOM and stay server-side. - Split validation from presentation in the web UI. `safeReviewTarget` returns the target or null, and each caller picks its own fallback, so an unsafe target now falls back to the same Markdown rendering as a question with no target. - Derive the resource noun from `kind` in the web UI instead of hardcoding "document". - Use `ReviewTargetKind.DOCUMENT` and the shared `isRecord` guard when parsing events, instead of a raw string and a hand-rolled object check that accepted arrays. - Drop `deny_unknown_fields` from the wire struct. The OpenAPI schema leaves `additionalProperties` permissive, so an added field would otherwise make persisted events unreadable. - Import `ReviewTarget` by name, and stop naming Slack in a fabro-types error message. - Document that `review_target=true` replaces the gate's `label`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
59 lines
1.9 KiB
TypeScript
59 lines
1.9 KiB
TypeScript
import { ArrowTopRightOnSquareIcon } from "@heroicons/react/20/solid";
|
|
import type { ReviewTarget } from "@qltysh/fabro-api-client";
|
|
|
|
/**
|
|
* Re-check the URL before putting it in an `href`. The server already rejects
|
|
* unsafe targets (see `ReviewTarget::new` in
|
|
* `lib/foundation/fabro-types/src/interview.rs`), but React does not sanitize
|
|
* `href`, so a `javascript:` URL reaching this component would execute. Length
|
|
* and control-character limits stay server-side; they cannot affect the DOM.
|
|
*/
|
|
export function safeReviewTarget(
|
|
target: ReviewTarget | null | undefined,
|
|
): ReviewTarget | null {
|
|
if (!target?.url || !target.label) return null;
|
|
try {
|
|
const parsed = new URL(target.url);
|
|
const safe =
|
|
(parsed.protocol === "http:" || parsed.protocol === "https:") &&
|
|
Boolean(parsed.host) &&
|
|
!parsed.username &&
|
|
!parsed.password;
|
|
return safe ? target : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The review question sentence, with the target label as an external link.
|
|
* Mirrors `ReviewTarget::question_text_with_link` in
|
|
* `lib/foundation/fabro-types/src/interview.rs`.
|
|
*/
|
|
export function ReviewTargetQuestion({
|
|
target,
|
|
className,
|
|
}: {
|
|
target: ReviewTarget;
|
|
className?: string;
|
|
}) {
|
|
return (
|
|
<p className={className}>
|
|
Review the{" "}
|
|
<a
|
|
href={target.url}
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
referrerPolicy="no-referrer"
|
|
className="inline-flex items-baseline gap-1 font-semibold text-teal-300 underline decoration-teal-500/50 underline-offset-2 transition-colors hover:text-fg focus-visible:rounded-sm focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-teal-500"
|
|
>
|
|
<span>{target.label}</span>
|
|
<ArrowTopRightOnSquareIcon
|
|
className="size-3 shrink-0 self-center"
|
|
aria-hidden="true"
|
|
/>
|
|
</a>{" "}
|
|
{target.kind}, then choose the next action.
|
|
</p>
|
|
);
|
|
}
|