mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-08-28 05:27:41 +00:00
1af6a3d8be
Both from Copilot review feedback on #652. Do not fall back to `base_sha` for `final_git_commit_sha`: `base_sha` is where the run started, not what it produced. When a run made commits but no SHA was tracked, the conclusion reported the base commit as the run's final commit — a durable, API-exposed field — and publish then checked the pushed branch against it, failing a branch that was pushed correctly. The SHA is now only required where it is actually used: verifying the remote head before opening a pull request. Pushing never needed it, since the refspec sends whatever the branch points at. A run with no tracked SHA therefore still pushes its branch and succeeds; it fails only if a pull request is requested, where an unverifiable head is a real problem. Route branch names with slashes in the GitHub twin: Run branches are `fabro/run/<id>`. GitHub routes the branch as the remainder of the path, but the twin declared a single-segment `{branch}` capture, so every real run branch 404'd against it. Now a wildcard, with a test covering the slashed case that the existing single-segment tests missed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| github | ||
| openai | ||