15 commits

Author	SHA1	Message	Date
Bryan Helmkamp	daaca3f479	refactor: simplify artifact ZIP download ... Path safety now lives in one place. The NUL-byte and drive-letter rules move from a server-only helper into the store's own filename validation, so uploads reject those paths at write time instead of only the ZIP read path catching them. The download still re-checks, because artifacts stored before the rule existed can still carry an unsafe path, but it now skips a bad path rather than failing the whole archive. Promote is_boundary_stage to RunProjection and drop the three identical private copies. The ZIP download used a node-name match instead, which would have dropped artifacts from a working node that happened to be named "start". Compress the archive. Entries were Stored while the response was also excluded from transfer compression, so text artifacts moved at full size. async_zip gains the deflate feature; async-compression and flate2 were already in the lock file. Log archive failures unconditionally. The send-succeeded guard meant a client that had already disconnected left no record at all, which is the case where the log is the only evidence. Also: collapse the duplicate 500 arms, drop the dead stage-ID tiebreaker and the cached order in the selection map, name the accessible label after the visible one, share the run URL prefix between the two download href builders, and document the mid-stream truncation behavior in the OpenAPI description. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-01 09:09:54 -04:00
Bryan Helmkamp	980aabc543	feat: download latest artifacts as zip	2026-07-31 13:23:35 -04:00
fabro-sh-fabro[bot]	c945fb404b	feat: add MCP servers settings UI at /settings/mcps (#540) ... ## Summary Adds a full CRUD management UI for server-managed MCP servers at `/settings/mcps`, consuming the already-shipped `MCPServersApi` backend. The implementation mirrors the existing `/settings/environments` pages exactly in structure, naming, and component conventions. ## What changed ### Step 1 — Shared `KeyValueEditor` extracted `KeyValueEditor`, `KeyValueEntry`, `entriesFromMap`, and `mapFromEntries` are moved from `environment-form.tsx` into a new `components/key-value-editor.tsx`. The component gains an optional `renderEntryHint` prop so per-row warnings can be injected without coupling the editor to credential logic. `Label` is promoted from `environment-form.tsx` to `settings-panel.tsx` so both forms can use it. ### Step 2–4 — Query plumbing - `query-keys.ts`: `mcpServers.{list, detail}` keys. - `api-client.ts`: `mcpServersApi` instance (same pattern as `environmentsApi`). - `queries.ts`: `useMcpServers()` and `useMcpServer(id)` SWR hooks. ### Step 5 — Credential heuristics (`lib/credential-heuristics.ts`) Pure functions `looksLikeCredential`, `secretNameForKey`, `secretReference`. Key-name matching covers `authorization`, `password`, `token`, `api[-_]?key`, `_key`/`_token`/`_secret` suffixes. Value-entropy fallback fires for strings ≥ 20 chars, no spaces, mixed case/digit classes. Template references (`{{ secrets.* }}`) are never flagged. ### Step 6–7 — Form model + component (`components/mcp-server-form.tsx`) - Flat `McpServerFormValues` discriminated on `McpTransportKind`. - `defaultMcpServerFormValues`, `mcpServerToFormValues` (populates `env`/`headers` from `env_keys`/`header_keys` with **empty values** — the §5 write-only design), `createRequestFromForm`, `replaceRequestFromForm`, `isMcpServerFormValid`, `credentialWarnings`. - `McpServerFormFields` renders stdio / http / sandbox panels switching on `values.transport`. Per-row credential nudge opens the secrets-new page in a new tab and substitutes a `{{ secrets.NAME }}` reference; save is never blocked by the heuristic. - On edit, a row with a non-empty key and empty value blocks save with an inline error (the intentional overwrite guard). ### Step 8–10 — Route pages | File | Mirrors | |---|---| | `routes/settings-mcps.tsx` | `settings-environments.tsx` | | `routes/settings-mcps-new.tsx` | `settings-environments-new.tsx` | | `routes/settings-mcps-edit.tsx` | `settings-environments-edit.tsx` | The edit page shows a write-only-values banner whenever the transport has any `env_keys`/`header_keys`, uses `key={server.revision}` to remount the form on external change, and translates 409 responses into the `staleAwareMessage` pattern. ### Steps 11–12 — Router + nav Three routes registered under `settings` children. `PuzzlePieceIcon` nav entry added to the same section as Environments. ### Plan Summary - Extract `KeyValueEditor` to shared component with hint-injection slot - Credential heuristics library (pure, fully unit-tested) - MCP form model: flat values ↔ discriminated API types, write-only-key guard - List / new / edit pages following environments pattern exactly - Route registration and settings nav link ### Fabro Details <details> <summary>Ran 9 stages in 65m 58s for $20.54</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 47s | – | 0 | | preflight_lint | 4m 15s | – | 0 | | implement | 26m 29s | $12.27 | 0 | | simplify_opus | 7m 41s | $4.95 | 0 | | simplify_gpt | 6m 51s | $2.69 | 0 | | verify | 15m 44s | – | 0 | | fixup | 1m 41s | $0.63 | 0 | | **Total** | **65m 58s** | **$20.54** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-8; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-07-01 10:32:37 -04:00
Bryan Helmkamp	bc0bda73a6	feat(web): add server-managed Environments CRUD settings UI (#462) ... ## What Adds a CRUD interface for **server-managed Environments** at `/settings/environments`, driven by the `/api/v1/environments` REST API (list / create / retrieve / replace / delete), and reshapes how built-in environments are provisioned and protected. The page lives in the **Workflows** settings nav section (also introduced in this branch), positioned before Variables. ## Why The Environments REST API shipped (#453) but had no UI — environments could only be managed via the API/CLI. This gives operators a web UI alongside Variables and Secrets, and along the way tightens the model: environments are seeded at install time (not silently re-created on every boot), and the `default` fallback is an ordinary, deletable environment. ## Web UI **Pages & component** - `settings-environments.tsx` — list view: provider badge, image/resource summary, row actions (Edit/Delete). **"New environment" is a dropdown** of the enabled sandbox providers; the chosen provider is fixed for the environment's lifetime. - `settings-environments-new.tsx` / `settings-environments-edit.tsx` — create/edit flows; create reads the provider from a query param. - `environment-form.tsx` — shared form, reorganized: - **General** panel (merged identity + image): id, and an **image-source selector** (Image reference *vs* inline Dockerfile) that shows, requires, and sends only the selected, mutually-exclusive source. - **Resources**: CPU / memory / disk as **range sliders** (CPU 1–8, memory 1–16 GB, disk 1–20 GB), each always writing a concrete value. - **Environment variables** key/value editor. - **Advanced** progressive-disclosure section holding **Network** (a single "Block all network access" toggle — allow-all vs block) and **Lifecycle** (preserve / stop-on-terminal / auto-stop). Opens by default when any advanced value is non-default. - The in-form **provider control and the Labels editor were removed** — labels remain API-managed and are round-tripped untouched so UI edits never clear them. **Data layer**: `environmentsApi` client, `queryKeys.environments`, `useEnvironments` / `useEnvironment` SWR hooks. **Nav & routing**: "Environments" item in the Workflows section before Variables; routes registered in `router.tsx`. ## Backend: seed at install, deletable `default` - **Seeding moved to install time.** The server no longer seeds built-ins on startup; `EnvironmentStore::load_or_seed` → `load` (load-only). A new public `seed_environments(dir)` (idempotent, preserves operator edits) is called by both the web installer and the CLI installer. An uninstalled instance therefore has no managed environments, and a run selecting an absent environment fails explicitly (`unknown environment: default`) rather than resurrecting a built-in. - **`default` is no longer protected.** The delete guard and the `Protected` error variant are gone; deleting `default` succeeds (204) and removes the run fallback on purpose — forcing an explicit choice. `local` is unchanged (reserved, in-memory). - **`volumes` removed** from environment settings across the OpenAPI spec, generated Rust + TS clients, config layers, sandbox/server/workflow plumbing, docs, and tests. ## API contract details honored - Edit sends the environment `revision` as `If-Match`; 409 conflicts surface a "changed since you opened it" message. - The REST API accepts inline Dockerfiles only — the form never sends a Dockerfile path. ## Verification - Rust: `cargo build` (touched crates) ✅, `cargo nextest -p fabro-environment` 21/21 ✅, server env unit + `tests/it` integration 2/2 + 15/15 ✅, `clippy` (nightly, touched crates, all targets) clean ✅, `fmt --check` clean ✅. Full `--workspace` suite not run here — worth a CI pass. - Web: `bun run typecheck` ✅, `bun run build` ✅, `environment-form.test.ts` 5/5 ✅. Web suite: 512 pass / 1 unrelated pre-existing `RunDetail` failure. - **Not visually verified in-browser** — the local app is login-gated and automated loads redirect to `/login`; rendering of the form, the New-environment dropdown, and `default` delete should be confirmed in a logged-in session. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: fabro-sh-0530[bot] <281434857+fabro-sh-0530[bot]@users.noreply.github.com> Co-authored-by: Fabro <noreply@fabro.sh> Co-authored-by: Release Repro <release-repro@example.com>	2026-06-13 08:44:38 -04:00
Bryan Helmkamp	87516c25ce	feat(automations): wire UI to API and auto-start runs from API trigger ... Make the Automations area in the web UI functional end-to-end against the real Automation API, and fix the backend so runs created by an automation's API trigger actually start instead of sitting in Submitted forever. Web: - Reveal the Automations nav tab outside demo mode; drop the now-empty demoOnly mechanism. - List page: render via listAutomations (was workflows mock data); wire ellipsis menu to Edit and Delete, with ConfirmDialog + If-Match revision. Move Create Automation into the toolbar, switch the trigger select to a shared FilterButton, hide the redundant page-header title via a new hideTitle handle flag. - Play button on each card fires createAutomationRun with spinner + toast and navigates to the new run. - New automation form: drop the dead Goal panel and hardcoded repository list, post to createAutomation with real triggers. - Edit automation: new /automations/:id/edit route reusing a shared AutomationFormFields component, PUT via replaceAutomation with If-Match. - Show page: rebuild like a run detail page — breadcrumb, title, chips (enabled status, repo+ref, workflow, schedule), Edit + Run actions (Run hits createAutomationRun), and a Runs panel using RunsListView with URL-driven search/sort/pagination/column-picker like the Children sub-tab. Drop the obsolete Definition/Diagram/Runs child routes. Backend (fabro-server): - create_automation_run now calls lifecycle::queue_run_start after the run is persisted, so the run transitions Submitted → Runnable and the scheduler picks it up. Logs a warn and returns the created response if start fails (no worse than the prior always-stuck behavior). - queue_run_start in lifecycle.rs is promoted to pub(super) so sibling handlers can reuse it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-28 20:24:09 -04:00
Bryan Helmkamp	03d2a9acdd	feat(web): add /settings/variables management UI ... Adds a sidebar-linked Variables page above Secrets that lists, creates, edits, and deletes variables via the new /api/v1/variables endpoints. Values are shown inline since variables are non-sensitive. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:14:41 -04:00
fabro-sh-0530[bot]	b196a97ac4	Introduce approved effect hooks and migrate direct useEffect calls (#425) ... ## Summary Implements the React Effects Policy by creating the approved hook surface in `hooks/effects.ts` and migrating a broad set of direct `useEffect` calls across the codebase to either purpose-named hooks or non-effect patterns. ### Plan Summary - Add `hooks/effects.ts` exporting `useMountEffect`, `useInterval`, `useTimeout`, `useDebouncedValue`, `useWindowEvent`, `useDocumentEvent`, `useDocumentTitle`, `useMediaQuery`, `useLocationHash`, and `useResizeObserver` - Extract large imperative effects into purpose-named hooks: `useTerminalSession`, `useFloatingTooltipMeasurements`, `useAnnotatedRunGraphSvg`, `useInstallEffects`, and others - Move install session fetch from a component effect into a SWR query (`install-query.ts`) - Replace `useEffect` + `useState` state-derivation patterns with render-time computation or ref callbacks - Replace `AskFabroLayoutProvider`/`useAskFabroLayout` context with a prop callback ## What changed and why **`hooks/effects.ts`** — the new approved primitive surface. All internal `useEffect` calls here are intentional; the hooks expose the *external system* they manage rather than leaking `useEffect` to component code. `useMediaQuery` and `useLocationHash` use `useSyncExternalStore` instead of effect + state. **`useTerminalSession`** — the largest extraction. The 130-line xterm/WebSocket/ResizeObserver setup block moves from `terminal-view.tsx` into its own hook, which now owns the `terminalRef`, `fitRef`, and `socketRef` that previously cluttered the component. `TerminalConnectionError` and `ConnectionStatus` types are exported from the hook. **`useFloatingTooltipMeasurements`** — extracts the `useLayoutEffect` + ResizeObserver + window resize listener out of `FloatingTooltip`. The `FloatingTooltipSize` type moves with it so consumers don't need to import from the component. **`useInstallSessionQuery` + `useInstallEffects`** — the install session fetch moves from a component effect to SWR (`install-query.ts`). The three remaining install effects (token URL scrubbing, GitHub error URL scrubbing, health-poll restart) move into `hooks/use-install-effects.ts`. The root-redirect effect is replaced with a render-time `<Navigate>` gate. The `SessionState` discriminant now carries `token` so stale query results can be discarded without an effect chain. **`SelectionCheckbox`** — `useEffect` setting `input.indeterminate` is replaced with a ref callback, which runs synchronously after the node is attached and avoids a stale-frame flash. **`event-debug.tsx`** — the manual `window.addEventListener("keydown", ...)` pattern is replaced with `useWindowEvent`, removing the `react-doctor-disable` suppression comments. **`run-waterfall.tsx`** — the local `useTickingNow` is deleted; `RunWaterfall` now calls the shared `useTickingNow` from `lib/time` with the new `active` parameter signature. **`toast.test.tsx`** — `useEffect(() => onReady?.(api), ...)` in the test helper is replaced with a direct call during render, which is valid because `onReady` has no side effects that React cares about. **`AskFabroSidebar`** — `setIsResizing` from the layout context is replaced with an `onResizeActiveChange` prop, removing the `useAskFabroLayout` call and the hidden context coupling from the sidebar. ### Fabro Details <details> <summary>Ran 3 stages in 114m 5s for $95.71</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | work | 103m 3s | $80.42 | 0 | | audit | 10m 19s | $15.29 | 0 | | **Total** | **114m 5s** | **$95.71** | **0** | </details> <details> <summary>Ran <code>Goal.fabro</code> (4 nodes and 5 edges)</summary> ```dot digraph Goal { graph [ goal="Complete the user-provided goal", rankdir=LR, max_node_visits=30 ] start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] work [ label="Work", thread_id="goal", fidelity="full", max_visits=12, model="gpt-55", reasoning_effort="xhigh", prompt="@prompts/continue.md" ] audit [ label="Completion Audit", thread_id="goal", fidelity="full", goal_gate=true, retry_target="work", output_schema="routing", output_retries=2, max_visits=12, model="gpt-55", reasoning_effort="xhigh", prompt="@prompts/audit.md" ] start -> work -> audit audit -> exit [label="Done", condition="outcome=succeeded"] audit -> work [label="Continue", condition="outcome=failed || preferred_label=Continue"] audit -> work [label="No clear verdict"] } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh> Co-authored-by: Bryan Helmkamp <bryan@brynary.com>	2026-05-27 10:37:29 -04:00
Bryan Helmkamp	62f0b3e7d1	refactor(web): improve React Doctor score (#405) ... ## Summary Improves the web UI's React Doctor audit score by separating reusable helpers from React component modules, tightening effect/state ownership, and extracting real component boundaries in the install wizard, stage activity view, run-files diff browser, RunDetail route, and Runs workspace. The branch removes the previously deferred RunDetail and Runs giant-component diagnostics without changing RunDetail UX, route contracts, action ordering, or Runs workspace behavior. | Metric | Main baseline | Initial PR | Current PR | |--------|---------------|------------|------------| | React Doctor score | 63 | 71 | 99 | | React Doctor errors | 123 | 0 | 0 | | React Doctor warnings | 241 | 163 | 3 | | React Doctor diagnostics | 364 | 163 | 3 | ## Changes - Moves exported helper logic out of component files so Fast Refresh/component-export rules no longer dominate the audit. - Adds a targeted React Doctor config exception for React Router route modules, where non-component exports like route metadata are intentional. - Refactors low-risk state/effect patterns: keyed interview question state, reducer-backed editable run title state, event-owned preview opening, route-keyed insights editor initialization, refresh timer ownership, and selection/derived list cleanup. - Reworks `InstallApp` around an install reducer, a controller hook for install lifecycle state, and focused wizard step components for LLM, server, object-store, sandbox, and GitHub setup. - Moves `RunStages` selected-stage activity into a keyed boundary for panel/debug detail state while preserving stage activity filters across navigation. - Extracts the `RunFiles` loaded diff-browser view from route/query coordination so the route owns data/URL state and the loaded view owns rendering. - Splits `RunDetail` into route-local header, actions, tab shell, docked controls, model, and lifecycle-toast modules; the actions menu now uses grouped descriptors instead of a large boolean/callback prop matrix. - Extracts Runs workspace preference ownership into `useRunsWorkspacePreferences` and moves toolbar rendering into `RunsToolbar`, leaving the route focused on data, DnD state, filtering, and view selection. - Guards `InsightsEditor` query execution with a latest-run id and timeout cleanup so stale or unmounted mock query runs cannot overwrite newer results. - Adds regression coverage for archived-run deletion from RunDetail and stale-result handling in InsightsEditor. - Improves semantic/accessibility coverage with labeled controls, native meter/section semantics, decorative status dots, and clearer unavailable copy. - Removes dead UI code and applies local suppressions only where the rule is a documented false positive or an intentional imperative integration boundary. ## Remaining React Doctor warnings Current score is 99 with 0 errors and 3 warnings. The remaining warnings are intentionally left for separate judgment rather than mechanical churn: - `prefer-useReducer` (3): `AutomationsNew`, `InsightsEditor`, and `CreateSecretForm` need reducers only if they encode real coupled transitions, not simple field setters. ## Verification - `cd apps/fabro-web && bun test app/routes/run-detail.test.ts` -> `22 pass`, `0 fail` - `cd apps/fabro-web && bun test app/routes/insights-editor.test.tsx app/routes/runs.preferences.test.tsx` -> `7 pass`, `0 fail` - `cd apps/fabro-web && bun run typecheck` - `cd apps/fabro-web && bun test --isolate` -> `490 pass`, `0 fail` - `cd apps/fabro-web && bunx react-doctor@latest --full --json > /tmp/fabro-react-doctor-runs-insights.json` -> score `99`, `0` errors, `3` warnings - Earlier branch verification also included `cd apps/fabro-web && bun run build` - `git diff --check` --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 (context not reported, default reasoning) via [Codex](https://openai.com/codex)	2026-05-25 22:41:37 -04:00
Bryan Helmkamp	296fbddec9	feat(api): add ask fabro session endpoints (#342) ... ## Summary Adds the run-backed API surface needed for a real Ask Fabro sidebar: run readiness metadata, detailed session projections, session-scoped event listing/attach streaming, and turn control that exposes durable turn IDs and machine-readable failures. ## What Changed - Extended the OpenAPI contract and regenerated Rust/TypeScript clients for `Run.ask_fabro`, `SessionDetail`, `SessionTurn`, paginated run sessions, session event APIs, and optional client-supplied `turn_id` values. - Updated `fabro-types` and `fabro-store` so durable `run.session.*` events project active turn state, transcript messages, and the latest owning run event sequence. - Implemented server routing for session details, `/events`, `/attach`, turn conflict headers, typed turn failure codes, and cheap run readiness decoration across run responses. - Added browser helpers for POST turn streaming and session attach SSE parsing, plus an exported generated `sessionsApi`. ## Verification - `cargo +nightly-2026-04-14 fmt --check --all` - `cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings` - `cargo build --workspace` - `cargo test -p fabro-types run_session_turn_failed_defaults_code_for_old_events` - `cargo test -p fabro-store run_sessions::tests` - `cargo test -p fabro-api` - `cargo test -p fabro-server --features test-support --test it api::sessions` - `cargo test -p fabro-server --features test-support --test it api::runs` - `cd apps/fabro-web && bun test app/lib/session-stream.test.ts` - `cd apps/fabro-web && bun run typecheck` --- [](https://github.com/EveryInc/compound-engineering-plugin) 🤖 Generated with GPT-5 Codex (context unknown, medium reasoning) via [Codex](https://openai.com/codex/)	2026-05-21 21:26:15 -04:00
Bryan Helmkamp	412f57f5ae	feat(web): add secrets management settings page (#327) ... ## What Adds a **Settings → Secrets** page so secrets can be managed from the browser, backed by the existing secrets HTTP API and generated TS client. - **`/settings/secrets`** — lists stored secrets (name, type badge, description, last-updated) and deletes them through the shared confirm dialog. - **`/settings/secrets/new`** — the create form for **token** and **file** secrets. OAuth secrets still list and delete here, but are created by provider sign-in flows, not typed by hand (matching the CLI's `secret set`). - The **Secrets** entry is added to the settings sidebar nav. ## How - `secretsApi` wired into `api-client.ts`; `useSecrets()` SWR hook + `secrets` query key. - New sibling routes `secrets` and `secrets/new` under `settings` (same pattern as `runs` / `runs/:id`). - The settings layout gains optional **handle-driven** `description` and `headerAction`. When a page declares them, the layout renders title + subheading + a vertically-centered header action button as one unified header. Other settings pages are unaffected — they fall back to the existing title-only header. ## Notes - Values are write-only: the API never returns secret values, and the UI never displays them. - Reuses existing primitives throughout (`Panel`, `Badge`, `ConfirmDialog`, `useToast`, button/input classes) — no new shared components. - Verified: `bun run typecheck` and `bun run build` pass; routes serve 200. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 17:50:09 -04:00
Bryan Helmkamp	fbe8b50a16	feat(server): add GET /api/v1/providers and /settings/models page (#321) ... ## Summary Operators had no UI surface to see which LLM providers their Fabro server has configured — provider state was only inferable indirectly via the per-model `configured` flag on `GET /api/v1/models`. This adds a dedicated **Models** settings tab backed by a new providers endpoint. - **`fabro_model::Provider`** — a public projection of the internal `CatalogProvider` that *structurally* excludes credential-bearing fields (`auth`, `extra_headers`, `billing_policy`, `agent_profile`). Reused by the generated API client via progenitor `with_replacement`, mirroring the existing `Model` pattern — no parallel API DTO. - **`GET /api/v1/providers`** — lists catalog providers with effective config and a `configured` status stamped per request from `ready_llm_provider_ids()`. Sorted by the catalog's existing `provider_order`. No write endpoints. - **`/settings/models` web page** — new route + nav entry (`CpuChipIcon`, between Integrations and Security) rendering each provider with model count, default model, configured status, and a "Get API key" link for unconfigured providers. ## Key decisions - Provider sort: reuse catalog `provider_order` (priority desc, id asc) — zero extra code. - `adapter` is hidden in the UI row (noisy for first-party providers); the OpenAPI `adapter` field is pinned to an enum matching the closed `AdapterKind` type. - `configured` reflects credential resolution **at the time of the response**, not a frozen startup snapshot — doc/spec wording corrected to match. ## Testing - `fabro-model`: `From<&CatalogProvider>` + serde `skip_serializing_if` unit tests. - `fabro-api`: `Provider` type-identity + JSON-parity tests, including the required/optional field split. - `fabro-server`: handler tests for configured vs unconfigured providers, exact `model_count`/`default_model` against catalog truth, and credential-omission (asserts internal field names *and* the injected credential value never reach the wire). - OpenAPI route conformance test covers `GET /api/v1/providers`. - `cargo build --workspace`, `fmt --check`, `clippy -D warnings` clean; 935 Rust tests pass; web `tsc` typecheck passes. - Reviewed via a 10-persona `ce:review` (autofix) — no P0/P1 in shipped code; 8 safe fixes applied. Not done: manual UI screenshots — the `apps/fabro-web` build is blocked in this environment by an unrelated missing `@assistant-ui/react` dependency. Run `bun install` in `apps/fabro-web` to verify `/settings/models` manually. ## Post-Deploy Monitoring & Validation - **What to watch:** request logs for `GET /api/v1/providers` — expect `200`s for authenticated users, `401` for unauthenticated. The handler resolves LLM credentials per request via `ready_llm_provider_ids()` (the same path the existing `list_models` handler already uses). - **Healthy signals:** `/settings/models` renders the provider list; `configured` matches each provider's actual credential state; no credential strings appear in any response body or log line. - **Failure signals / rollback trigger:** any provider object in the response containing `auth`, `extra_headers`, or a raw key/token value → roll back immediately (the projection type makes this structurally impossible, but treat any occurrence as P0). 5xx spikes on the new route. - **Validation window / owner:** first 24h after deploy, owned by the deploying engineer. Pre-existing note (not introduced here): credential resolution can refresh OAuth tokens and write the vault as a side effect of this read — shared with `list_models`; flagged for a future caching pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 09:05:00 -04:00
Bryan Helmkamp	b0dfd6b3b4	fix(api): type interview answer submissions ... Replace the loose interview answer request payload with a discriminated OpenAPI union so generated clients enforce the wire contract. Surface structured HTTP error details in the web client and update browser, CLI, and server answer submission paths to use the typed variants.	2026-05-08 09:18:35 -07:00
Bryan Helmkamp	9b9ebdf50b	feat(web): migrate to generated API client ... Expand the OpenAPI contract for frontend auth and workflow routes, regenerate the TypeScript Axios client, and route web API calls through generated client classes while preserving SSE and install exceptions.	2026-05-08 07:44:33 -07:00
fabro-sh-0530[bot]	6e36d8350e	Render stage activity from scoped events endpoint (#212) ... ## Summary Stage detail now loads activity from a canonical stage-scoped events endpoint instead of falling back to the first 1000 run-wide events. This fixes empty panes for late stages in long runs and removes the presentation-shaped `StageTurn` API from the wire. ### Plan Summary - Add `GET /runs/{id}/stages/{stageId}/events` with cursor pagination and server-side `node_id` filtering. - Replace frontend stage-turn/fallback loading with paginated stage-events loading and local event-to-activity projection. - Broaden SSE/SWR invalidation so every activity event consumed by the reducer refreshes the per-stage cache. - Remove `StageTurn` schemas/client models and update demo fixtures plus pagination/handler/reducer tests. ## What changed and why The store now scans the run event prefix and filters by `node_id` before applying the `limit + 1` cutoff. That preserves sparse late-stage matches that would otherwise be dropped if we reused the run-wide limited scan and filtered afterward. The real-mode handler returns an empty page for an unknown stage id in an existing run, while preserving 404 for missing runs. On the frontend, `run-stages` fetches all pages for the selected stage and feeds them through `eventsToActivity`, keeping `TurnType` as a local presentation model. Invalidation now targets `runs.stageEvents(runId, stageId)` for lifecycle and reducer-consumed activity events (`stage.prompt`, agent messages/tools, and command events), so active panes refresh from the existing run event subscription. The OpenAPI document and generated TS client now expose `listStageEvents` and drop stale `StageTurn` models. Demo mode serves a `detect-drift` stage-events fixture using the same cursor semantics as the real endpoint. ## API notes `/runs/{id}/stages/{stageId}/turns` is removed; clients should use `/runs/{id}/stages/{stageId}/events?since_seq=&limit=` and project events locally. The `stageId` path segment for this endpoint is the workflow node id, not the visit-qualified `node_id@visit` form used by command logs/artifacts. ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh> Co-authored-by: Bryan Helmkamp <bryan@brynary.com>	2026-05-05 09:16:52 -04:00
Bryan Helmkamp	a1f032e166	refactor(web): move server state to SWR ... Replace React Router loader/action state paths with SWR query and mutation hooks. Add targeted run and board EventSource managers that invalidate SWR keys, and refresh embedded SPA assets.	2026-04-25 07:16:41 -04:00