2 commits

Author	SHA1	Message	Date
fabro-sh-fabro[bot]	c945fb404b	feat: add MCP servers settings UI at /settings/mcps (#540) ... ## Summary Adds a full CRUD management UI for server-managed MCP servers at `/settings/mcps`, consuming the already-shipped `MCPServersApi` backend. The implementation mirrors the existing `/settings/environments` pages exactly in structure, naming, and component conventions. ## What changed ### Step 1 — Shared `KeyValueEditor` extracted `KeyValueEditor`, `KeyValueEntry`, `entriesFromMap`, and `mapFromEntries` are moved from `environment-form.tsx` into a new `components/key-value-editor.tsx`. The component gains an optional `renderEntryHint` prop so per-row warnings can be injected without coupling the editor to credential logic. `Label` is promoted from `environment-form.tsx` to `settings-panel.tsx` so both forms can use it. ### Step 2–4 — Query plumbing - `query-keys.ts`: `mcpServers.{list, detail}` keys. - `api-client.ts`: `mcpServersApi` instance (same pattern as `environmentsApi`). - `queries.ts`: `useMcpServers()` and `useMcpServer(id)` SWR hooks. ### Step 5 — Credential heuristics (`lib/credential-heuristics.ts`) Pure functions `looksLikeCredential`, `secretNameForKey`, `secretReference`. Key-name matching covers `authorization`, `password`, `token`, `api[-_]?key`, `_key`/`_token`/`_secret` suffixes. Value-entropy fallback fires for strings ≥ 20 chars, no spaces, mixed case/digit classes. Template references (`{{ secrets.* }}`) are never flagged. ### Step 6–7 — Form model + component (`components/mcp-server-form.tsx`) - Flat `McpServerFormValues` discriminated on `McpTransportKind`. - `defaultMcpServerFormValues`, `mcpServerToFormValues` (populates `env`/`headers` from `env_keys`/`header_keys` with **empty values** — the §5 write-only design), `createRequestFromForm`, `replaceRequestFromForm`, `isMcpServerFormValid`, `credentialWarnings`. - `McpServerFormFields` renders stdio / http / sandbox panels switching on `values.transport`. Per-row credential nudge opens the secrets-new page in a new tab and substitutes a `{{ secrets.NAME }}` reference; save is never blocked by the heuristic. - On edit, a row with a non-empty key and empty value blocks save with an inline error (the intentional overwrite guard). ### Step 8–10 — Route pages | File | Mirrors | |---|---| | `routes/settings-mcps.tsx` | `settings-environments.tsx` | | `routes/settings-mcps-new.tsx` | `settings-environments-new.tsx` | | `routes/settings-mcps-edit.tsx` | `settings-environments-edit.tsx` | The edit page shows a write-only-values banner whenever the transport has any `env_keys`/`header_keys`, uses `key={server.revision}` to remount the form on external change, and translates 409 responses into the `staleAwareMessage` pattern. ### Steps 11–12 — Router + nav Three routes registered under `settings` children. `PuzzlePieceIcon` nav entry added to the same section as Environments. ### Plan Summary - Extract `KeyValueEditor` to shared component with hint-injection slot - Credential heuristics library (pure, fully unit-tested) - MCP form model: flat values ↔ discriminated API types, write-only-key guard - List / new / edit pages following environments pattern exactly - Route registration and settings nav link ### Fabro Details <details> <summary>Ran 9 stages in 65m 58s for $20.54</summary> | Stage | Duration | Cost | Retries | |---|---|---|---| | start | 0s | – | 0 | | toolchain | 1s | – | 0 | | preflight_compile | 2m 47s | – | 0 | | preflight_lint | 4m 15s | – | 0 | | implement | 26m 29s | $12.27 | 0 | | simplify_opus | 7m 41s | $4.95 | 0 | | simplify_gpt | 6m 51s | $2.69 | 0 | | verify | 15m 44s | – | 0 | | fixup | 1m 41s | $0.63 | 0 | | **Total** | **65m 58s** | **$20.54** | **0** | </details> <details> <summary>Ran <code>ImplementPlan.fabro</code> (11 nodes and 14 edges)</summary> ```dot digraph ImplementPlan { graph [ goal="Implement and simplify", model_stylesheet=" * { model: claude-opus-4-8; } " ] rankdir=LR start [shape=Mdiamond, label="Start"] exit [shape=Msquare, label="Exit"] toolchain [label="Toolchain", shape=parallelogram, script="command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", max_retries=0] preflight_compile [label="Preflight Compile", shape=parallelogram, script="cargo check -q --workspace 2>&1", max_retries=0] preflight_lint [label="Preflight Lint", shape=parallelogram, script="cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", max_retries=0] fix_lints [label="Fix Lints", prompt="The preflight lint step failed. Read the build output from context and fix all clippy lint warnings.", max_visits=3] implement [label="Implement", prompt="Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.", model="gpt-55", reasoning_effort="xhigh"] simplify_opus [label="Simplify (Opus)", prompt="@prompts/simplify.md"] simplify_gpt [label="Simplify (GPT-55)", prompt="@prompts/simplify.md", model="gpt-55"] verify [label="Verify", shape=parallelogram, script="git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\bActorRef\b|\bActorKind\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\s*==\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1", goal_gate=true, retry_target="fixup"] fixup [label="Fixup", prompt="The verify step failed. Read the build output from context and fix all format, clippy, Rust test, docs, TypeScript typecheck/test, and build failures.", max_visits=3] start -> toolchain toolchain -> preflight_compile [condition="outcome=succeeded"] toolchain -> exit preflight_compile -> preflight_lint [condition="outcome=succeeded"] preflight_compile -> exit preflight_lint -> implement [condition="outcome=succeeded"] preflight_lint -> fix_lints fix_lints -> preflight_lint implement -> simplify_opus -> simplify_gpt -> verify verify -> exit [condition="outcome=succeeded"] verify -> fixup fixup -> verify } ``` </details> ⚒️ Generated with [Fabro](https://fabro.sh) --------- Co-authored-by: Fabro <noreply@fabro.sh>	2026-07-01 10:32:37 -04:00
Bryan Helmkamp	bc0bda73a6	feat(web): add server-managed Environments CRUD settings UI (#462) ... ## What Adds a CRUD interface for **server-managed Environments** at `/settings/environments`, driven by the `/api/v1/environments` REST API (list / create / retrieve / replace / delete), and reshapes how built-in environments are provisioned and protected. The page lives in the **Workflows** settings nav section (also introduced in this branch), positioned before Variables. ## Why The Environments REST API shipped (#453) but had no UI — environments could only be managed via the API/CLI. This gives operators a web UI alongside Variables and Secrets, and along the way tightens the model: environments are seeded at install time (not silently re-created on every boot), and the `default` fallback is an ordinary, deletable environment. ## Web UI **Pages & component** - `settings-environments.tsx` — list view: provider badge, image/resource summary, row actions (Edit/Delete). **"New environment" is a dropdown** of the enabled sandbox providers; the chosen provider is fixed for the environment's lifetime. - `settings-environments-new.tsx` / `settings-environments-edit.tsx` — create/edit flows; create reads the provider from a query param. - `environment-form.tsx` — shared form, reorganized: - **General** panel (merged identity + image): id, and an **image-source selector** (Image reference *vs* inline Dockerfile) that shows, requires, and sends only the selected, mutually-exclusive source. - **Resources**: CPU / memory / disk as **range sliders** (CPU 1–8, memory 1–16 GB, disk 1–20 GB), each always writing a concrete value. - **Environment variables** key/value editor. - **Advanced** progressive-disclosure section holding **Network** (a single "Block all network access" toggle — allow-all vs block) and **Lifecycle** (preserve / stop-on-terminal / auto-stop). Opens by default when any advanced value is non-default. - The in-form **provider control and the Labels editor were removed** — labels remain API-managed and are round-tripped untouched so UI edits never clear them. **Data layer**: `environmentsApi` client, `queryKeys.environments`, `useEnvironments` / `useEnvironment` SWR hooks. **Nav & routing**: "Environments" item in the Workflows section before Variables; routes registered in `router.tsx`. ## Backend: seed at install, deletable `default` - **Seeding moved to install time.** The server no longer seeds built-ins on startup; `EnvironmentStore::load_or_seed` → `load` (load-only). A new public `seed_environments(dir)` (idempotent, preserves operator edits) is called by both the web installer and the CLI installer. An uninstalled instance therefore has no managed environments, and a run selecting an absent environment fails explicitly (`unknown environment: default`) rather than resurrecting a built-in. - **`default` is no longer protected.** The delete guard and the `Protected` error variant are gone; deleting `default` succeeds (204) and removes the run fallback on purpose — forcing an explicit choice. `local` is unchanged (reserved, in-memory). - **`volumes` removed** from environment settings across the OpenAPI spec, generated Rust + TS clients, config layers, sandbox/server/workflow plumbing, docs, and tests. ## API contract details honored - Edit sends the environment `revision` as `If-Match`; 409 conflicts surface a "changed since you opened it" message. - The REST API accepts inline Dockerfiles only — the form never sends a Dockerfile path. ## Verification - Rust: `cargo build` (touched crates) ✅, `cargo nextest -p fabro-environment` 21/21 ✅, server env unit + `tests/it` integration 2/2 + 15/15 ✅, `clippy` (nightly, touched crates, all targets) clean ✅, `fmt --check` clean ✅. Full `--workspace` suite not run here — worth a CI pass. - Web: `bun run typecheck` ✅, `bun run build` ✅, `environment-form.test.ts` 5/5 ✅. Web suite: 512 pass / 1 unrelated pre-existing `RunDetail` failure. - **Not visually verified in-browser** — the local app is login-gated and automated loads redirect to `/login`; rendering of the form, the New-environment dropdown, and `default` delete should be confirmed in a logged-in session. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: fabro-sh-0530[bot] <281434857+fabro-sh-0530[bot]@users.noreply.github.com> Co-authored-by: Fabro <noreply@fabro.sh> Co-authored-by: Release Repro <release-repro@example.com>	2026-06-13 08:44:38 -04:00