scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-07 03:00:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(sandbox): hide Daytona terminal control frames

Browse source
This commit is contained in:
Bryan Helmkamp 2026-05-09 16:18:58 -04:00
parent 66b11480d6
commit fe77c2a688
No known key found for this signature in database
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
lib/crates/fabro-sandbox/src/terminal.rs
View file

@ -294,6 +294,9 @@ mod daytona_terminal {
match message {
Ok(ProviderMessage::Binary(bytes)) => return Ok(Some(bytes.to_vec())),
Ok(ProviderMessage::Text(text)) => {
if is_daytona_terminal_control_text(text.as_str()) {
continue;
}
return Ok(Some(text.as_str().as_bytes().to_vec()));
}
Ok(ProviderMessage::Close(_))
@ -505,6 +508,17 @@ mod daytona_terminal {
format!("fabro-terminal-{:016x}", rand::rng().random::<u64>())
}
fn is_daytona_terminal_control_text(text: &str) -> bool {
let Ok(value) = serde_json::from_str::<serde_json::Value>(text) else {
return false;
};
value
.as_object()
.and_then(|object| object.get("type"))
.and_then(serde_json::Value::as_str)
== Some("control")
}
fn daytona_ws_request(
ws_url: &str,
api_key: &str,
@ -640,6 +654,21 @@ mod daytona_terminal {
);
proxy.assert_async().await;
}
#[test]
fn identifies_daytona_terminal_control_text() {
assert!(is_daytona_terminal_control_text(
r#"{"status":"connected","type":"control"}"#
));
assert!(is_daytona_terminal_control_text(
r#"{"type":"control","status":"resized"}"#
));
assert!(!is_daytona_terminal_control_text("hello\n"));
assert!(!is_daytona_terminal_control_text(
r#"{"type":"output","text":"hello"}"#
));
assert!(!is_daytona_terminal_control_text("{"));
}
}
}