scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-11-15 09:11:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix PID readiness race in remote workflow tests

Browse source
This commit is contained in:
Scott Werner 2026-11-02 13:28:54 -05:00
parent e30c9e549d
commit fe13561ca5
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/apps/fabro-cli/src/commands/run/remote_workflow.rs
View file

@ -752,7 +752,10 @@ mod tests {
#[tokio::test]
async fn remote_workflow_dropped_waiter_cancels_child_before_checkout_cleanup() {
let (fake, git) = fake_git("printf '%s' $$ > pid; exec /bin/sleep 60");
// Publish the PID only after writing it: file existence is the readiness
// signal.
let (fake, git) =
fake_git("printf '%s' $$ > pid.tmp; /bin/mv pid.tmp pid; exec /bin/sleep 60");
let checkout = tempfile::tempdir().unwrap();
let path = checkout.path().to_path_buf();
let worker = tokio::spawn(async move {
@ -1154,7 +1157,8 @@ mod tests {
#[tokio::test]
async fn remote_workflow_timeout_and_cancel_reap_owned_children() {
for timeout in [true, false] {
let (root, mut git) = fake_git("printf '%s' $$ > pid; exec /bin/sleep 60");
let (root, mut git) =
fake_git("printf '%s' $$ > pid.tmp; /bin/mv pid.tmp pid; exec /bin/sleep 60");
git.timeout = Duration::from_secs(2);
let cancel = CancellationToken::new();
let trigger = async {