From fab547706148f1743726a8186ee20d33bb1dabe2 Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Fri, 24 Apr 2026 10:38:06 -0400 Subject: [PATCH] refactor(workflow): drop Finalized.pushed_branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Dead state — constructed in pull_request.rs from run_options.run_branch() but no consumer ever reads it. Concluded's pushed_branch was dropped in the prior simplify pass; Finalized was the sibling still carrying it. Co-Authored-By: Claude Opus 4.7 (1M context) --- lib/crates/fabro-workflow/src/pipeline/pull_request.rs | 1 - lib/crates/fabro-workflow/src/pipeline/types.rs | 9 ++++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/crates/fabro-workflow/src/pipeline/pull_request.rs b/lib/crates/fabro-workflow/src/pipeline/pull_request.rs index 29923abfc..6894fa0f8 100644 --- a/lib/crates/fabro-workflow/src/pipeline/pull_request.rs +++ b/lib/crates/fabro-workflow/src/pipeline/pull_request.rs @@ -580,7 +580,6 @@ pub async fn pull_request(concluded: Concluded, options: &PullRequestOptions) -> run_id: run_options.run_id, outcome, conclusion, - pushed_branch: run_options.run_branch().map(str::to_string), pr_url, } } diff --git a/lib/crates/fabro-workflow/src/pipeline/types.rs b/lib/crates/fabro-workflow/src/pipeline/types.rs index defa987f9..cea052297 100644 --- a/lib/crates/fabro-workflow/src/pipeline/types.rs +++ b/lib/crates/fabro-workflow/src/pipeline/types.rs @@ -307,11 +307,10 @@ pub struct Concluded { /// Output of the PULL_REQUEST phase. #[non_exhaustive] pub struct Finalized { - pub run_id: RunId, - pub outcome: Result, - pub conclusion: Conclusion, - pub pushed_branch: Option, - pub pr_url: Option, + pub run_id: RunId, + pub outcome: Result, + pub conclusion: Conclusion, + pub pr_url: Option, } /// Options for the TRANSFORM phase.