scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-08 22:21:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove OpenAI-specific params from OAuth authorize URL

Browse source 
Strip non-standard query parameters (id_token_add_organizations,
codex_cli_simplified_flow, originator) from the OAuth authorize URL
to keep it compliant with standard OAuth 2.0 PKCE flow.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-30 22:37:24 -04:00
parent 6a3bafccd0
commit fab337fe23
No known key found for this signature in database
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
lib/crates/fabro-openai-oauth/src/lib.rs
View file

@ -90,9 +90,6 @@ pub fn build_authorize_url(
("code_challenge", &pkce.challenge),
("code_challenge_method", "S256"),
("state", state),
("id_token_add_organizations", "true"),
("codex_cli_simplified_flow", "true"),
("originator", "fabro"),
]);
format!("{issuer}/oauth/authorize?{params}")
}
@ -633,7 +630,7 @@ mod tests {
}
#[test]
fn authorize_url_has_openai_params() {
fn authorize_url_has_no_extra_params() {
let pkce = generate_pkce();
let state = generate_state();
let url = build_authorize_url(
@ -643,15 +640,19 @@ mod tests {
&pkce,
&state,
);
// Should only contain standard OAuth 2.0 PKCE params
assert!(
url.contains("id_token_add_organizations=true"),
"missing id_token_add_organizations"
!url.contains("id_token_add_organizations"),
"should not contain OpenAI-specific params"
);
assert!(
url.contains("codex_cli_simplified_flow=true"),
"missing codex_cli_simplified_flow"
!url.contains("codex_cli_simplified_flow"),
"should not contain OpenAI-specific params"
);
assert!(
!url.contains("originator"),
"should not contain OpenAI-specific params"
);
assert!(url.contains("originator=fabro"), "missing originator");
}
#[test]