scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-08-28 05:27:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Prove workflow-version ID JSON parity with the OpenAPI schema

Browse source 
The round-trip fixtures only used empty workflow_dependencies, so no
WorkflowVersionId value ever appeared on the wire in a fabro-api
assertion and CreateWorkflowVersionResponse had no coverage at all.
Put a real 64-hex id in the fixture, round-trip the response type, and
pin serialization to the schema's ^[0-9a-f]{64}$ pattern including
lowercase normalization of case-insensitive input.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Scott Werner 2026-08-13 10:44:58 -04:00
parent 3be98210d9
commit fa05b3df5e
1 changed files with 30 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
lib/foundation/fabro-api/tests/workflow_version_round_trip.rs
View file

@ -1,12 +1,14 @@
use std::any::{TypeId, type_name};
use fabro_api::types::{
WorkflowPath as ApiWorkflowPath, WorkflowVersion as ApiWorkflowVersion,
WorkflowVersionId as ApiWorkflowVersionId,
CreateWorkflowVersionResponse, WorkflowPath as ApiWorkflowPath,
WorkflowVersion as ApiWorkflowVersion, WorkflowVersionId as ApiWorkflowVersionId,
};
use fabro_types::{WorkflowPath, WorkflowVersion, WorkflowVersionId};
use serde_json::json;
const DEPENDENCY_ID: &str = "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef";
#[test]
fn workflow_version_schemas_reuse_domain_types() {
assert_same_type::<ApiWorkflowPath, WorkflowPath>();
@ -22,13 +24,38 @@ fn workflow_version_round_trips_exact_wire_shape() {
"prompts/goal.md": "Ship it",
"workflow.fabro": "digraph W { start [shape=Mdiamond] exit [shape=Msquare] start -> exit }"
},
"workflow_dependencies": {}
"workflow_dependencies": { "children/check.fabro": DEPENDENCY_ID }
});
let version: ApiWorkflowVersion = serde_json::from_value(value.clone()).unwrap();
assert_eq!(serde_json::to_value(version).unwrap(), value);
}
#[test]
fn create_workflow_version_response_round_trips_exact_wire_shape() {
let value = json!({ "workflow_version_id": DEPENDENCY_ID });
let response: CreateWorkflowVersionResponse = serde_json::from_value(value.clone()).unwrap();
assert_eq!(serde_json::to_value(&response).unwrap(), value);
}
#[test]
fn workflow_version_id_emits_the_documented_lowercase_pattern() {
// Input is accepted case-insensitively, but serialization must match the
// OpenAPI schema pattern `^[0-9a-f]{64}$`.
let id = serde_json::from_value::<ApiWorkflowVersionId>(json!(DEPENDENCY_ID.to_uppercase()))
.unwrap();
let emitted = serde_json::to_value(id).unwrap();
assert_eq!(emitted, json!(DEPENDENCY_ID));
let text = emitted.as_str().unwrap();
assert_eq!(text.len(), 64);
assert!(
text.bytes()
.all(|byte| matches!(byte, b'0'..=b'9' | b'a'..=b'f'))
);
}
#[test]
fn workflow_version_replacement_rejects_unknown_fields() {
let value = json!({