scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-10 03:30:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

checkpoint

Browse source 
⚒️ Generated with [Fabro](https://fabro.sh)
This commit is contained in:
Fabro 2026-03-19 11:22:02 -04:00
parent e6037b8aee
commit f9073f70ed
4 changed files with 38 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
checkpoint.json
View file

@ -1,6 +1,6 @@
{
"timestamp": "2026-03-19T15:21:59.067505Z",
"current_node": "verify",
"timestamp": "2026-03-19T15:22:02.953634Z",
"current_node": "fmt",
"completed_nodes": [
"start",
"toolchain",
@ -10,7 +10,8 @@
"simplify_opus",
"simplify_gemini",
"simplify_gpt",
"verify"
"verify",
"fmt"
],
"node_retries": {
"toolchain": 1,
@ -20,17 +21,19 @@
"simplify_gemini": 1,
"simplify_gpt": 1,
"preflight_lint": 1,
"fmt": 1,
"verify": 1,
"start": 1
},
"context_values": {
"response.simplify_gpt": "## Summary\n\nAll three review agents completed their analysis. Here's what was found and addressed:\n\n### Fixed\n- **Nesting depth in init.rs**: Reduced from 4 levels of nested `if`/`if let` to 2 levels by extracting `cross_owner` and `is_private` boolean variables. The short-circuit `&&` ensures `is_app_public` is only called when `cross_owner` is true, preserving the original behavior.\n\n### Reviewed and confirmed clean (no action needed)\n- **Code reuse**: The repeated header patterns (`Accept`, `User-Agent`) and auth error messages are pre-existing across 10+ call sites in `fabro-github`. The new code follows the established convention. Extracting these into shared helpers would be a larger unrelated refactor.\n- **Efficiency**: The sequential `get_authenticated_app` → `is_app_public` calls are justified by a data dependency (slug). The entire path only runs in the failure case (`Ok(false)`) of a one-time interactive CLI command — no hot-path concern.\n- **No TOCTOU**: The new checks are purely advisory/diagnostic.\n- **No memory issues**: `AppInfo` and `AppOwner` are small fixed-size structs.\n- **No missed concurrency**: `check_app_installed` could theoretically run concurrently with `get_authenticated_app`, but that would waste an API call on the happy path for negligible gain.",
"current.preamble": "Goal: # Detect GitHub App visibility mismatch during `repo init`\n\n## Context\n\nWhen `fabro repo init` detects the GitHub App is not installed for a repo, it shows a generic \"install at\" URL. But if the repo owner differs from the app owner, the app must be **public** to be installable. Users currently get no guidance about this, leading to confusion when the install link doesn't work.\n\n## Changes\n\n### 1. Add `get_authenticated_app()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd two public structs near the existing response types (around line 40):\n\n```rust\npub struct AppOwner {\n pub login: String,\n}\n\npub struct AppInfo {\n pub slug: String,\n pub owner: AppOwner,\n}\n```\n\nAdd function after `check_app_installed` (after line 525):\n\n- `pub async fn get_authenticated_app(client, jwt, base_url) -> Result<AppInfo, String>`\n- Calls `GET {base_url}/app` with Bearer JWT auth\n- Returns `AppInfo` on 200, errors on 401/other\n\n### 2. Add `is_app_public()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd function after `get_authenticated_app`:\n\n- `pub async fn is_app_public(client, slug, base_url) -> Result<bool, String>`\n- Calls `GET {base_url}/apps/{slug}` **without** auth (public apps are visible to unauthenticated requests)\n- Returns `Ok(true)` on 200, `Ok(false)` on 404, error on other status\n\n### 3. Update `check_github_app_installation` in init.rs\n\n**File:** `lib/crates/fabro-cli/src/init.rs`\n\nIn the `Ok(false)` branch (line 250), before showing the install URL:\n\n1. Call `get_authenticated_app()` to get the app's owner\n2. Compare `app_info.owner.login` with the repo `owner` (case-insensitive)\n3. If they differ, call `is_app_public()` to check visibility\n4. If the app is private and owners differ, show a targeted warning:\n\n```\n ! GitHub App \"{slug}\" is private but this repo belongs to a different owner ({repo_owner}).\n The app must be made public before it can be installed outside {app_owner}.\n Update visibility at: https://github.com/settings/apps/{slug}\n```\n\nAll new checks are best-effort — failures are silently ignored (the existing generic warning still shows).\n\n### 4. Tests\n\n**File:** `lib/crates/fabro-github/src/lib.rs` (test module)\n\nAdd tests using existing `mockito` patterns:\n\n- `get_authenticated_app_success` — 200 returns parsed `AppInfo`\n- `get_authenticated_app_auth_failure` — 401 returns error\n- `is_app_public_returns_true_on_200` — public app\n- `is_app_public_returns_false_on_404` — private app\n- `is_app_public_no_auth_header` — verify no Authorization header is sent\n\n## Verification\n\n1. `cargo test -p fabro-github` — new unit tests pass\n2. `cargo build --workspace` — compiles cleanly\n3. `cargo clippy --workspace -- -D warnings` — no warnings\n4. Manual: run `fabro repo init` in a repo owned by a different org than the app to verify the warning appears\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n- **preflight_compile**: success\n - Script: `cargo check -q --workspace 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **preflight_lint**: success\n - Script: `cargo clippy -q --workspace -- -D warnings 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **implement**: success\n - Model: claude-opus-4-6, 38.3k tokens in / 4.9k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs, /home/daytona/workspace/lib/crates/fabro-github/src/lib.rs\n- **simplify_opus**: success\n - Model: claude-opus-4-6, 28.9k tokens in / 13.5k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs\n- **simplify_gemini**: success\n - Model: claude-opus-4-6, 20.6k tokens in / 8.1k out\n- **simplify_gpt**: success\n - Model: claude-opus-4-6, 22.9k tokens in / 10.0k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs\n",
"current.preamble": "Goal: # Detect GitHub App visibility mismatch during `repo init`\n\n## Context\n\nWhen `fabro repo init` detects the GitHub App is not installed for a repo, it shows a generic \"install at\" URL. But if the repo owner differs from the app owner, the app must be **public** to be installable. Users currently get no guidance about this, leading to confusion when the install link doesn't work.\n\n## Changes\n\n### 1. Add `get_authenticated_app()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd two public structs near the existing response types (around line 40):\n\n```rust\npub struct AppOwner {\n pub login: String,\n}\n\npub struct AppInfo {\n pub slug: String,\n pub owner: AppOwner,\n}\n```\n\nAdd function after `check_app_installed` (after line 525):\n\n- `pub async fn get_authenticated_app(client, jwt, base_url) -> Result<AppInfo, String>`\n- Calls `GET {base_url}/app` with Bearer JWT auth\n- Returns `AppInfo` on 200, errors on 401/other\n\n### 2. Add `is_app_public()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd function after `get_authenticated_app`:\n\n- `pub async fn is_app_public(client, slug, base_url) -> Result<bool, String>`\n- Calls `GET {base_url}/apps/{slug}` **without** auth (public apps are visible to unauthenticated requests)\n- Returns `Ok(true)` on 200, `Ok(false)` on 404, error on other status\n\n### 3. Update `check_github_app_installation` in init.rs\n\n**File:** `lib/crates/fabro-cli/src/init.rs`\n\nIn the `Ok(false)` branch (line 250), before showing the install URL:\n\n1. Call `get_authenticated_app()` to get the app's owner\n2. Compare `app_info.owner.login` with the repo `owner` (case-insensitive)\n3. If they differ, call `is_app_public()` to check visibility\n4. If the app is private and owners differ, show a targeted warning:\n\n```\n ! GitHub App \"{slug}\" is private but this repo belongs to a different owner ({repo_owner}).\n The app must be made public before it can be installed outside {app_owner}.\n Update visibility at: https://github.com/settings/apps/{slug}\n```\n\nAll new checks are best-effort — failures are silently ignored (the existing generic warning still shows).\n\n### 4. Tests\n\n**File:** `lib/crates/fabro-github/src/lib.rs` (test module)\n\nAdd tests using existing `mockito` patterns:\n\n- `get_authenticated_app_success` — 200 returns parsed `AppInfo`\n- `get_authenticated_app_auth_failure` — 401 returns error\n- `is_app_public_returns_true_on_200` — public app\n- `is_app_public_returns_false_on_404` — private app\n- `is_app_public_no_auth_header` — verify no Authorization header is sent\n\n## Verification\n\n1. `cargo test -p fabro-github` — new unit tests pass\n2. `cargo build --workspace` — compiles cleanly\n3. `cargo clippy --workspace -- -D warnings` — no warnings\n4. Manual: run `fabro repo init` in a repo owned by a different org than the app to verify the warning appears\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n- **preflight_compile**: success\n - Script: `cargo check -q --workspace 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **preflight_lint**: success\n - Script: `cargo clippy -q --workspace -- -D warnings 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **implement**: success\n - Model: claude-opus-4-6, 38.3k tokens in / 4.9k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs, /home/daytona/workspace/lib/crates/fabro-github/src/lib.rs\n- **simplify_opus**: success\n - Model: claude-opus-4-6, 28.9k tokens in / 13.5k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs\n- **simplify_gemini**: success\n - Model: claude-opus-4-6, 20.6k tokens in / 8.1k out\n- **simplify_gpt**: success\n - Model: claude-opus-4-6, 22.9k tokens in / 10.0k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/init.rs\n- **verify**: success\n - Script: `cargo clippy -q --workspace -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1`\n - Stdout:\n ```\n ────────────\n Nextest run ID 27472097-4669-4dae-bf34-20c14af29641 with nextest profile: default\n Starting 3217 tests across 45 binaries (179 tests skipped)\n ────────────\n Summary [ 16.128s] 3217 tests run: 3217 passed, 179 skipped\n ```\n - Stderr: (empty)\n",
"response.implement": "All 55 tests pass. Here's a summary of all changes made:\n\n### Changes Summary\n\n**1. `lib/crates/fabro-github/src/lib.rs`** — Added two structs and two functions:\n\n- **`AppOwner`** struct — holds the `login` field for the app's owner\n- **`AppInfo`** struct — holds `slug` and `owner` (an `AppOwner`), both derived from `Deserialize`\n- **`get_authenticated_app(client, jwt, base_url)`** — calls `GET {base_url}/app` with Bearer JWT auth, returns `AppInfo` on 200, error on 401/other\n- **`is_app_public(client, slug, base_url)`** — calls `GET {base_url}/apps/{slug}` **without** auth, returns `Ok(true)` on 200, `Ok(false)` on 404, error on other\n\n**5 new tests** added to the test module:\n- `get_authenticated_app_success` — verifies 200 response is parsed into `AppInfo`\n- `get_authenticated_app_auth_failure` — verifies 401 returns authentication error\n- `is_app_public_returns_true_on_200` — public app returns true\n- `is_app_public_returns_false_on_404` — private app returns false\n- `is_app_public_no_auth_header` — verifies no `Authorization` header is sent (using `Matcher::Missing`)\n\n**2. `lib/crates/fabro-cli/src/init.rs`** — Updated `check_github_app_installation`:\n\nIn the `Ok(false)` branch (app not installed), before showing the install URL, added best-effort checks:\n1. Calls `get_authenticated_app()` to get the app's owner\n2. Compares `app_info.owner.login` with the repo `owner` (case-insensitive via `eq_ignore_ascii_case`)\n3. If they differ, calls `is_app_public()` to check visibility\n4. If the app is private and owners differ, shows a targeted warning about making the app public\n\nAll checks are best-effort — failures at any step are silently ignored and the existing generic warning still shows.",
"internal.retry_count.toolchain": 1,
"internal.retry_count.simplify_opus": 1,
"failure_signature": "",
"internal.retry_count.simplify_gemini": 1,
"thread.verify.current_node": "fmt",
"thread.simplify_opus.current_node": "simplify_gemini",
"graph.model_stylesheet": "\n * { backend: api; model: claude-opus-4-6;}\n ",
"failure_class": "",
@ -38,7 +41,7 @@
"internal.fidelity": "compact",
"thread.start.current_node": "toolchain",
"internal.retry_count.preflight_compile": 1,
"command.output": "────────────\n Nextest run ID 27472097-4669-4dae-bf34-20c14af29641 with nextest profile: default\n Starting 3217 tests across 45 binaries (179 tests skipped)\n────────────\n Summary [ 16.128s] 3217 tests run: 3217 passed, 179 skipped\n",
"command.output": "",
"internal.node_visit_count": 1,
"thread.simplify_gpt.current_node": "verify",
"thread.implement.current_node": "simplify_opus",
@ -46,8 +49,8 @@
"internal.retry_count.implement": 1,
"internal.retry_count.preflight_lint": 1,
"response.simplify_gemini": "All three review agents completed. Here's the aggregated summary:\n\n## Review Results\n\n### Agent 1 (Code Reuse): ✅ Clean\n- **One minor finding**: `AppOwner` is structurally identical to `PullRequestUser` (both have `pub login: String`). However, they represent different semantic concepts (GitHub App owner vs. PR author), and the struct is trivial. **Skipping** — keeping distinct types for distinct concepts is reasonable.\n- No other duplication found. The new functions follow established codebase patterns (manual header attachment, status-code matching). The `GITHUB_API_BASE_URL` constant replacement is a pure improvement.\n\n### Agent 2 (Code Quality): ✅ Clean\n- The new functions (`get_authenticated_app`, `is_app_public`) follow the exact same pattern as existing functions like `check_app_installed` and `branch_exists`\n- The nested `if let Ok(...)` / `if !...` pattern in init.rs is idiomatic for best-effort checks\n- No parameter sprawl, copy-paste issues, leaky abstractions, or stringly-typed code\n\n### Agent 3 (Efficiency): ✅ Clean\n- The two sequential API calls (`get_authenticated_app` → `is_app_public`) can't be parallelized because the second depends on the slug from the first — this is correct\n- These calls only execute in the `Ok(false)` branch (app not installed), which is a one-time interactive CLI init check, not a hot path\n- No unnecessary work, unbounded structures, or TOCTOU issues\n\n**Conclusion: The code is already clean.** No changes needed. All tests pass and clippy reports no warnings.",
"internal.thread_id": "simplify_gpt",
"current_node": "verify",
"internal.thread_id": "verify",
"current_node": "fmt",
"internal.retry_count.start": 1,
"graph.rankdir": "LR",
"internal.run_id": "01KM39Z9DVCBB36GZMYAA6P0FJ",
@ -59,6 +62,7 @@
"graph.goal": "# Detect GitHub App visibility mismatch during `repo init`\n\n## Context\n\nWhen `fabro repo init` detects the GitHub App is not installed for a repo, it shows a generic \"install at\" URL. But if the repo owner differs from the app owner, the app must be **public** to be installable. Users currently get no guidance about this, leading to confusion when the install link doesn't work.\n\n## Changes\n\n### 1. Add `get_authenticated_app()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd two public structs near the existing response types (around line 40):\n\n```rust\npub struct AppOwner {\n pub login: String,\n}\n\npub struct AppInfo {\n pub slug: String,\n pub owner: AppOwner,\n}\n```\n\nAdd function after `check_app_installed` (after line 525):\n\n- `pub async fn get_authenticated_app(client, jwt, base_url) -> Result<AppInfo, String>`\n- Calls `GET {base_url}/app` with Bearer JWT auth\n- Returns `AppInfo` on 200, errors on 401/other\n\n### 2. Add `is_app_public()` to fabro-github\n\n**File:** `lib/crates/fabro-github/src/lib.rs`\n\nAdd function after `get_authenticated_app`:\n\n- `pub async fn is_app_public(client, slug, base_url) -> Result<bool, String>`\n- Calls `GET {base_url}/apps/{slug}` **without** auth (public apps are visible to unauthenticated requests)\n- Returns `Ok(true)` on 200, `Ok(false)` on 404, error on other status\n\n### 3. Update `check_github_app_installation` in init.rs\n\n**File:** `lib/crates/fabro-cli/src/init.rs`\n\nIn the `Ok(false)` branch (line 250), before showing the install URL:\n\n1. Call `get_authenticated_app()` to get the app's owner\n2. Compare `app_info.owner.login` with the repo `owner` (case-insensitive)\n3. If they differ, call `is_app_public()` to check visibility\n4. If the app is private and owners differ, show a targeted warning:\n\n```\n ! GitHub App \"{slug}\" is private but this repo belongs to a different owner ({repo_owner}).\n The app must be made public before it can be installed outside {app_owner}.\n Update visibility at: https://github.com/settings/apps/{slug}\n```\n\nAll new checks are best-effort — failures are silently ignored (the existing generic warning still shows).\n\n### 4. Tests\n\n**File:** `lib/crates/fabro-github/src/lib.rs` (test module)\n\nAdd tests using existing `mockito` patterns:\n\n- `get_authenticated_app_success` — 200 returns parsed `AppInfo`\n- `get_authenticated_app_auth_failure` — 401 returns error\n- `is_app_public_returns_true_on_200` — public app\n- `is_app_public_returns_false_on_404` — private app\n- `is_app_public_no_auth_header` — verify no Authorization header is sent\n\n## Verification\n\n1. `cargo test -p fabro-github` — new unit tests pass\n2. `cargo build --workspace` — compiles cleanly\n3. `cargo clippy --workspace -- -D warnings` — no warnings\n4. Manual: run `fabro repo init` in a repo owned by a different org than the app to verify the warning appears\n",
"command.stderr": "",
"thread.simplify_gemini.current_node": "simplify_gpt",
"internal.retry_count.fmt": 1,
"thread.toolchain.current_node": "preflight_compile",
"internal.retry_count.verify": 1
},
@ -189,10 +193,20 @@
},
"notes": "Script completed: cargo clippy -q --workspace -- -D warnings 2>&1 && cargo nextest run --cargo-quiet --workspace --status-level fail 2>&1",
"duration_ms": 85852
},
"fmt": {
"status": "success",
"context_updates": {
"command.stderr": "",
"command.output": ""
},
"notes": "Script completed: cargo fmt --all 2>&1",
"duration_ms": 1094
}
},
"next_node_id": "fmt",
"next_node_id": "exit",
"node_visits": {
"fmt": 1,
"simplify_gpt": 1,
"simplify_opus": 1,
"start": 1,

5
nodes/fmt/script_invocation.json Normal file
View file

@ -0,0 +1,5 @@
{
"command": "cargo fmt --all 2>&1",
"language": "shell",
"timeout_ms": null
}

5
nodes/fmt/script_timing.json Normal file
View file

@ -0,0 +1,5 @@
{
"duration_ms": 1093,
"exit_code": 0,
"timed_out": false
}

6
nodes/fmt/status.json Normal file
View file

@ -0,0 +1,6 @@
{
"status": "success",
"notes": "Script completed: cargo fmt --all 2>&1",
"failure_reason": null,
"timestamp": "2026-03-19T15:22:02.953120+00:00"
}