scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-07 08:27:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(cli): print full run id on rm (#315)

Browse source 
When `fabro rm` succeeds, the confirmation output should identify
exactly which run was removed. Today the human-readable path prints a
shortened run ID, which is less precise than the JSON output and less
useful for copy/paste confirmation.

## Summary
- print the full run ID after successful `fabro rm` removal
- keep `--json` behavior unchanged
- update CLI snapshots to expect full IDs on success paths

## Testing
- cargo test -p fabro-cli rm_ -- --nocapture
- cargo +nightly-2026-04-14 fmt --check --all
This commit is contained in:
David Bock 2026-05-20 08:24:31 -04:00 • committed by GitHub
parent ba6f92d770
commit ef70dbc5be
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/crates/fabro-cli/src/commands/runs/rm.rs
View file

@ -1,6 +1,5 @@
use anyhow::{Result, bail};
use super::short_run_id;
use crate::args::RunsRemoveArgs;
use crate::command_context::CommandContext;
use crate::server_client;
@ -57,7 +56,7 @@ async fn remove_from(args: &RunsRemoveArgs, ctx: &CommandContext) -> Result<()>
let run_id_string = run_id.to_string();
removed.push(run_id_string.clone());
if !json {
fabro_util::printerr!(printer, "{}", short_run_id(&run_id_string));
fabro_util::printerr!(printer, "{run_id_string}");
}
}

10
lib/crates/fabro-cli/tests/it/cmd/rm.rs
View file

@ -43,7 +43,7 @@ fn rm_deletes_completed_run() {
let run = setup_seeded_completed_dry_run(&context);
let mut filters = context.filters();
filters.push((
r"\b[0-9A-HJKMNP-TV-Z]{12}\b".to_string(),
r"\b[0-9A-HJKMNP-TV-Z]{26}\b".to_string(),
"[ULID]".to_string(),
));
@ -96,7 +96,7 @@ fn rm_force_deletes_submitted_run() {
let run = setup_seeded_created_dry_run(&context);
let mut filters = context.filters();
filters.push((
r"\b[0-9A-HJKMNP-TV-Z]{12}\b".to_string(),
r"\b[0-9A-HJKMNP-TV-Z]{26}\b".to_string(),
"[ULID]".to_string(),
));
@ -129,7 +129,7 @@ fn rm_force_deletes_run_without_sandbox_json_when_store_has_sandbox() {
let mut filters = context.filters();
filters.push((
r"\b[0-9A-HJKMNP-TV-Z]{12}\b".to_string(),
r"\b[0-9A-HJKMNP-TV-Z]{26}\b".to_string(),
"[ULID]".to_string(),
));
@ -163,7 +163,7 @@ fn rm_force_removes_active_run() {
let mut filters = context.filters();
filters.push((
r"\b[0-9A-HJKMNP-TV-Z]{12}\b".to_string(),
r"\b[0-9A-HJKMNP-TV-Z]{26}\b".to_string(),
"[ULID]".to_string(),
));
let mut cmd = context.command();
@ -248,7 +248,7 @@ fn rm_partial_failure_reports_which_identifiers_failed() {
let run = setup_seeded_completed_dry_run(&context);
let mut filters = context.filters();
filters.push((
r"\b[0-9A-HJKMNP-TV-Z]{12}\b".to_string(),
r"\b[0-9A-HJKMNP-TV-Z]{26}\b".to_string(),
"[ULID]".to_string(),
));
let mut cmd = context.command();