mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-10 03:30:59 +00:00
parent
00d6939b84
commit
eedcbb5c84
4 changed files with 39 additions and 9 deletions
|
|
@ -1,17 +1,20 @@
|
|||
{
|
||||
"timestamp": "2026-03-16T03:47:28.663073Z",
|
||||
"current_node": "toolchain",
|
||||
"timestamp": "2026-03-16T03:48:39.331812Z",
|
||||
"current_node": "preflight_compile",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"toolchain"
|
||||
"toolchain",
|
||||
"preflight_compile"
|
||||
],
|
||||
"node_retries": {
|
||||
"start": 1,
|
||||
"toolchain": 1
|
||||
"toolchain": 1,
|
||||
"preflight_compile": 1
|
||||
},
|
||||
"context_values": {
|
||||
"internal.fidelity": "compact",
|
||||
"failure_signature": "",
|
||||
"internal.retry_count.preflight_compile": 1,
|
||||
"failure_class": "",
|
||||
"graph.rankdir": "LR",
|
||||
"command.stderr": "",
|
||||
|
|
@ -19,14 +22,15 @@
|
|||
"internal.retry_count.toolchain": 1,
|
||||
"thread.start.current_node": "toolchain",
|
||||
"graph.goal": "# Refactor: Collapse `pull_request_*` fields on `RunConfig` into `Option<PullRequestConfig>`\n\n## Context\n\n`RunConfig` has 4 flat `pull_request_*` fields that encode a natural tree structure. This refactor collapses them into a single `Option<PullRequestConfig>` field, reusing the existing TOML config struct directly.\n\n## Approach\n\nReplace on `RunConfig`:\n```rust\npub pull_request_enabled: bool,\npub pull_request_draft: bool,\npub pull_request_auto_merge: bool,\npub pull_request_merge_strategy: MergeStrategy,\n```\n\nWith:\n```rust\npub pull_request: Option<PullRequestConfig>,\n```\n\n- `None` = disabled (replaces `enabled: false`)\n- `Some(config)` = enabled, read `.draft`, `.auto_merge`, `.merge_strategy` directly\n- The `enabled` field on `PullRequestConfig` is still needed for TOML deserialization but is redundant at runtime\n\nDelete `AutoMergeConfig` from `pull_request.rs` — pass `Option<MergeStrategy>` directly instead (derived from `auto_merge` + `merge_strategy` on `PullRequestConfig`).\n\n## Files to modify\n\n1. **`engine.rs`** — replace 4 fields with `pull_request: Option<PullRequestConfig>`, update all test constructors (4 lines → 1: `pull_request: None`)\n2. **`run.rs`** — simplify construction: `pull_request: pr_cfg.filter(|p| p.enabled).cloned()` with draft override for auto_merge. Simplify read site: `if let Some(ref pr) = config.pull_request { ... }`\n3. **`pull_request.rs`** — change `maybe_open_pull_request` to take `&PullRequestConfig` instead of `draft: bool` + `auto_merge: Option<AutoMergeConfig>`. Delete `AutoMergeConfig`\n4. **`pr.rs`** — update call to `maybe_open_pull_request`\n5. **`server.rs`, `manager_loop.rs`** — `pull_request: None`\n6. **`tests/integration.rs`, `tests/daytona_integration.rs`** — `pull_request: None`\n\n## Verification\n\n- `cargo build --workspace`\n- `cargo clippy --workspace -- -D warnings`\n- `cargo test -p fabro-workflows -- pull_request run_config project_config`\n- `cargo fmt --check --all`\n",
|
||||
"current.preamble": "Goal: # Refactor: Collapse `pull_request_*` fields on `RunConfig` into `Option<PullRequestConfig>`\n\n## Context\n\n`RunConfig` has 4 flat `pull_request_*` fields that encode a natural tree structure. This refactor collapses them into a single `Option<PullRequestConfig>` field, reusing the existing TOML config struct directly.\n\n## Approach\n\nReplace on `RunConfig`:\n```rust\npub pull_request_enabled: bool,\npub pull_request_draft: bool,\npub pull_request_auto_merge: bool,\npub pull_request_merge_strategy: MergeStrategy,\n```\n\nWith:\n```rust\npub pull_request: Option<PullRequestConfig>,\n```\n\n- `None` = disabled (replaces `enabled: false`)\n- `Some(config)` = enabled, read `.draft`, `.auto_merge`, `.merge_strategy` directly\n- The `enabled` field on `PullRequestConfig` is still needed for TOML deserialization but is redundant at runtime\n\nDelete `AutoMergeConfig` from `pull_request.rs` — pass `Option<MergeStrategy>` directly instead (derived from `auto_merge` + `merge_strategy` on `PullRequestConfig`).\n\n## Files to modify\n\n1. **`engine.rs`** — replace 4 fields with `pull_request: Option<PullRequestConfig>`, update all test constructors (4 lines → 1: `pull_request: None`)\n2. **`run.rs`** — simplify construction: `pull_request: pr_cfg.filter(|p| p.enabled).cloned()` with draft override for auto_merge. Simplify read site: `if let Some(ref pr) = config.pull_request { ... }`\n3. **`pull_request.rs`** — change `maybe_open_pull_request` to take `&PullRequestConfig` instead of `draft: bool` + `auto_merge: Option<AutoMergeConfig>`. Delete `AutoMergeConfig`\n4. **`pr.rs`** — update call to `maybe_open_pull_request`\n5. **`server.rs`, `manager_loop.rs`** — `pull_request: None`\n6. **`tests/integration.rs`, `tests/daytona_integration.rs`** — `pull_request: None`\n\n## Verification\n\n- `cargo build --workspace`\n- `cargo clippy --workspace -- -D warnings`\n- `cargo test -p fabro-workflows -- pull_request run_config project_config`\n- `cargo fmt --check --all`\n\n",
|
||||
"current.preamble": "Goal: # Refactor: Collapse `pull_request_*` fields on `RunConfig` into `Option<PullRequestConfig>`\n\n## Context\n\n`RunConfig` has 4 flat `pull_request_*` fields that encode a natural tree structure. This refactor collapses them into a single `Option<PullRequestConfig>` field, reusing the existing TOML config struct directly.\n\n## Approach\n\nReplace on `RunConfig`:\n```rust\npub pull_request_enabled: bool,\npub pull_request_draft: bool,\npub pull_request_auto_merge: bool,\npub pull_request_merge_strategy: MergeStrategy,\n```\n\nWith:\n```rust\npub pull_request: Option<PullRequestConfig>,\n```\n\n- `None` = disabled (replaces `enabled: false`)\n- `Some(config)` = enabled, read `.draft`, `.auto_merge`, `.merge_strategy` directly\n- The `enabled` field on `PullRequestConfig` is still needed for TOML deserialization but is redundant at runtime\n\nDelete `AutoMergeConfig` from `pull_request.rs` — pass `Option<MergeStrategy>` directly instead (derived from `auto_merge` + `merge_strategy` on `PullRequestConfig`).\n\n## Files to modify\n\n1. **`engine.rs`** — replace 4 fields with `pull_request: Option<PullRequestConfig>`, update all test constructors (4 lines → 1: `pull_request: None`)\n2. **`run.rs`** — simplify construction: `pull_request: pr_cfg.filter(|p| p.enabled).cloned()` with draft override for auto_merge. Simplify read site: `if let Some(ref pr) = config.pull_request { ... }`\n3. **`pull_request.rs`** — change `maybe_open_pull_request` to take `&PullRequestConfig` instead of `draft: bool` + `auto_merge: Option<AutoMergeConfig>`. Delete `AutoMergeConfig`\n4. **`pr.rs`** — update call to `maybe_open_pull_request`\n5. **`server.rs`, `manager_loop.rs`** — `pull_request: None`\n6. **`tests/integration.rs`, `tests/daytona_integration.rs`** — `pull_request: None`\n\n## Verification\n\n- `cargo build --workspace`\n- `cargo clippy --workspace -- -D warnings`\n- `cargo test -p fabro-workflows -- pull_request run_config project_config`\n- `cargo fmt --check --all`\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n",
|
||||
"internal.run_id": "01KKTC2TWVRW6ZCYYZYGRX0GD6",
|
||||
"graph.model_stylesheet": "\n * { backend: api; model: claude-opus-4-6;}\n ",
|
||||
"internal.node_visit_count": 1,
|
||||
"internal.thread_id": "start",
|
||||
"internal.thread_id": "toolchain",
|
||||
"internal.retry_count.start": 1,
|
||||
"command.output": "cargo 1.94.0 (85eff7c80 2026-01-15)\n",
|
||||
"current_node": "toolchain"
|
||||
"command.output": "",
|
||||
"thread.toolchain.current_node": "preflight_compile",
|
||||
"current_node": "preflight_compile"
|
||||
},
|
||||
"logs": [],
|
||||
"node_outcomes": {
|
||||
|
|
@ -42,10 +46,20 @@
|
|||
"start": {
|
||||
"status": "success",
|
||||
"duration_ms": 0
|
||||
},
|
||||
"preflight_compile": {
|
||||
"status": "success",
|
||||
"context_updates": {
|
||||
"command.stderr": "",
|
||||
"command.output": ""
|
||||
},
|
||||
"notes": "Script completed: cargo check -q --workspace 2>&1",
|
||||
"duration_ms": 68455
|
||||
}
|
||||
},
|
||||
"next_node_id": "preflight_compile",
|
||||
"next_node_id": "preflight_lint",
|
||||
"node_visits": {
|
||||
"preflight_compile": 1,
|
||||
"start": 1,
|
||||
"toolchain": 1
|
||||
}
|
||||
|
|
|
|||
5
nodes/preflight_compile/script_invocation.json
Normal file
5
nodes/preflight_compile/script_invocation.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"command": "cargo check -q --workspace 2>&1",
|
||||
"language": "shell",
|
||||
"timeout_ms": null
|
||||
}
|
||||
5
nodes/preflight_compile/script_timing.json
Normal file
5
nodes/preflight_compile/script_timing.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"duration_ms": 68454,
|
||||
"exit_code": 0,
|
||||
"timed_out": false
|
||||
}
|
||||
6
nodes/preflight_compile/status.json
Normal file
6
nodes/preflight_compile/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"status": "success",
|
||||
"notes": "Script completed: cargo check -q --workspace 2>&1",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-03-16T03:48:39.331571+00:00"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue