scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-15 23:32:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Load pull request diffs from the run store

Browse source
This commit is contained in:
Bryan Helmkamp 2026-04-01 21:45:40 -07:00
parent 81d838f600
commit ebe7db8e62
No known key found for this signature in database
1 changed files with 41 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
lib/crates/fabro-workflow/src/pipeline/pull_request.rs
View file

@ -296,6 +296,23 @@ fn emit_run_notice(
});
}
async fn load_pull_request_diff(run_store: Option<&dyn RunStore>, run_dir: &Path) -> String {
match run_store {
Some(run_store) => run_store
.get_final_patch()
.await
.inspect_err(|err| {
tracing::warn!(error = %err, "Failed to load final patch from store for PR");
})
.ok()
.flatten()
.unwrap_or_default(),
None => read_to_string(run_dir.join("final.patch"))
.await
.unwrap_or_default(),
}
}
/// Build a complete PR body by combining LLM-generated narrative with
/// programmatic sections (plan, retro, fabro details).
pub async fn build_pr_body(
@ -541,9 +558,8 @@ pub async fn pull_request(concluded: Concluded, options: &PullRequestOptions) ->
result.status,
StageStatus::Success | StageStatus::PartialSuccess
) {
let diff = read_to_string(options.run_dir.join("final.patch"))
.await
.unwrap_or_default();
let diff =
load_pull_request_diff(options.run_store.as_deref(), &options.run_dir).await;
if let (Some(base_branch), Some(run_branch), Some(creds), Some(origin)) = (
&run_options.base_branch,
pushed_branch.as_deref(),
@ -1323,4 +1339,26 @@ mod tests {
assert!(result.is_ok());
assert!(result.unwrap().is_none());
}
#[tokio::test]
async fn load_pull_request_diff_uses_store_without_disk_patch() {
let tmp = tempfile::tempdir().unwrap();
let store = InMemoryStore::default();
let run_store = store
.create_run(
&fixtures::RUN_1,
Utc::now(),
Some(&tmp.path().display().to_string()),
)
.await
.unwrap();
run_store
.put_final_patch("diff --git a/src/lib.rs b/src/lib.rs\n+fn from_store() {}\n")
.await
.unwrap();
let diff = load_pull_request_diff(Some(run_store.as_ref()), tmp.path()).await;
assert!(diff.contains("from_store"));
}
}