scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-08-28 05:27:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix race condition between fabro run --detach and fabro logs -f

Browse source 
Write id.txt and touch empty progress.jsonl in detach_run() before
spawning the child process so that `fabro logs -f ULID` can resolve
the run and tail the file immediately.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-15 13:37:48 -04:00
parent 0bd012acb6
commit ea6aa93c22
No known key found for this signature in database
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/crates/fabro-cli/src/main.rs
View file

@ -218,6 +218,8 @@ fn detach_run(args: fabro_workflows::cli::RunArgs) -> Result<()> {
))
});
std::fs::create_dir_all(&run_dir)?;
std::fs::write(run_dir.join("id.txt"), &run_id)?;
std::fs::File::create(run_dir.join("progress.jsonl"))?;
let log_file = std::fs::File::create(run_dir.join("detach.log"))?;

6
lib/crates/fabro-workflows/src/cli/runs.rs
View file

@ -161,8 +161,12 @@ pub fn scan_runs(base: &Path) -> Result<Vec<RunInfo>> {
.map(|t| -> DateTime<Utc> { t.into() });
let mtime = mtime_dt.map(|dt| dt.to_rfc3339()).unwrap_or_default();
let run_id = std::fs::read_to_string(path.join("id.txt"))
.map(|s| s.trim().to_string())
.unwrap_or_else(|_| dir_name.clone());
runs.push(RunInfo {
run_id: dir_name.clone(),
run_id,
dir_name,
workflow_name: "[no manifest]".to_string(),
workflow_slug: None,