scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-05 08:10:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Simplify retro filtering: typed smoothness, remove double serialization

Browse source 
- Use SmoothnessRating enum instead of String for smoothness filter param
- Remove duplicate default_page_limit(), reuse pub fn from server module
- Replace Json(json!(detail)) with Json(detail) to avoid double serialization

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-06 16:07:51 -05:00
parent 36ab4c6992
commit e4f953acfc
2 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/arc-api/src/demo/mod.rs
View file

@ -13,18 +13,14 @@ use crate::error::ApiError;
use crate::jwt_auth::AuthenticatedService;
use crate::server::{AppState, PaginationParams};
fn default_page_limit() -> u32 {
20
}
#[derive(serde::Deserialize)]
pub struct RetroListParams {
#[serde(rename = "page[limit]", default = "default_page_limit")]
#[serde(rename = "page[limit]", default = "crate::server::default_page_limit")]
limit: u32,
#[serde(rename = "page[offset]", default)]
offset: u32,
workflow: Option<String>,
smoothness: Option<String>,
smoothness: Option<arc_types::SmoothnessRating>,
}
fn paginated_response<T: serde::Serialize>(items: Vec<T>, pagination: &PaginationParams) -> Response {
@ -248,7 +244,7 @@ pub async fn get_run_retro(
Path(id): Path<String>,
) -> Response {
match retros::detail(&id) {
Some(detail) => (StatusCode::OK, Json(json!(detail))).into_response(),
Some(detail) => (StatusCode::OK, Json(detail)).into_response(),
None => (StatusCode::OK, Json(json!(null))).into_response(),
}
}
@ -330,11 +326,7 @@ pub async fn list_retros(
let items: Vec<_> = retros::list_items()
.into_iter()
.filter(|r| params.workflow.as_ref().map_or(true, |w| &r.workflow.slug == w))
.filter(|r| {
params.smoothness.as_ref().map_or(true, |s| {
r.smoothness.as_ref().map_or(false, |rs| rs.to_string() == *s)
})
})
.filter(|r| params.smoothness.as_ref().map_or(true, |s| r.smoothness.as_ref() == Some(s)))
.collect();
paginated_response(items, &PaginationParams { limit: params.limit, offset: params.offset })
}

2
crates/arc-api/src/server.rs
View file

@ -33,7 +33,7 @@ pub use arc_types::{
SubmitAnswerRequest,
};
fn default_page_limit() -> u32 {
pub fn default_page_limit() -> u32 {
20
}