mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-07 03:00:29 +00:00
parent
aadca71d08
commit
dd8c0028c7
5 changed files with 124 additions and 11 deletions
|
|
@ -1,31 +1,38 @@
|
|||
{
|
||||
"timestamp": "2026-03-16T12:04:54.428267Z",
|
||||
"current_node": "setup",
|
||||
"timestamp": "2026-03-16T12:08:13.541058Z",
|
||||
"current_node": "solve",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"setup"
|
||||
"setup",
|
||||
"solve"
|
||||
],
|
||||
"node_retries": {
|
||||
"solve": 1,
|
||||
"setup": 1,
|
||||
"start": 1
|
||||
},
|
||||
"context_values": {
|
||||
"current_node": "setup",
|
||||
"current_node": "solve",
|
||||
"internal.retry_count.setup": 1,
|
||||
"failure_class": "deterministic",
|
||||
"failure_class": "",
|
||||
"internal.node_visit_count": 1,
|
||||
"outcome": "fail",
|
||||
"internal.thread_id": "start",
|
||||
"outcome": "success",
|
||||
"internal.thread_id": "setup",
|
||||
"thread.setup.current_node": "solve",
|
||||
"command.stderr": "",
|
||||
"graph.goal": "Issue when passing empty lists/arrays to WCS transformations\nThe following should not fail but instead should return empty lists/arrays:\r\n\r\n```\r\nIn [1]: from astropy.wcs import WCS\r\n\r\nIn [2]: wcs = WCS('2MASS_h.fits')\r\n\r\nIn [3]: wcs.wcs_pix2world([], [], 0)\r\n---------------------------------------------------------------------------\r\nInconsistentAxisTypesError Traceback (most recent call last)\r\n<ipython-input-3-e2cc0e97941a> in <module>()\r\n----> 1 wcs.wcs_pix2world([], [], 0)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in wcs_pix2world(self, *args, **kwargs)\r\n 1352 return self._array_converter(\r\n 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n-> 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n 1356 Transforms pixel coordinates to world coordinates by doing\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _array_converter(self, func, sky, ra_dec_order, *args)\r\n 1267 \"a 1-D array for each axis, followed by an origin.\")\r\n 1268 \r\n-> 1269 return _return_list_of_arrays(axes, origin)\r\n 1270 \r\n 1271 raise TypeError(\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _return_list_of_arrays(axes, origin)\r\n 1223 if ra_dec_order and sky == 'input':\r\n 1224 xy = self._denormalize_sky(xy)\r\n-> 1225 output = func(xy, origin)\r\n 1226 if ra_dec_order and sky == 'output':\r\n 1227 output = self._normalize_sky(output)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in <lambda>(xy, o)\r\n 1351 raise ValueError(\"No basic WCS settings were created.\")\r\n 1352 return self._array_converter(\r\n-> 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n\r\nInconsistentAxisTypesError: ERROR 4 in wcsp2s() at line 2646 of file cextern/wcslib/C/wcs.c:\r\nncoord and/or nelem inconsistent with the wcsprm.\r\n```\n",
|
||||
"current.preamble": "Goal: Issue when passing empty lists/arrays to WCS transformations\nThe following should not fail but instead should return empty lists/arrays:\r\n\r\n```\r\nIn [1]: from astropy.wcs import WCS\r\n\r\nIn [2]: wcs = WCS('2MASS_h.fits')\r\n\r\nIn [3]: wcs.wcs_pix2world([], [], 0)\r\n---------------------------------------------------------------------------\r\nInconsistentAxisTypesError Traceback (most recent call last)\r\n<ipython-input-3-e2cc0e97941a> in <module>()\r\n----> 1 wcs.wcs_pix2world([], [], 0)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in wcs_pix2world(self, *args, **kwargs)\r\n 1352 return self._array_converter(\r\n 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n-> 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n 1356 Transforms pixel coordinates to world coordinates by doing\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _array_converter(self, func, sky, ra_dec_order, *args)\r\n 1267 \"a 1-D array for each axis, followed by an origin.\")\r\n 1268 \r\n-> 1269 return _return_list_of_arrays(axes, origin)\r\n 1270 \r\n 1271 raise TypeError(\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _return_list_of_arrays(axes, origin)\r\n 1223 if ra_dec_order and sky == 'input':\r\n 1224 xy = self._denormalize_sky(xy)\r\n-> 1225 output = func(xy, origin)\r\n 1226 if ra_dec_order and sky == 'output':\r\n 1227 output = self._normalize_sky(output)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in <lambda>(xy, o)\r\n 1351 raise ValueError(\"No basic WCS settings were created.\")\r\n 1352 return self._array_converter(\r\n-> 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n\r\nInconsistentAxisTypesError: ERROR 4 in wcsp2s() at line 2646 of file cextern/wcslib/C/wcs.c:\r\nncoord and/or nelem inconsistent with the wcsprm.\r\n```\n\n",
|
||||
"current.preamble": "Goal: Issue when passing empty lists/arrays to WCS transformations\nThe following should not fail but instead should return empty lists/arrays:\r\n\r\n```\r\nIn [1]: from astropy.wcs import WCS\r\n\r\nIn [2]: wcs = WCS('2MASS_h.fits')\r\n\r\nIn [3]: wcs.wcs_pix2world([], [], 0)\r\n---------------------------------------------------------------------------\r\nInconsistentAxisTypesError Traceback (most recent call last)\r\n<ipython-input-3-e2cc0e97941a> in <module>()\r\n----> 1 wcs.wcs_pix2world([], [], 0)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in wcs_pix2world(self, *args, **kwargs)\r\n 1352 return self._array_converter(\r\n 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n-> 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n 1356 Transforms pixel coordinates to world coordinates by doing\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _array_converter(self, func, sky, ra_dec_order, *args)\r\n 1267 \"a 1-D array for each axis, followed by an origin.\")\r\n 1268 \r\n-> 1269 return _return_list_of_arrays(axes, origin)\r\n 1270 \r\n 1271 raise TypeError(\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _return_list_of_arrays(axes, origin)\r\n 1223 if ra_dec_order and sky == 'input':\r\n 1224 xy = self._denormalize_sky(xy)\r\n-> 1225 output = func(xy, origin)\r\n 1226 if ra_dec_order and sky == 'output':\r\n 1227 output = self._normalize_sky(output)\r\n\r\n~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in <lambda>(xy, o)\r\n 1351 raise ValueError(\"No basic WCS settings were created.\")\r\n 1352 return self._array_converter(\r\n-> 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],\r\n 1354 'output', *args, **kwargs)\r\n 1355 wcs_pix2world.__doc__ = \"\"\"\r\n\r\nInconsistentAxisTypesError: ERROR 4 in wcsp2s() at line 2646 of file cextern/wcslib/C/wcs.c:\r\nncoord and/or nelem inconsistent with the wcsprm.\r\n```\n\n\n## Completed stages\n- **setup**: fail\n - Script: `git clone https://github.com/astropy/astropy.git . && git checkout d5bd3f68bb6d5ce3a61bdce9883ee750d1afade5 && python -m pip install -e .[test] --verbose`\n - Stdout:\n ```\n fatal: destination path '.' already exists and is not an empty directory.\n ```\n - Stderr: (empty)\n\n## Context\n- failure_class: deterministic\n- failure_signature: setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.\n",
|
||||
"last_stage": "solve",
|
||||
"internal.fidelity": "compact",
|
||||
"internal.retry_count.solve": 1,
|
||||
"internal.run_id": "01KKV8D2SN394TVEZMS300WB4J",
|
||||
"command.output": "fatal: destination path '.' already exists and is not an empty directory.\n",
|
||||
"failure_signature": "setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.",
|
||||
"failure_signature": "",
|
||||
"graph.rankdir": "LR",
|
||||
"internal.retry_count.start": 1,
|
||||
"thread.start.current_node": "setup"
|
||||
"thread.start.current_node": "setup",
|
||||
"response.solve": "Clean diff now. The fix is minimal - two early-return checks:\n\n1. **`_return_list_of_arrays`** (line 1223-1224): After constructing the `xy` array from the list of axes, if it's empty, return a list of empty arrays (one per axis) without calling the C wcslib function.\n\n2. **`_return_single_array`** (line 1241-1242): After validating the shape of the input `xy` array, if it's empty, return it as-is without calling the C wcslib function.\n\nThis prevents the `InconsistentAxisTypesError` from wcslib's C code which doesn't handle zero-length coordinate arrays. The fix correctly handles all three calling conventions:\n- `wcs.wcs_pix2world([], [], 0)` — separate axis arrays\n- `wcs.wcs_pix2world(np.array([]), np.array([]), 0)` — separate numpy arrays \n- `wcs.wcs_pix2world(np.empty((0, 2)), 0)` — single Nx2 array",
|
||||
"last_response": "Clean diff now. The fix is minimal - two early-return checks:\n\n1. **`_return_list_of_arrays`** (line 1223-1224): After constructing the `xy` array from the list of axes, if it's empty, return a list o"
|
||||
},
|
||||
"logs": [],
|
||||
"node_outcomes": {
|
||||
|
|
@ -33,6 +40,28 @@
|
|||
"status": "success",
|
||||
"duration_ms": 0
|
||||
},
|
||||
"solve": {
|
||||
"status": "success",
|
||||
"context_updates": {
|
||||
"last_stage": "solve",
|
||||
"response.solve": "Clean diff now. The fix is minimal - two early-return checks:\n\n1. **`_return_list_of_arrays`** (line 1223-1224): After constructing the `xy` array from the list of axes, if it's empty, return a list of empty arrays (one per axis) without calling the C wcslib function.\n\n2. **`_return_single_array`** (line 1241-1242): After validating the shape of the input `xy` array, if it's empty, return it as-is without calling the C wcslib function.\n\nThis prevents the `InconsistentAxisTypesError` from wcslib's C code which doesn't handle zero-length coordinate arrays. The fix correctly handles all three calling conventions:\n- `wcs.wcs_pix2world([], [], 0)` — separate axis arrays\n- `wcs.wcs_pix2world(np.array([]), np.array([]), 0)` — separate numpy arrays \n- `wcs.wcs_pix2world(np.empty((0, 2)), 0)` — single Nx2 array",
|
||||
"last_response": "Clean diff now. The fix is minimal - two early-return checks:\n\n1. **`_return_list_of_arrays`** (line 1223-1224): After constructing the `xy` array from the list of axes, if it's empty, return a list o"
|
||||
},
|
||||
"notes": "Stage completed: solve",
|
||||
"usage": {
|
||||
"model": "claude-opus-4-6",
|
||||
"input_tokens": 10665,
|
||||
"output_tokens": 4080,
|
||||
"cache_read_tokens": 214806,
|
||||
"cache_write_tokens": 15782,
|
||||
"reasoning_tokens": 509,
|
||||
"cost": 0.46597500000000003
|
||||
},
|
||||
"files_touched": [
|
||||
"/tmp/astropy/astropy/wcs/wcs.py"
|
||||
],
|
||||
"duration_ms": 196926
|
||||
},
|
||||
"setup": {
|
||||
"status": "fail",
|
||||
"context_updates": {
|
||||
|
|
@ -46,12 +75,13 @@
|
|||
"duration_ms": 18
|
||||
}
|
||||
},
|
||||
"next_node_id": "solve",
|
||||
"next_node_id": "extract_patch",
|
||||
"loop_failure_signatures": {
|
||||
"setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.": 1
|
||||
},
|
||||
"node_visits": {
|
||||
"start": 1,
|
||||
"solve": 1,
|
||||
"setup": 1
|
||||
}
|
||||
}
|
||||
62
nodes/solve/prompt.md
Normal file
62
nodes/solve/prompt.md
Normal file
|
|
@ -0,0 +1,62 @@
|
|||
Goal: Issue when passing empty lists/arrays to WCS transformations
|
||||
The following should not fail but instead should return empty lists/arrays:
|
||||
|
||||
```
|
||||
In [1]: from astropy.wcs import WCS
|
||||
|
||||
In [2]: wcs = WCS('2MASS_h.fits')
|
||||
|
||||
In [3]: wcs.wcs_pix2world([], [], 0)
|
||||
---------------------------------------------------------------------------
|
||||
InconsistentAxisTypesError Traceback (most recent call last)
|
||||
<ipython-input-3-e2cc0e97941a> in <module>()
|
||||
----> 1 wcs.wcs_pix2world([], [], 0)
|
||||
|
||||
~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in wcs_pix2world(self, *args, **kwargs)
|
||||
1352 return self._array_converter(
|
||||
1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],
|
||||
-> 1354 'output', *args, **kwargs)
|
||||
1355 wcs_pix2world.__doc__ = """
|
||||
1356 Transforms pixel coordinates to world coordinates by doing
|
||||
|
||||
~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _array_converter(self, func, sky, ra_dec_order, *args)
|
||||
1267 "a 1-D array for each axis, followed by an origin.")
|
||||
1268
|
||||
-> 1269 return _return_list_of_arrays(axes, origin)
|
||||
1270
|
||||
1271 raise TypeError(
|
||||
|
||||
~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in _return_list_of_arrays(axes, origin)
|
||||
1223 if ra_dec_order and sky == 'input':
|
||||
1224 xy = self._denormalize_sky(xy)
|
||||
-> 1225 output = func(xy, origin)
|
||||
1226 if ra_dec_order and sky == 'output':
|
||||
1227 output = self._normalize_sky(output)
|
||||
|
||||
~/Dropbox/Code/Astropy/astropy/astropy/wcs/wcs.py in <lambda>(xy, o)
|
||||
1351 raise ValueError("No basic WCS settings were created.")
|
||||
1352 return self._array_converter(
|
||||
-> 1353 lambda xy, o: self.wcs.p2s(xy, o)['world'],
|
||||
1354 'output', *args, **kwargs)
|
||||
1355 wcs_pix2world.__doc__ = """
|
||||
|
||||
InconsistentAxisTypesError: ERROR 4 in wcsp2s() at line 2646 of file cextern/wcslib/C/wcs.c:
|
||||
ncoord and/or nelem inconsistent with the wcsprm.
|
||||
```
|
||||
|
||||
|
||||
## Completed stages
|
||||
- **setup**: fail
|
||||
- Script: `git clone https://github.com/astropy/astropy.git . && git checkout d5bd3f68bb6d5ce3a61bdce9883ee750d1afade5 && python -m pip install -e .[test] --verbose`
|
||||
- Stdout:
|
||||
```
|
||||
fatal: destination path '.' already exists and is not an empty directory.
|
||||
```
|
||||
- Stderr: (empty)
|
||||
|
||||
## Context
|
||||
- failure_class: deterministic
|
||||
- failure_signature: setup|deterministic|script failed with exit code: <n> ## stdout fatal: destination path '.' already exists and is not an empty directory.
|
||||
|
||||
|
||||
Fix this GitHub issue in the repository. Make the minimal code change needed.
|
||||
5
nodes/solve/provider_used.json
Normal file
5
nodes/solve/provider_used.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"mode": "agent",
|
||||
"provider": "anthropic",
|
||||
"model": "claude-opus-4-6"
|
||||
}
|
||||
10
nodes/solve/response.md
Normal file
10
nodes/solve/response.md
Normal file
|
|
@ -0,0 +1,10 @@
|
|||
Clean diff now. The fix is minimal - two early-return checks:
|
||||
|
||||
1. **`_return_list_of_arrays`** (line 1223-1224): After constructing the `xy` array from the list of axes, if it's empty, return a list of empty arrays (one per axis) without calling the C wcslib function.
|
||||
|
||||
2. **`_return_single_array`** (line 1241-1242): After validating the shape of the input `xy` array, if it's empty, return it as-is without calling the C wcslib function.
|
||||
|
||||
This prevents the `InconsistentAxisTypesError` from wcslib's C code which doesn't handle zero-length coordinate arrays. The fix correctly handles all three calling conventions:
|
||||
- `wcs.wcs_pix2world([], [], 0)` — separate axis arrays
|
||||
- `wcs.wcs_pix2world(np.array([]), np.array([]), 0)` — separate numpy arrays
|
||||
- `wcs.wcs_pix2world(np.empty((0, 2)), 0)` — single Nx2 array
|
||||
6
nodes/solve/status.json
Normal file
6
nodes/solve/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"status": "success",
|
||||
"notes": "Stage completed: solve",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-03-16T12:08:13.540816+00:00"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue