scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-06 08:18:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

finalize run

Browse source 
⚒️ Generated with [Fabro](https://fabro.sh)
This commit is contained in:
Fabro 2026-05-22 12:55:54 -04:00
parent ca15639619
commit dcf702ae40
6 changed files with 261 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

202
run.json
View file

@ -517,7 +517,7 @@
"kind": "running"
},
"status_updated_at": "2026-05-22T16:24:39.491918Z",
"last_event_at": "2026-05-22T16:27:20.823529Z",
"last_event_at": "2026-05-22T16:54:50.758714Z",
"pending_control": null,
"checkpoints": [
{
@ -684,9 +684,9 @@
}
},
{
"seq": 0,
"seq": 64,
"checkpoint": {
"timestamp": "2026-05-22T16:29:57.936277Z",
"timestamp": "2026-05-22T16:30:09.429611Z",
"current_node": "preflight_lint",
"completed_nodes": [
"start",
@ -696,26 +696,26 @@
],
"node_retries": {},
"context_values": {
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
"failure_class": "",
"internal.retry_count.toolchain": 0,
"outcome": "succeeded",
"internal.fidelity": "compact",
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
"internal.run_id": "01KS880W1T9NYP4G0VPBSR2D5G",
"graph.goal": "---\ntitle: Add run.checkpoint.skip_git_hooks\ntype: feat\nstatus: active\ndate: 2026-05-22\n---\n\n# Add `run.checkpoint.skip_git_hooks`\n\n## Summary\n\nAdd an opt-in setting:\n\n```toml\n[run.checkpoint]\nskip_git_hooks = true\n```\n\nWhen enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.\n\n## Key Changes\n\n- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.\n- Add `skip_git_hooks: Option<bool>` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.\n- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.\n- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.\n- Thread the resolved setting into run-branch checkpoint commit creation.\n- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:\n - normal lifecycle checkpoint commits in `sandbox_git.rs`\n - parallel base checkpoint commits through the same helper\n - parallel branch worktree commits in `handler/parallel.rs`\n- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.\n- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.\n\n## Test Plan\n\n- `fabro-config` tests:\n - `[run.checkpoint] skip_git_hooks = true` resolves to `true`.\n - omitted `skip_git_hooks` resolves to `false`.\n - higher-layer `skip_git_hooks = false` overrides lower-layer `true`.\n - `exclude_globs` merging behavior remains unchanged.\n- `fabro-workflow` tests:\n - checkpoint commit command includes the hook-skip option when enabled.\n - checkpoint commit command omits it when disabled.\n - parallel branch commit command respects the setting.\n- API/client tests:\n - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.\n - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.\n- Regression:\n - existing git checkpoint tests still pass, including metadata branch tests.\n\n## Assumptions\n\n- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.\n- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.\n- Default `false` is required for backward compatibility.\n",
"thread.start.current_node": "toolchain",
"failure_signature": "",
"current_node": "preflight_lint",
"thread.toolchain.current_node": "preflight_compile",
"internal.retry_count.preflight_compile": 0,
"thread.preflight_compile.current_node": "preflight_lint",
"internal.node_visit_count": 1,
"internal.retry_count.start": 0,
"internal.work_dir": "/home/daytona/workspace/fabro",
"internal.thread_id": "preflight_compile",
"thread.start.current_node": "toolchain",
"thread.preflight_compile.current_node": "preflight_lint",
"graph.rankdir": "LR",
"internal.retry_count.start": 0,
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
"failure_signature": "",
"internal.retry_count.preflight_compile": 0,
"internal.retry_count.preflight_lint": 0,
"graph.rankdir": "LR"
"internal.work_dir": "/home/daytona/workspace/fabro",
"internal.node_visit_count": 1,
"failure_class": "",
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
"current_node": "preflight_lint",
"graph.goal": "---\ntitle: Add run.checkpoint.skip_git_hooks\ntype: feat\nstatus: active\ndate: 2026-05-22\n---\n\n# Add `run.checkpoint.skip_git_hooks`\n\n## Summary\n\nAdd an opt-in setting:\n\n```toml\n[run.checkpoint]\nskip_git_hooks = true\n```\n\nWhen enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.\n\n## Key Changes\n\n- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.\n- Add `skip_git_hooks: Option<bool>` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.\n- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.\n- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.\n- Thread the resolved setting into run-branch checkpoint commit creation.\n- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:\n - normal lifecycle checkpoint commits in `sandbox_git.rs`\n - parallel base checkpoint commits through the same helper\n - parallel branch worktree commits in `handler/parallel.rs`\n- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.\n- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.\n\n## Test Plan\n\n- `fabro-config` tests:\n - `[run.checkpoint] skip_git_hooks = true` resolves to `true`.\n - omitted `skip_git_hooks` resolves to `false`.\n - higher-layer `skip_git_hooks = false` overrides lower-layer `true`.\n - `exclude_globs` merging behavior remains unchanged.\n- `fabro-workflow` tests:\n - checkpoint commit command includes the hook-skip option when enabled.\n - checkpoint commit command omits it when disabled.\n - parallel branch commit command respects the setting.\n- API/client tests:\n - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.\n - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.\n- Regression:\n - existing git checkpoint tests still pass, including metadata branch tests.\n\n## Assumptions\n\n- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.\n- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.\n- Default `false` is required for backward compatibility.\n",
"internal.run_id": "01KS880W1T9NYP4G0VPBSR2D5G",
"outcome": "succeeded",
"thread.toolchain.current_node": "preflight_compile",
"internal.retry_count.toolchain": 0
},
"node_outcomes": {
"toolchain": {
@ -726,14 +726,6 @@
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
"usage": null
},
"preflight_lint": {
"status": "succeeded",
"context_updates": {
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126"
},
"notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1",
"usage": null
},
"preflight_compile": {
"status": "succeeded",
"context_updates": {
@ -745,20 +737,108 @@
"start": {
"status": "succeeded",
"usage": null
},
"preflight_lint": {
"status": "succeeded",
"context_updates": {
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126"
},
"notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1",
"usage": null
}
},
"next_node_id": "implement",
"git_commit_sha": "2126e704dceab447f0b8eb2ce51b6da798d97895",
"node_visits": {
"toolchain": 1,
"preflight_compile": 1,
"preflight_lint": 1,
"start": 1,
"preflight_lint": 1
"preflight_compile": 1
}
},
"diff": {}
"diff": {
"summary": {
"files_changed": 0,
"additions": 0,
"deletions": 0
}
}
}
],
"conclusion": null,
"conclusion": {
"timestamp": "2026-05-22T16:55:54.150374Z",
"status": "failed",
"timing": {
"wall_time_ms": 1873832,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"failure": {
"reason": "cancelled",
"detail": {
"message": "Pipeline cancelled",
"category": "canceled"
}
},
"final_git_commit_sha": "2126e704dceab447f0b8eb2ce51b6da798d97895",
"stages": [
{
"stage_id": "start",
"stage_label": "start",
"timing": {
"wall_time_ms": 0,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"retries": 0
},
{
"stage_id": "toolchain",
"stage_label": "toolchain",
"timing": {
"wall_time_ms": 2046,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"retries": 0
},
{
"stage_id": "preflight_compile",
"stage_label": "preflight_compile",
"timing": {
"wall_time_ms": 143123,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"retries": 0
},
{
"stage_id": "preflight_lint",
"stage_label": "preflight_lint",
"timing": {
"wall_time_ms": 157111,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"retries": 0
}
],
"billing": {
"input_tokens": 183673,
"output_tokens": 37567,
"total_tokens": 18341866,
"reasoning_tokens": 0,
"cache_read_tokens": 17926406,
"cache_write_tokens": 194220
},
"total_retries": 0,
"diff": {}
},
"sandbox": {
"provider": "daytona",
"image": "buildpack-deps:noble",
@ -779,6 +859,37 @@
"superseded_by": null,
"pending_interviews": {},
"stages": {
"implement@1": {
"first_event_seq": 67,
"prompt": null,
"response": null,
"completion": null,
"provider_used": {
"mode": "agent",
"provider": "anthropic",
"model": "claude-opus-4-7"
},
"diff": null,
"script_invocation": null,
"script_timing": null,
"parallel_results": null,
"output": null,
"started_at": "2026-05-22T16:30:09.432266Z",
"handler": "agent",
"usage": {
"input_tokens": 183673,
"output_tokens": 37567,
"total_tokens": 18341866,
"reasoning_tokens": 0,
"cache_read_tokens": 17926406,
"cache_write_tokens": 194220
},
"model": {
"provider": "anthropic",
"model_id": "claude-opus-4-7"
},
"state": "running"
},
"preflight_compile@1": {
"first_event_seq": 30,
"prompt": null,
@ -831,7 +942,12 @@
"first_event_seq": 57,
"prompt": null,
"response": null,
"completion": null,
"completion": {
"outcome": "succeeded",
"notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1",
"failure_reason": null,
"timestamp": "2026-05-22T16:29:57.935336Z"
},
"provider_used": null,
"diff": null,
"script_invocation": {
@ -839,11 +955,27 @@
"command": "exec 2>&1\ncargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1",
"language": "shell"
},
"script_timing": null,
"script_timing": {
"output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
"exit_code": 0,
"duration_ms": 157105,
"termination": "exited",
"output_bytes": 0,
"live_streaming": false
},
"parallel_results": null,
"output": null,
"output_bytes": 0,
"live_streaming": false,
"termination": "exited",
"started_at": "2026-05-22T16:27:20.823289Z",
"handler": "command",
"timing": {
"wall_time_ms": 157111,
"inference_time_ms": 0,
"tool_time_ms": 0,
"active_time_ms": 0
},
"usage": {
"input_tokens": 0,
"output_tokens": 0,
@ -852,7 +984,7 @@
"cache_read_tokens": 0,
"cache_write_tokens": 0
},
"state": "running"
"state": "succeeded"
},
"toolchain@1": {
"first_event_seq": 20,

1
stages/004-preflight_lint@1/output.log Normal file
View file

@ -0,0 +1 @@
blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126

8
stages/004-preflight_lint@1/script_timing.json Normal file
View file

@ -0,0 +1,8 @@
{
"output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
"exit_code": 0,
"duration_ms": 157105,
"termination": "exited",
"output_bytes": 0,
"live_streaming": false
}

6
stages/004-preflight_lint@1/status.json Normal file
View file

@ -0,0 +1,6 @@
{
"outcome": "succeeded",
"notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1",
"failure_reason": null,
"timestamp": "2026-05-22T16:29:57.935336Z"
}

74
stages/005-implement@1/prompt.md Normal file
View file

@ -0,0 +1,74 @@
Goal: ---
title: Add run.checkpoint.skip_git_hooks
type: feat
status: active
date: 2026-05-22
---
# Add `run.checkpoint.skip_git_hooks`
## Summary
Add an opt-in setting:
```toml
[run.checkpoint]
skip_git_hooks = true
```
When enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.
## Key Changes
- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.
- Add `skip_git_hooks: Option<bool>` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.
- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.
- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.
- Thread the resolved setting into run-branch checkpoint commit creation.
- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:
- normal lifecycle checkpoint commits in `sandbox_git.rs`
- parallel base checkpoint commits through the same helper
- parallel branch worktree commits in `handler/parallel.rs`
- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.
- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.
## Test Plan
- `fabro-config` tests:
- `[run.checkpoint] skip_git_hooks = true` resolves to `true`.
- omitted `skip_git_hooks` resolves to `false`.
- higher-layer `skip_git_hooks = false` overrides lower-layer `true`.
- `exclude_globs` merging behavior remains unchanged.
- `fabro-workflow` tests:
- checkpoint commit command includes the hook-skip option when enabled.
- checkpoint commit command omits it when disabled.
- parallel branch commit command respects the setting.
- API/client tests:
- `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.
- OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.
- Regression:
- existing git checkpoint tests still pass, including metadata branch tests.
## Assumptions
- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.
- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.
- Default `false` is required for backward compatibility.
## Completed stages
- **toolchain**: succeeded
- Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`
- Output:
```
cargo 1.95.0 (f2d3ce0bd 2026-03-21)
```
- **preflight_compile**: succeeded
- Script: `cargo check -q --workspace 2>&1`
- Output: (empty)
- **preflight_lint**: succeeded
- Script: `cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1`
- Output: (empty)
Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD.

5
stages/005-implement@1/provider_used.json Normal file
View file

@ -0,0 +1,5 @@
{
"mode": "agent",
"provider": "anthropic",
"model": "claude-opus-4-7"
}