scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-11 22:53:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: hide Ask Fabro reasoning deltas

Browse source
This commit is contained in:
Bryan Helmkamp 2026-05-22 12:57:30 -04:00
parent a8900c465d
commit d52f3726fc
No known key found for this signature in database
1 changed files with 31 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
lib/crates/fabro-server/src/server/handler/sessions.rs
View file

@ -1025,12 +1025,13 @@ fn agent_event_payload(event_turn_id: TurnId, event: AgentEvent) -> Option<Event
usage: serde_json::to_value(usage).unwrap_or(Value::Null),
},
)),
AgentEvent::TextDelta { delta } | AgentEvent::ReasoningDelta { delta } => Some(
EventBody::RunSessionAssistantDelta(RunSessionAssistantDeltaProps {
AgentEvent::TextDelta { delta } => Some(EventBody::RunSessionAssistantDelta(
RunSessionAssistantDeltaProps {
turn_id: event_turn_id,
delta,
}),
),
},
)),
AgentEvent::ReasoningDelta { .. } => None,
AgentEvent::ToolCallStarted {
tool_name,
tool_call_id,
@ -1252,6 +1253,32 @@ fn parse_turn_id(value: &str) -> Result<TurnId, ApiError> {
mod tests {
use super::*;
#[test]
fn agent_event_payload_maps_text_delta_to_session_assistant_delta() {
let turn_id = TurnId::new();
let body = agent_event_payload(turn_id, AgentEvent::TextDelta {
delta: "Hello".to_string(),
});
match body {
Some(EventBody::RunSessionAssistantDelta(props)) => {
assert_eq!(props.turn_id, turn_id);
assert_eq!(props.delta, "Hello");
}
other => panic!("expected assistant delta event, got {other:?}"),
}
}
#[test]
fn agent_event_payload_drops_reasoning_delta() {
let turn_id = TurnId::new();
let body = agent_event_payload(turn_id, AgentEvent::ReasoningDelta {
delta: "The user just said hello.".to_string(),
});
assert!(body.is_none(), "reasoning delta should not be visible");
}
#[test]
fn ask_fabro_tool_approval_allows_run_interact_and_run_events() {
let policy = build_ask_fabro_tool_approval();