scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-11 22:53:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(cli): tighten auth-required classification code

Browse source 
Simplifies three spots surfaced by a code-reuse pass: use
console::strip_ansi_codes in fatal_error_line, use provider_kind()
instead of re-pattern-matching the LLM error shape in
classify_server_agent_auth, and drop an unused const on Classified::class.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-04-21 23:59:36 -04:00
parent 105559bc8a
commit d0578f67f0
No known key found for this signature in database
3 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/crates/fabro-cli/src/commands/exec.rs
View file

@ -220,10 +220,8 @@ fn classify_server_agent_auth(err: anyhow::Error) -> anyhow::Error {
.is_some_and(|error| {
matches!(
error,
fabro_agent::Error::Llm(fabro_llm::Error::Provider {
kind: fabro_llm::ProviderErrorKind::Authentication,
..
})
fabro_agent::Error::Llm(llm)
if llm.provider_kind() == Some(ProviderErrorKind::Authentication)
)
})
});

7
lib/crates/fabro-cli/tests/it/support/mod.rs
View file

@ -63,13 +63,8 @@ pub(crate) fn run_output_filters(context: &TestContext) -> Vec<(String, String)>
}
pub(crate) fn fatal_error_line(stderr: &[u8]) -> String {
static ANSI_RE: std::sync::OnceLock<regex::Regex> = std::sync::OnceLock::new();
let ansi_re = ANSI_RE.get_or_init(|| {
regex::Regex::new(r"\x1b\[[0-9;]*m").expect("ANSI-stripping regex should compile")
});
let stderr = String::from_utf8_lossy(stderr);
let stripped = ansi_re.replace_all(&stderr, "");
stripped
console::strip_ansi_codes(&stderr)
.lines()
.rev()
.find_map(|line| line.strip_prefix("error: ").map(ToOwned::to_owned))

2
lib/crates/fabro-util/src/exit.rs
View file

@ -13,7 +13,7 @@ struct Classified {
}
impl Classified {
const fn class(&self) -> ExitClass {
fn class(&self) -> ExitClass {
self.class
}
}