From cd9b0be39340e4f2cd035eb43a884afbb50a1152 Mon Sep 17 00:00:00 2001 From: Scott Werner Date: Fri, 23 Oct 2026 17:20:56 -0400 Subject: [PATCH] Remove unnecessary installer warning regression test --- lib/apps/fabro-cli/tests/it/cmd/create.rs | 52 ----------------------- 1 file changed, 52 deletions(-) diff --git a/lib/apps/fabro-cli/tests/it/cmd/create.rs b/lib/apps/fabro-cli/tests/it/cmd/create.rs index 1d10bd302..2b4ee82df 100644 --- a/lib/apps/fabro-cli/tests/it/cmd/create.rs +++ b/lib/apps/fabro-cli/tests/it/cmd/create.rs @@ -6,7 +6,6 @@ use std::sync::atomic::{AtomicUsize, Ordering}; use std::sync::{Arc, Mutex}; -use fabro_install::InstallSandboxSelection; use fabro_test::{fabro_json_snapshot, fabro_snapshot, test_context}; use httpmock::{HttpMockResponse, Mock, MockServer}; use insta::assert_snapshot; @@ -1582,57 +1581,6 @@ fn create_registers_package_before_surfacing_server_admission_rejection() { assert!(!stderr.contains("Validation failed"), "{stderr}"); } -#[test] -fn create_uses_server_environment_without_warning_for_installer_settings() { - for (selection, provider) in [ - (InstallSandboxSelection::Docker, "docker"), - (InstallSandboxSelection::Daytona, "daytona"), - ] { - for explicit_environment in [None, Some("custom")] { - let context = test_context!(); - let server = MockServer::start(); - let run_id = unique_run_id(); - let environment_id = explicit_environment.unwrap_or("default"); - let environment_mock = mock_environment(&server, environment_id, provider); - let version_mock = mock_workflow_version_registrations(&server); - let requests = Arc::new(Mutex::new(Vec::new())); - let create_mock = mock_intent_create(&server, &run_id, Arc::clone(&requests)); - let project = tempfile::tempdir().unwrap(); - let workflow = write_workflow(project.path(), "workflow", "InstalledSettings"); - let mut settings = toml::Value::Table(toml::Table::default()); - fabro_install::write_sandbox_settings(&mut settings, selection, true).unwrap(); - context.write_home( - ".fabro/settings.toml", - toml::to_string_pretty(&settings).unwrap(), - ); - - let mut command = context.create_cmd(); - command.current_dir(project.path()).args([ - "--server", - &format!("{}/api/v1", server.base_url()), - workflow.to_str().unwrap(), - ]); - if let Some(environment_id) = explicit_environment { - command.args(["--environment", environment_id]); - } - let output = command.output().unwrap(); - - assert!(output.status.success(), "{}", output_stderr(&output)); - environment_mock.assert(); - version_mock.assert(); - create_mock.assert_calls(1); - assert_eq!( - requests.lock().unwrap()[0]["environment_id"], - environment_id - ); - assert_eq!(output_stdout(&output).trim(), run_id.as_str()); - insta::allow_duplicates! { - assert_snapshot!(output_stderr(&output), @""); - } - } - } -} - #[test] fn create_does_not_warn_for_client_only_settings() { let context = test_context!();