mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-12 23:02:41 +00:00
Fabro
parent
5d539b9317
commit
cc8caa7014
4 changed files with 172 additions and 10 deletions
|
|
@ -1,16 +1,18 @@
|
|||
{
|
||||
"timestamp": "2026-03-20T01:13:15.504264Z",
|
||||
"current_node": "simplify_opus",
|
||||
"timestamp": "2026-03-20T01:13:18.404719Z",
|
||||
"current_node": "simplify_gpt",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"toolchain",
|
||||
"preflight_compile",
|
||||
"preflight_lint",
|
||||
"implement",
|
||||
"simplify_opus"
|
||||
"simplify_opus",
|
||||
"simplify_gpt"
|
||||
],
|
||||
"node_retries": {
|
||||
"simplify_opus": 1,
|
||||
"simplify_gpt": 1,
|
||||
"preflight_compile": 1,
|
||||
"toolchain": 1,
|
||||
"start": 1,
|
||||
|
|
@ -19,25 +21,27 @@
|
|||
},
|
||||
"context_values": {
|
||||
"internal.run_id": "01KM4CDSHYC8PQ5NNEHKPJD4V0",
|
||||
"current_node": "simplify_opus",
|
||||
"current_node": "simplify_gpt",
|
||||
"last_stage": "simplify_opus",
|
||||
"graph.rankdir": "LR",
|
||||
"thread.preflight_compile.current_node": "preflight_lint",
|
||||
"internal.retry_count.simplify_opus": 1,
|
||||
"thread.start.current_node": "toolchain",
|
||||
"internal.retry_count.implement": 1,
|
||||
"failure_class": "",
|
||||
"failure_class": "deterministic",
|
||||
"internal.retry_count.preflight_lint": 1,
|
||||
"outcome": "success",
|
||||
"current.preamble": "Goal: # Strip markdown headings and \"Plan:\" prefix from GOAL column in `fabro ps`\n\n## Context\nThe `GOAL` column in `fabro ps` output sometimes shows raw markdown heading markers (`#`, `##`, etc.) and a `Plan:` prefix, which is noisy. We want to strip these for cleaner output.\n\n## Change\n**File:** `lib/crates/fabro-cli/src/commands/runs.rs` — `truncate_goal` function (line 229)\n\nBefore truncating, add two stripping steps:\n1. Strip leading `#` characters and any whitespace after them (e.g. `## Fix bug` → `Fix bug`)\n2. Strip a leading `Plan:` prefix (case-sensitive)\n3. Trim whitespace after both strips\n\nCurrent code:\n```rust\nfn truncate_goal(goal: &str, max_len: usize) -> String {\n let line = goal.lines().next().unwrap_or(\"\");\n // ... truncation logic\n}\n```\n\nUpdated logic (inserted after extracting `line`, before truncation):\n```rust\nlet line = line.trim_start_matches('#').trim();\nlet line = line.strip_prefix(\"Plan:\").map(|s| s.trim()).unwrap_or(line);\n```\n\n## Verification\n- `cargo test -p fabro-cli` — run existing tests\n- `cargo clippy --workspace -- -D warnings` — lint check\n- Manual: `fabro ps -a` to confirm goals render without `#` or `Plan:` prefixes\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n- **preflight_compile**: success\n - Script: `cargo check -q --workspace 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **preflight_lint**: success\n - Script: `cargo clippy -q --workspace -- -D warnings 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **implement**: success\n - Model: claude-opus-4-6, 15.2k tokens in / 2.5k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/commands/runs.rs\n",
|
||||
"outcome": "fail",
|
||||
"current.preamble": "Goal: # Strip markdown headings and \"Plan:\" prefix from GOAL column in `fabro ps`\n\n## Context\nThe `GOAL` column in `fabro ps` output sometimes shows raw markdown heading markers (`#`, `##`, etc.) and a `Plan:` prefix, which is noisy. We want to strip these for cleaner output.\n\n## Change\n**File:** `lib/crates/fabro-cli/src/commands/runs.rs` — `truncate_goal` function (line 229)\n\nBefore truncating, add two stripping steps:\n1. Strip leading `#` characters and any whitespace after them (e.g. `## Fix bug` → `Fix bug`)\n2. Strip a leading `Plan:` prefix (case-sensitive)\n3. Trim whitespace after both strips\n\nCurrent code:\n```rust\nfn truncate_goal(goal: &str, max_len: usize) -> String {\n let line = goal.lines().next().unwrap_or(\"\");\n // ... truncation logic\n}\n```\n\nUpdated logic (inserted after extracting `line`, before truncation):\n```rust\nlet line = line.trim_start_matches('#').trim();\nlet line = line.strip_prefix(\"Plan:\").map(|s| s.trim()).unwrap_or(line);\n```\n\n## Verification\n- `cargo test -p fabro-cli` — run existing tests\n- `cargo clippy --workspace -- -D warnings` — lint check\n- Manual: `fabro ps -a` to confirm goals render without `#` or `Plan:` prefixes\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n- **preflight_compile**: success\n - Script: `cargo check -q --workspace 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **preflight_lint**: success\n - Script: `cargo clippy -q --workspace -- -D warnings 2>&1`\n - Stdout: (empty)\n - Stderr: (empty)\n- **implement**: success\n - Model: claude-opus-4-6, 15.2k tokens in / 2.5k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/commands/runs.rs\n- **simplify_opus**: success\n - Model: claude-opus-4-6, 18.2k tokens in / 6.4k out\n - Files: /home/daytona/workspace/lib/crates/fabro-cli/src/commands/runs.rs\n",
|
||||
"thread.preflight_lint.current_node": "implement",
|
||||
"response.simplify_opus": "## Summary\n\n**Fixed 1 issue:**\n\n- **Leaky abstraction** (line 409): `truncate_goal` was being called on `workflow_name`, which would incorrectly strip `#` characters and `Plan:` prefix from workflow names. Extracted a generic `truncate_str` helper for plain truncation and changed the `workflow_name` call site to use it. `truncate_goal` now delegates to `truncate_str` after doing its goal-specific cleanup.\n\n**Noted but skipped (out of scope / false positive):**\n\n- **Near-duplicate with `pr_title_from_goal`**: Valid finding — both functions do similar goal cleaning. However, they live in different crates (`fabro-cli` vs `fabro-workflows`) and extracting a shared utility into `fabro-util` is a larger refactor beyond the scope of this change.\n- **Greedy `trim_start_matches('#')`**: Agent 2 noted this could strip `#` from non-heading contexts like `#channel-name`. In practice, goals in this system are user-provided task descriptions, not Slack references, and the existing test suite validates the expected behavior. The greedy approach is intentionally simpler and handles `###`+ headings that the `pr_title_from_goal` version misses. Not worth changing.\n- **`\"Plan:\"` as a shared constant**: Only two uses across separate crates — not worth the abstraction overhead.",
|
||||
"internal.node_visit_count": 1,
|
||||
"failure_signature": "",
|
||||
"internal.retry_count.simplify_gpt": 1,
|
||||
"thread.simplify_opus.current_node": "simplify_gpt",
|
||||
"failure_signature": "simplify_gpt|deterministic|api_deterministic|anthropic|not_found",
|
||||
"graph.goal": "# Strip markdown headings and \"Plan:\" prefix from GOAL column in `fabro ps`\n\n## Context\nThe `GOAL` column in `fabro ps` output sometimes shows raw markdown heading markers (`#`, `##`, etc.) and a `Plan:` prefix, which is noisy. We want to strip these for cleaner output.\n\n## Change\n**File:** `lib/crates/fabro-cli/src/commands/runs.rs` — `truncate_goal` function (line 229)\n\nBefore truncating, add two stripping steps:\n1. Strip leading `#` characters and any whitespace after them (e.g. `## Fix bug` → `Fix bug`)\n2. Strip a leading `Plan:` prefix (case-sensitive)\n3. Trim whitespace after both strips\n\nCurrent code:\n```rust\nfn truncate_goal(goal: &str, max_len: usize) -> String {\n let line = goal.lines().next().unwrap_or(\"\");\n // ... truncation logic\n}\n```\n\nUpdated logic (inserted after extracting `line`, before truncation):\n```rust\nlet line = line.trim_start_matches('#').trim();\nlet line = line.strip_prefix(\"Plan:\").map(|s| s.trim()).unwrap_or(line);\n```\n\n## Verification\n- `cargo test -p fabro-cli` — run existing tests\n- `cargo clippy --workspace -- -D warnings` — lint check\n- Manual: `fabro ps -a` to confirm goals render without `#` or `Plan:` prefixes\n",
|
||||
"response.implement": "The implementation is complete. Here's a summary of the changes:\n\n**`lib/crates/fabro-cli/src/commands/runs.rs`:**\n\n1. **`truncate_goal` function** (line 231-232): Added two stripping steps after extracting the first line:\n - `line.trim_start_matches('#').trim()` — strips leading `#` characters and surrounding whitespace\n - `line.strip_prefix(\"Plan:\").map(|s| s.trim()).unwrap_or(line)` — strips a leading `Plan:` prefix if present\n\n2. **Tests** (5 new tests added):\n - `truncate_goal_strips_markdown_headings` — verifies `#`, `##`, `###` are stripped\n - `truncate_goal_strips_plan_prefix` — verifies `Plan:` prefix is stripped\n - `truncate_goal_strips_heading_and_plan_prefix` — verifies both combined (`## Plan: migrate DB` → `migrate DB`)\n - `truncate_goal_plain_text_unchanged` — verifies plain text passes through unchanged\n - `truncate_goal_still_truncates_after_stripping` — verifies truncation still works after stripping",
|
||||
"graph.model_stylesheet": "\n * { backend: api; model: claude-opus-4-6;}\n ",
|
||||
"internal.thread_id": "implement",
|
||||
"internal.thread_id": "simplify_opus",
|
||||
"command.output": "",
|
||||
"command.stderr": "",
|
||||
"internal.retry_count.toolchain": 1,
|
||||
|
|
@ -54,6 +58,15 @@
|
|||
"status": "success",
|
||||
"duration_ms": 0
|
||||
},
|
||||
"simplify_gpt": {
|
||||
"status": "fail",
|
||||
"failure": {
|
||||
"message": "LLM error: Not found on anthropic: model: gpt-54",
|
||||
"failure_class": "deterministic",
|
||||
"failure_signature": "api_deterministic|anthropic|not_found"
|
||||
},
|
||||
"duration_ms": 370
|
||||
},
|
||||
"preflight_compile": {
|
||||
"status": "success",
|
||||
"context_updates": {
|
||||
|
|
@ -126,10 +139,14 @@
|
|||
"duration_ms": 148532
|
||||
}
|
||||
},
|
||||
"next_node_id": "simplify_gpt",
|
||||
"next_node_id": "verify",
|
||||
"loop_failure_signatures": {
|
||||
"simplify_gpt|deterministic|api_deterministic|anthropic|not_found": 1
|
||||
},
|
||||
"node_visits": {
|
||||
"simplify_opus": 1,
|
||||
"toolchain": 1,
|
||||
"simplify_gpt": 1,
|
||||
"implement": 1,
|
||||
"preflight_compile": 1,
|
||||
"preflight_lint": 1,
|
||||
|
|
|
|||
107
nodes/simplify_gpt/prompt.md
Normal file
107
nodes/simplify_gpt/prompt.md
Normal file
|
|
@ -0,0 +1,107 @@
|
|||
Goal: # Strip markdown headings and "Plan:" prefix from GOAL column in `fabro ps`
|
||||
|
||||
## Context
|
||||
The `GOAL` column in `fabro ps` output sometimes shows raw markdown heading markers (`#`, `##`, etc.) and a `Plan:` prefix, which is noisy. We want to strip these for cleaner output.
|
||||
|
||||
## Change
|
||||
**File:** `lib/crates/fabro-cli/src/commands/runs.rs` — `truncate_goal` function (line 229)
|
||||
|
||||
Before truncating, add two stripping steps:
|
||||
1. Strip leading `#` characters and any whitespace after them (e.g. `## Fix bug` → `Fix bug`)
|
||||
2. Strip a leading `Plan:` prefix (case-sensitive)
|
||||
3. Trim whitespace after both strips
|
||||
|
||||
Current code:
|
||||
```rust
|
||||
fn truncate_goal(goal: &str, max_len: usize) -> String {
|
||||
let line = goal.lines().next().unwrap_or("");
|
||||
// ... truncation logic
|
||||
}
|
||||
```
|
||||
|
||||
Updated logic (inserted after extracting `line`, before truncation):
|
||||
```rust
|
||||
let line = line.trim_start_matches('#').trim();
|
||||
let line = line.strip_prefix("Plan:").map(|s| s.trim()).unwrap_or(line);
|
||||
```
|
||||
|
||||
## Verification
|
||||
- `cargo test -p fabro-cli` — run existing tests
|
||||
- `cargo clippy --workspace -- -D warnings` — lint check
|
||||
- Manual: `fabro ps -a` to confirm goals render without `#` or `Plan:` prefixes
|
||||
|
||||
|
||||
## Completed stages
|
||||
- **toolchain**: success
|
||||
- Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`
|
||||
- Stdout:
|
||||
```
|
||||
cargo 1.94.0 (85eff7c80 2026-01-15)
|
||||
```
|
||||
- Stderr: (empty)
|
||||
- **preflight_compile**: success
|
||||
- Script: `cargo check -q --workspace 2>&1`
|
||||
- Stdout: (empty)
|
||||
- Stderr: (empty)
|
||||
- **preflight_lint**: success
|
||||
- Script: `cargo clippy -q --workspace -- -D warnings 2>&1`
|
||||
- Stdout: (empty)
|
||||
- Stderr: (empty)
|
||||
- **implement**: success
|
||||
- Model: claude-opus-4-6, 15.2k tokens in / 2.5k out
|
||||
- Files: /home/daytona/workspace/lib/crates/fabro-cli/src/commands/runs.rs
|
||||
- **simplify_opus**: success
|
||||
- Model: claude-opus-4-6, 18.2k tokens in / 6.4k out
|
||||
- Files: /home/daytona/workspace/lib/crates/fabro-cli/src/commands/runs.rs
|
||||
|
||||
|
||||
# Simplify: Code Review and Cleanup
|
||||
|
||||
Review all changed files for reuse, quality, and efficiency. Fix any issues found.
|
||||
|
||||
## Phase 1: Identify Changes
|
||||
|
||||
Run git diff (or git diff HEAD if there are staged changes) to see what changed. If there are no git changes, review the most recently modified files that the user mentioned or that you edited earlier in this conversation.
|
||||
|
||||
## Phase 2: Launch Three Review Agents in Parallel
|
||||
|
||||
Use the Agent tool to launch all three agents concurrently in a single message. Pass each agent the full diff so it has the complete context.
|
||||
|
||||
### Agent 1: Code Reuse Review
|
||||
|
||||
For each change:
|
||||
|
||||
1. Search for existing utilities and helpers that could replace newly written code. Use Grep to find similar patterns elsewhere in the codebase — common locations are utility directories, shared modules, and files adjacent to the changed ones.
|
||||
2. Flag any new function that duplicates existing functionality. Suggest the existing function to use instead.
|
||||
3. Flag any inline logic that could use an existing utility — hand-rolled string manipulation, manual path handling, custom environment checks, ad-hoc type guards, and similar patterns are common candidates.
|
||||
|
||||
Note: This is a greenfield app, so focus on maximizing simplicity and don't worry about changing things to achieve it.
|
||||
|
||||
### Agent 2: Code Quality Review
|
||||
|
||||
Review the same changes for hacky patterns:
|
||||
|
||||
1. Redundant state: state that duplicates existing state, cached values that could be derived, observers/effects that could be direct calls
|
||||
2. Parameter sprawl: adding new parameters to a function instead of generalizing or restructuring existing ones
|
||||
3. Copy-paste with slight variation: near-duplicate code blocks that should be unified with a shared abstraction
|
||||
4. Leaky abstractions: exposing internal details that should be encapsulated, or breaking existing abstraction boundaries
|
||||
5. Stringly-typed code: using raw strings where constants, enums (string unions), or branded types already exist in the codebase
|
||||
|
||||
Note: This is a greenfield app, so be aggressive in optimizing quality.
|
||||
|
||||
### Agent 3: Efficiency Review
|
||||
|
||||
Review the same changes for efficiency:
|
||||
|
||||
1. Unnecessary work: redundant computations, repeated file reads, duplicate network/API calls, N+1 patterns
|
||||
2. Missed concurrency: independent operations run sequentially when they could run in parallel
|
||||
3. Hot-path bloat: new blocking work added to startup or per-request/per-render hot paths
|
||||
4. Unnecessary existence checks: pre-checking file/resource existence before operating (TOCTOU anti-pattern) — operate directly and handle the error
|
||||
5. Memory: unbounded data structures, missing cleanup, event listener leaks
|
||||
6. Overly broad operations: reading entire files when only a portion is needed, loading all items when filtering for one
|
||||
|
||||
## Phase 3: Fix Issues
|
||||
|
||||
Wait for all three agents to complete. Aggregate their findings and fix each issue directly. If a finding is a false positive or not worth addressing, note it and move on — do not argue with the finding, just skip it.
|
||||
|
||||
When done, briefly summarize what was fixed (or confirm the code was already clean).
|
||||
6
nodes/simplify_gpt/status.json
Normal file
6
nodes/simplify_gpt/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"status": "fail",
|
||||
"notes": null,
|
||||
"failure_reason": "LLM error: Not found on anthropic: model: gpt-54",
|
||||
"timestamp": "2026-03-20T01:13:18.404198+00:00"
|
||||
}
|
||||
32
nodes/simplify_opus/diff.patch
Normal file
32
nodes/simplify_opus/diff.patch
Normal file
|
|
@ -0,0 +1,32 @@
|
|||
diff --git a/lib/crates/fabro-cli/src/commands/runs.rs b/lib/crates/fabro-cli/src/commands/runs.rs
|
||||
index 0d418c90..22632964 100644
|
||||
--- a/lib/crates/fabro-cli/src/commands/runs.rs
|
||||
+++ b/lib/crates/fabro-cli/src/commands/runs.rs
|
||||
@@ -230,11 +230,15 @@ fn truncate_goal(goal: &str, max_len: usize) -> String {
|
||||
let line = goal.lines().next().unwrap_or("");
|
||||
let line = line.trim_start_matches('#').trim();
|
||||
let line = line.strip_prefix("Plan:").map(|s| s.trim()).unwrap_or(line);
|
||||
- let char_count = line.chars().count();
|
||||
+ truncate_str(line, max_len)
|
||||
+}
|
||||
+
|
||||
+fn truncate_str(s: &str, max_len: usize) -> String {
|
||||
+ let char_count = s.chars().count();
|
||||
if char_count <= max_len {
|
||||
- return line.to_string();
|
||||
+ return s.to_string();
|
||||
}
|
||||
- let truncated: String = line.chars().take(max_len - 3).collect();
|
||||
+ let truncated: String = s.chars().take(max_len - 3).collect();
|
||||
format!("{truncated}...")
|
||||
}
|
||||
|
||||
@@ -406,7 +410,7 @@ fn df_from(args: &DfArgs, data_dir: &Path, runs_base: &Path, logs_base: &Path) -
|
||||
};
|
||||
vec![
|
||||
short_run_id(&detail.run_id).cell(),
|
||||
- truncate_goal(&detail.workflow_name, 16).cell(),
|
||||
+ truncate_str(&detail.workflow_name, 16).cell(),
|
||||
detail.status.to_string().cell(),
|
||||
age.cell().justify(Justify::Right),
|
||||
size_display.cell().justify(Justify::Right),
|
||||
Loading…
Add table
Reference in a new issue