mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-10 03:30:59 +00:00
parent
80c53a9111
commit
cbf3d3d3b9
5 changed files with 652 additions and 341 deletions
928
run.json
928
run.json
File diff suppressed because one or more lines are too long
32
stages/007-simplify_gpt@1/diff.patch
Normal file
32
stages/007-simplify_gpt@1/diff.patch
Normal file
|
|
@ -0,0 +1,32 @@
|
|||
diff --git a/docs/public/api-reference/fabro-api.yaml b/docs/public/api-reference/fabro-api.yaml
|
||||
index 1693d5f29..e9ba9c616 100644
|
||||
--- a/docs/public/api-reference/fabro-api.yaml
|
||||
+++ b/docs/public/api-reference/fabro-api.yaml
|
||||
@@ -7994,8 +7994,10 @@ components:
|
||||
type: integer
|
||||
minimum: 1
|
||||
message:
|
||||
- type: ["object", "null"]
|
||||
- additionalProperties: true
|
||||
+ oneOf:
|
||||
+ - type: object
|
||||
+ additionalProperties: true
|
||||
+ - type: "null"
|
||||
description: Canonical replay-authoritative transcript message, when present.
|
||||
context_window:
|
||||
oneOf:
|
||||
diff --git a/lib/packages/fabro-api-client/src/models/agent-message-props.ts b/lib/packages/fabro-api-client/src/models/agent-message-props.ts
|
||||
index 3aa5c34b6..a0c268de2 100644
|
||||
--- a/lib/packages/fabro-api-client/src/models/agent-message-props.ts
|
||||
+++ b/lib/packages/fabro-api-client/src/models/agent-message-props.ts
|
||||
@@ -32,9 +32,6 @@ export interface AgentMessageProps {
|
||||
'billing': BilledTokenCounts;
|
||||
'tool_call_count': number;
|
||||
'visit': number;
|
||||
- /**
|
||||
- * Canonical replay-authoritative transcript message, when present.
|
||||
- */
|
||||
- 'message'?: { [key: string]: any; };
|
||||
+ 'message'?: { [key: string]: any; } | null;
|
||||
'context_window'?: StageContextWindowProjection | null;
|
||||
}
|
||||
22
stages/007-simplify_gpt@1/response.md
Normal file
22
stages/007-simplify_gpt@1/response.md
Normal file
|
|
@ -0,0 +1,22 @@
|
|||
Implemented a small cleanup from the simplify review.
|
||||
|
||||
Changed:
|
||||
- `docs/public/api-reference/fabro-api.yaml`
|
||||
- Adjusted `AgentMessageProps.message` to use `oneOf: object | null` instead of `type: ["object", "null"]`, matching the style that generates correct nullable TypeScript.
|
||||
- `lib/packages/fabro-api-client/src/models/agent-message-props.ts`
|
||||
- Regenerated/updated `message?: { ... } | null`.
|
||||
|
||||
Validation run:
|
||||
- `cargo build -p fabro-api`
|
||||
- `cargo nextest run -p fabro-types agent_message`
|
||||
- `cargo nextest run -p fabro-server get_run_stage_context_window`
|
||||
- `cd lib/packages/fabro-api-client && bun run generate`
|
||||
- `cd lib/packages/fabro-api-client && bun run typecheck`
|
||||
- `cd apps/fabro-web && bun test app/lib/run-events.test.tsx app/lib/query-keys.test.ts`
|
||||
- Final search:
|
||||
- `agent.context_window.snapshot`
|
||||
- `AgentContextWindowSnapshot`
|
||||
- `ContextWindowSnapshot`
|
||||
- No matches in implementation/API/frontend paths.
|
||||
|
||||
No additional code reuse/quality/efficiency issues were found worth changing.
|
||||
6
stages/007-simplify_gpt@1/status.json
Normal file
6
stages/007-simplify_gpt@1/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"outcome": "succeeded",
|
||||
"notes": "Stage completed: simplify_gpt",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-24T18:17:16.338008Z"
|
||||
}
|
||||
5
stages/008-verify@1/script_invocation.json
Normal file
5
stages/008-verify@1/script_invocation.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"script": "git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
|
||||
"command": "exec 2>&1\ngit fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
|
||||
"language": "shell"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue