From c2cf1ccbf7601c986d18b10073b9f78fd9cfa207 Mon Sep 17 00:00:00 2001 From: Scott Werner Date: Tue, 16 Jun 2026 09:40:52 -0400 Subject: [PATCH] refactor(auth): inline ApiCredential construction in ApiKey arm Collapse a struct-then-mutate into the constructor: extra_headers and base_url were initialized with placeholders and immediately overwritten. Matches the AwsSigv4/OAuth arms. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) --- lib/crates/fabro-auth/src/resolve.rs | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/crates/fabro-auth/src/resolve.rs b/lib/crates/fabro-auth/src/resolve.rs index 4acae3c74..62e140331 100644 --- a/lib/crates/fabro-auth/src/resolve.rs +++ b/lib/crates/fabro-auth/src/resolve.rs @@ -406,17 +406,18 @@ impl CredentialResolver { .ok_or_else(|| ResolveError::NotConfigured(provider_id.clone()))?; let auth_header = auth_header_for_catalog_provider(provider, key.clone())?; let mut cred = ApiCredential { - provider: provider_id.clone(), - auth_header: Some(auth_header), - extra_headers: HashMap::new(), - base_url: None, - codex_mode: false, - org_id: None, - project_id: None, + provider: provider_id.clone(), + auth_header: Some(auth_header), + extra_headers: self.resolved_extra_headers_for_catalog( + vault, + provider_id, + catalog, + )?, + base_url, + codex_mode: false, + org_id: None, + project_id: None, }; - cred.base_url = base_url; - cred.extra_headers = - self.resolved_extra_headers_for_catalog(vault, provider_id, catalog)?; if provider_id == &ProviderId::openai() { apply_openai_api_env_context(&mut cred, &*self.env_lookup); }