scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-06 08:18:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix agent sessions ignoring node-level model/provider from stylesheets

Browse source 
AgentApiBackend::create_session() always used the backend's default
model/provider, ignoring attributes set on the node by stylesheet
application. The one_shot path already read node.model() correctly
but the agent session path (used by implement and other agent stages)
did not. Also fixes usage reporting and provider_used.json to reflect
the actual model used rather than the backend default.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-19 19:48:53 -04:00
parent 2f9a1d0482
commit bb2d0a6736
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
lib/crates/fabro-workflows/src/backend/api.rs
View file

@ -160,9 +160,14 @@ impl AgentApiBackend {
sandbox: &Arc<dyn Sandbox>,
tool_hooks: Option<Arc<dyn fabro_agent::ToolHookCallback>>,
) -> Result<Session, FabroError> {
let model = node.model().unwrap_or(&self.model);
let provider = node
.provider()
.and_then(|p| p.parse::<Provider>().ok())
.unwrap_or(self.provider);
Self::create_session_for(
&self.model,
self.provider,
model,
provider,
node,
sandbox,
&self.env,
@ -412,6 +417,12 @@ impl CodergenBackend for AgentApiBackend {
sandbox: &Arc<dyn Sandbox>,
tool_hooks: Option<Arc<dyn fabro_agent::ToolHookCallback>>,
) -> Result<CodergenResult, FabroError> {
let actual_model = node.model().unwrap_or(&self.model).to_string();
let actual_provider = node
.provider()
.and_then(|p| p.parse::<Provider>().ok())
.unwrap_or(self.provider);
let fidelity = context.fidelity();
let reuse_key = if fidelity == crate::context::keys::Fidelity::Full {
thread_id.map(String::from)
@ -577,7 +588,7 @@ impl CodergenBackend for AgentApiBackend {
}
let mut stage_usage = StageUsage {
model: self.model.clone(),
model: actual_model.clone(),
input_tokens: total_usage.input_tokens,
output_tokens: total_usage.output_tokens,
cache_read_tokens: total_usage.cache_read_tokens,
@ -613,8 +624,8 @@ impl CodergenBackend for AgentApiBackend {
let provider_used = serde_json::json!({
"mode": "agent",
"provider": self.provider.as_str(),
"model": &self.model,
"provider": actual_provider.as_str(),
"model": &actual_model,
});
if let Ok(json) = serde_json::to_string_pretty(&provider_used) {
let _ = std::fs::write(stage_dir.join("provider_used.json"), json);