scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-08 03:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix PR body rendering bugs found in PR #15 code review

Browse source 
Use 4-backtick fences for plan section to prevent LLM-generated
triple backticks from breaking the markdown. Fix singular/plural
grammar for stage, node, and edge counts.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-09 22:53:05 -04:00
parent 1846846e72
commit b4045ffc3c
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/crates/arc-workflows/src/pull_request.rs
View file

@ -130,7 +130,8 @@ fn format_arc_details_section(retro: &Retro, dot_source: Option<&str>) -> String
let total_cost_str = format_cost(retro.stats.total_cost);
let stage_count = retro.stages.len();
parts.push(format!(
"<details>\n<summary>Ran {stage_count} stages in {total_duration} for {total_cost_str}</summary>"
"<details>\n<summary>Ran {stage_count} {} in {total_duration} for {total_cost_str}</summary>",
if stage_count == 1 { "stage" } else { "stages" }
));
parts.push(String::new());
@ -161,7 +162,9 @@ fn format_arc_details_section(retro: &Retro, dot_source: Option<&str>) -> String
let (graph_name, node_count, edge_count) = parse_dot_summary(dot);
parts.push(format!(
"<details>\n<summary>Ran <code>{graph_name}</code> ({node_count} nodes and {edge_count} edges)</summary>"
"<details>\n<summary>Ran <code>{graph_name}</code> ({node_count} {} and {edge_count} {})</summary>",
if node_count == 1 { "node" } else { "nodes" },
if edge_count == 1 { "edge" } else { "edges" }
));
parts.push(String::new());
parts.push("```dot".to_string());
@ -235,9 +238,9 @@ fn assemble_pr_body(
parts.push("<details>".to_string());
parts.push("<summary>Full plan</summary>".to_string());
parts.push(String::new());
parts.push("```md".to_string());
parts.push("````md".to_string());
parts.push(plan.to_string());
parts.push("```".to_string());
parts.push("````".to_string());
parts.push(String::new());
parts.push("</details>".to_string());
}
@ -554,7 +557,7 @@ mod tests {
let section = format_arc_details_section(&retro, Some(dot));
assert!(section.contains("<code>implement.dot</code>"));
assert!(section.contains("2 nodes and 1 edges"));
assert!(section.contains("2 nodes and 1 edge"));
assert!(section.contains("```dot"));
assert!(section.contains("digraph implement"));
}
@ -614,7 +617,7 @@ mod tests {
assert!(body.contains("This is the narrative."));
assert!(body.contains("### Plan Summary"));
assert!(body.contains("<details>\n<summary>Full plan</summary>"));
assert!(body.contains("```md\nFull plan text here\n```"));
assert!(body.contains("````md\nFull plan text here\n````"));
assert!(body.contains("### Retro"));
assert!(body.contains("### Arc Details"));
}