scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-11-01 07:02:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Recognize transient infrastructure failures by their reason

Browse source 
The server records a failure's category as deterministic or canceled, so
checking only the transient_infra category never fired. Check the
transient_infra reason as well, the way budget exhaustion already is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Scott Werner 2026-10-27 14:00:16 -04:00
parent 285a1d06be
commit aed46202b0
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/fabro-web/app/routes/run-detail/failure.test.ts
View file

@ -154,6 +154,10 @@ describe("buildRunFailureView", () => {
expect(view(failedRun({ message: "denied at review" }, { reason: "approval_denied" }))?.headline).toBe("Approval was denied");
expect(view(failedRun({ message: "budget of $5 reached" }, { reason: "budget_exhausted" }))?.headline).toBe("The run used up its budget");
expect(view(failedRun({ message: "sandbox image not found" }, { reason: "sandbox_init_failed" }))?.headline).toBe("The run couldn't start");
expect(view(failedRun({ message: "sandbox connection reset" }, { reason: "transient_infra" }))).toMatchObject({
headline: "The step hit a temporary infrastructure error",
nextStep: "Choose Retry from Actions in a few minutes.",
});
});
test("says why a dead run stopped, though a dead run records no conclusion", () => {

15
apps/fabro-web/app/routes/run-detail/failure.ts
View file

@ -61,7 +61,9 @@ export function buildRunFailureView(
const name = (id: string) => providerNames.get(id) ?? id;
const advice =
reasonAdvice(failure.reason, category) ??
(request ? requestAdvice(request, message, name(request.provider)) : stepAdvice(message, category, output));
(request
? requestAdvice(request, message, name(request.provider))
: stepAdvice(message, failure.reason, category, output));
return {
stage: stage?.replace(/@1$/, "") ?? null,
...advice,
@ -192,7 +194,14 @@ function requestAdvice({ kind, status, code }: ModelRequest, message: string, wh
};
}
function stepAdvice(message: string, category: FailureCategory, output: string | null): Advice {
// A transient model request failure keeps requestAdvice's wording, which
// names the provider, so transient infrastructure is checked here.
function stepAdvice(
message: string,
reason: FailureReason,
category: FailureCategory,
output: string | null,
): Advice {
const exit = /exited with (?:status|code) (\d+)/i.exec(message);
if (exit) {
return {
@ -200,7 +209,7 @@ function stepAdvice(message: string, category: FailureCategory, output: string |
nextStep: output ? "Its output, under Details, usually says why." : "Open the step's logs for its output.",
};
}
if (category === FailureCategory.TRANSIENT_INFRA) {
if (reason === FailureReason.TRANSIENT_INFRA || category === FailureCategory.TRANSIENT_INFRA) {
return { headline: "The step hit a temporary infrastructure error", nextStep: "Choose Retry from Actions in a few minutes." };
}
return { headline: firstSentence(message), nextStep: "Open the failed step's logs for details." };