From ae37d0316eb8db1f30641d96a08cbfe4623529a1 Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Sat, 28 Mar 2026 01:20:06 -0400 Subject: [PATCH] Clean up runtime path docs and test comment --- docs/reference/run-directory.mdx | 4 ++-- lib/crates/fabro-cli/tests/cli.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/reference/run-directory.mdx b/docs/reference/run-directory.mdx index 570f15b75..0d681b60d 100644 --- a/docs/reference/run-directory.mdx +++ b/docs/reference/run-directory.mdx @@ -22,7 +22,7 @@ The naming format is `YYYYMMDD-{run_id}`, where `run_id` is the ULID assigned to | `run.json` | JSON | Run create | Run metadata — `run_id`, `created_at`, `config` (FabroConfig), `graph` (Graph), `workflow_slug`, `working_directory`, `host_repo_path`, `base_branch`, `labels` | | `start.json` | JSON | Run start | Start metadata — `run_id`, `start_time`, `run_branch`, `base_sha` | | `workflow.fabro` | Graphviz | Run create | Copy of the original workflow graph when the raw DOT source is available | -| `run.pid` | Text | Run start | Process ID of the running CLI process. Presence indicates the run is active; an orphaned file indicates a crash. | +| `run.pid` | Text | Legacy fallback only | Legacy process ID file from older runs. Current detached launches use launcher records instead, but attach/resume still read `run.pid` for backward compatibility. | | `workflow.toml` | TOML | Run create | Copy of the original workflow file (only when the workflow is defined in TOML) | | `progress.jsonl` | JSONL | Continuous | Event stream — one JSON object per line for every significant event (stage starts, completions, tool calls, retries, etc.). See [Observability](/execution/observability) for the full event catalog. | | `live.json` | JSON | Continuous | Current execution state snapshot, overwritten on each event. Used for live monitoring. | @@ -94,7 +94,7 @@ fabro ps --filter workflow=my-workflow │ ├── run.json │ ├── start.json │ ├── workflow.fabro -│ ├── run.pid +│ ├── run.pid # Legacy fallback; older runs may contain this │ ├── workflow.toml │ ├── progress.jsonl │ ├── live.json diff --git a/lib/crates/fabro-cli/tests/cli.rs b/lib/crates/fabro-cli/tests/cli.rs index f03c2e937..2d3f52ae8 100644 --- a/lib/crates/fabro-cli/tests/cli.rs +++ b/lib/crates/fabro-cli/tests/cli.rs @@ -1271,8 +1271,8 @@ digraph Test { ); } -// Bug 3: attach loop must delete interview_request.json after handling it -// to prevent re-prompting the user on the next poll iteration. +// Bug 3: attach loop must leave interview_request.json in place until the +// engine consumes interview_response.json, so reattach remains safe. #[test] fn bug3_attach_leaves_interview_request_until_engine_consumes_response() { let home = tempfile::tempdir().unwrap();