mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-08 03:10:26 +00:00
Fix dry-run issues: stub scripts, runner cd, transition weight
- Add stub scripts for clone-substack (validate-*.sh, fix-fmt.sh) - Update runner to cd into dot file directory so relative script paths resolve correctly - Add weight=10 to transition-patterns approve edge to avoid review→fix loop in dry-run (mock LLM has no routing directives) 35/36 pass dry-run. clone-substack hits dry-run's hard 10-visit safety limit on its implement loop — expected for complex looping workflows with mock LLMs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
ec598c4abb
commit
a519124532
8 changed files with 29 additions and 29 deletions
2
test/docs/examples/clone-substack/scripts/fix-fmt.sh
Executable file
2
test/docs/examples/clone-substack/scripts/fix-fmt.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
2
test/docs/examples/clone-substack/scripts/validate-artifacts.sh
Executable file
2
test/docs/examples/clone-substack/scripts/validate-artifacts.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
2
test/docs/examples/clone-substack/scripts/validate-browser.sh
Executable file
2
test/docs/examples/clone-substack/scripts/validate-browser.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
2
test/docs/examples/clone-substack/scripts/validate-build.sh
Executable file
2
test/docs/examples/clone-substack/scripts/validate-build.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
2
test/docs/examples/clone-substack/scripts/validate-fmt.sh
Executable file
2
test/docs/examples/clone-substack/scripts/validate-fmt.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
2
test/docs/examples/clone-substack/scripts/validate-test.sh
Executable file
2
test/docs/examples/clone-substack/scripts/validate-test.sh
Executable file
|
|
@ -0,0 +1,2 @@
|
|||
#\!/bin/sh
|
||||
echo "stub: $0"
|
||||
|
|
@ -13,14 +13,18 @@ total=0
|
|||
|
||||
run_one() {
|
||||
local dot="$1"
|
||||
local dot_dir
|
||||
dot_dir="$(dirname "$dot")"
|
||||
local dot_name
|
||||
dot_name="$(basename "$dot")"
|
||||
local rel
|
||||
rel="$(realpath --relative-to="$SCRIPT_DIR" "$dot" 2>/dev/null || echo "$dot")"
|
||||
rel="$(python3 -c "import os; print(os.path.relpath('$dot', '$SCRIPT_DIR'))")"
|
||||
|
||||
# Check for companion run.toml (run-<stem>.toml in same dir)
|
||||
local stem
|
||||
stem="$(basename "${dot%.dot}")"
|
||||
local toml
|
||||
toml="$(dirname "$dot")/run-${stem}.toml"
|
||||
toml="${dot_dir}/run-${stem}.toml"
|
||||
|
||||
total=$((total + 1))
|
||||
|
||||
|
|
@ -34,32 +38,16 @@ run_one() {
|
|||
fail=$((fail + 1))
|
||||
fi
|
||||
;;
|
||||
dry-run)
|
||||
local target="$dot"
|
||||
[[ -f "$toml" ]] && target="$toml"
|
||||
if "$ARC" run start "$target" --dry-run --auto-approve 2>&1; then
|
||||
echo " PASS $rel"
|
||||
pass=$((pass + 1))
|
||||
else
|
||||
echo " FAIL $rel"
|
||||
fail=$((fail + 1))
|
||||
fi
|
||||
;;
|
||||
haiku)
|
||||
local target="$dot"
|
||||
[[ -f "$toml" ]] && target="$toml"
|
||||
if "$ARC" run start "$target" --model claude-haiku-4-5 --auto-approve 2>&1; then
|
||||
echo " PASS $rel"
|
||||
pass=$((pass + 1))
|
||||
else
|
||||
echo " FAIL $rel"
|
||||
fail=$((fail + 1))
|
||||
fi
|
||||
;;
|
||||
full)
|
||||
local target="$dot"
|
||||
[[ -f "$toml" ]] && target="$toml"
|
||||
if "$ARC" run start "$target" --auto-approve 2>&1; then
|
||||
dry-run|haiku|full)
|
||||
# cd into the dot file's directory so relative script paths resolve
|
||||
local target="$dot_name"
|
||||
[[ -f "$toml" ]] && target="run-${stem}.toml"
|
||||
|
||||
local flags=(--auto-approve)
|
||||
[[ "$PHASE" == "dry-run" ]] && flags+=(--dry-run)
|
||||
[[ "$PHASE" == "haiku" ]] && flags+=(--model claude-haiku-4-5)
|
||||
|
||||
if (cd "$dot_dir" && "$ARC" run start "$target" "${flags[@]}" 2>&1); then
|
||||
echo " PASS $rel"
|
||||
pass=$((pass + 1))
|
||||
else
|
||||
|
|
|
|||
|
|
@ -42,7 +42,7 @@ digraph TransitionPatterns {
|
|||
start -> plan -> review
|
||||
|
||||
review -> fix [label="Fix"]
|
||||
review -> gate [label="Approve"]
|
||||
review -> gate [label="Approve", weight=10]
|
||||
|
||||
fix -> review
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue