scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-11 22:53:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

simplify: deduplicate preflight perm_details, remove unnecessary github_app clone

Browse source
This commit is contained in:
Claude 2026-03-15 19:27:08 +00:00
parent 420133d04c
commit 9f8046c5b6
1 changed files with 9 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
lib/crates/fabro-workflows/src/cli/run.rs
View file

@ -2077,7 +2077,6 @@ async fn run_preflight(
let exe_config = resolve_exe_config(run_cfg.as_ref(), run_defaults);
let ssh_config = resolve_ssh_config(run_cfg.as_ref(), run_defaults);
let github_app_for_preflight = github_app.clone();
let sandbox_result: Result<Arc<dyn Sandbox>, String> = match sandbox_provider {
SandboxProvider::Docker => {
let config = DockerSandboxConfig {
@ -2094,7 +2093,7 @@ async fn run_preflight(
let env = crate::daytona_sandbox::DaytonaSandbox::new(
daytona_client,
config,
github_app,
github_app.clone(),
None,
None,
);
@ -2270,7 +2269,12 @@ async fn run_preflight(
.or(run_defaults.github.as_ref());
if let Some(gh_cfg) = github_permissions {
if !gh_cfg.permissions.is_empty() {
match (&github_app_for_preflight, origin_url) {
let perm_details: Vec<CheckDetail> = gh_cfg
.permissions
.iter()
.map(|(k, v)| CheckDetail::new(format!("{k}: {v}")))
.collect();
match (&github_app, origin_url) {
(Some(creds), Some(url)) => {
match mint_github_token(creds, url, &gh_cfg.permissions).await {
Ok(_) => {
@ -2278,11 +2282,7 @@ async fn run_preflight(
name: "GitHub Token".into(),
status: CheckStatus::Pass,
summary: "minted".into(),
details: gh_cfg
.permissions
.iter()
.map(|(k, v)| CheckDetail::new(format!("{k}: {v}")))
.collect(),
details: perm_details,
remediation: None,
});
}
@ -2291,11 +2291,7 @@ async fn run_preflight(
name: "GitHub Token".into(),
status: CheckStatus::Error,
summary: "failed".into(),
details: gh_cfg
.permissions
.iter()
.map(|(k, v)| CheckDetail::new(format!("{k}: {v}")))
.collect(),
details: perm_details,
remediation: Some(format!("Failed to mint GitHub token: {e}")),
});
}