scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-08 03:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(llm): round-trip OpenAI reasoning statelessly

Browse source 
Always request encrypted reasoning content for Responses API requests with store:false so GPT-5.5 reasoning items can be sent back on later turns without relying on server-side item persistence.
This commit is contained in:
Bryan Helmkamp 2026-05-08 08:07:32 -07:00
parent b75ebbf4da
commit 9c80d38db5
No known key found for this signature in database
1 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
lib/crates/fabro-llm/src/providers/openai.rs
View file

@ -462,11 +462,7 @@ async fn build_api_request(request: &Request, stream: bool, codex_mode: bool) ->
.as_ref()
.and_then(translate_response_format);
let include = if reasoning.is_some() {
vec!["reasoning.encrypted_content".to_string()]
} else {
Vec::new()
};
let include = vec!["reasoning.encrypted_content".to_string()];
let instructions = if codex_mode {
Some(instructions.unwrap_or_default())
@ -491,10 +487,9 @@ async fn build_api_request(request: &Request, stream: bool, codex_mode: bool) ->
text,
stop: request.stop_sequences.clone(),
metadata: request.metadata.clone(),
// store: false is required for non-Azure OpenAI endpoints. Reasoning
// items still round-trip correctly because we request encrypted_content
// via the `include` field, which embeds them in the response payload
// rather than relying on server-side storage.
// store: false means output items are not persisted server-side.
// Request encrypted reasoning content on every turn so reasoning items
// from models that emit them by default can round-trip statelessly.
store: false,
include,
stream,
@ -1264,6 +1259,18 @@ mod tests {
assert!(body.get("stream").is_none());
}
#[tokio::test]
async fn build_request_body_includes_encrypted_reasoning_for_stateless_requests() {
let request = minimal_request();
let body = build_request_body(&request, false, false).await;
assert_eq!(
body["include"],
serde_json::json!(["reasoning.encrypted_content"])
);
}
#[tokio::test]
async fn build_request_body_stream_flag() {
let request = minimal_request();