scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-12 23:02:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Clean up server integration tests

Browse source 
Remove empty server.rs, redundant comments, redundant server.json
existence check (already covered by status check), unnecessary
String allocation, and unnecessary final filters.clone().

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-04-02 14:25:06 -07:00
parent 1847357d44
commit 9c42d375b2
No known key found for this signature in database
4 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/crates/fabro-cli/tests/it/cmd/mod.rs
View file

@ -51,7 +51,6 @@ mod secret_rm;
mod secret_set;
mod send_analytics;
mod send_panic;
mod server;
mod server_start;
mod server_status;
mod server_stop;

1
lib/crates/fabro-cli/tests/it/cmd/server.rs
View file

@ -1 +0,0 @@

3
lib/crates/fabro-cli/tests/it/cmd/server_start.rs
View file

@ -60,14 +60,12 @@ fn start_already_running_exits_with_error() {
let bind_addr = sock_dir.path().join("test.sock");
let bind_str = bind_addr.to_string_lossy().to_string();
// Start the daemon
context
.command()
.args(["server", "start", "--dry-run", "--bind", &bind_str])
.assert()
.success();
// Try to start again -- should fail with "already running"
let mut filters = context.filters();
filters.push((r"pid \d+".to_string(), "pid [PID]".to_string()));
filters.push((regex::escape(&bind_str), "[SOCKET_PATH]".to_string()));
@ -81,7 +79,6 @@ fn start_already_running_exits_with_error() {
error: Server already running (pid [PID]) on [SOCKET_PATH]
");
// Clean up: stop the server
context
.command()
.args(["server", "stop"])

19
lib/crates/fabro-cli/tests/it/scenario/server_lifecycle.rs
View file

@ -17,7 +17,6 @@ fn start_status_stop_lifecycle() {
"started [UPTIME] ago".to_string(),
));
// Start the server as a daemon with a Unix socket in a short path
let mut cmd = context.command();
cmd.args(["server", "start", "--dry-run", "--bind", &bind_str]);
fabro_snapshot!(filters.clone(), cmd, @"
@ -28,13 +27,6 @@ fn start_status_stop_lifecycle() {
Server started (pid [PID]) on [SOCKET_PATH]
");
// Verify server.json is written in storage_dir
assert!(
context.storage_dir.join("server.json").exists(),
"server.json should exist after start"
);
// Status should report running
let mut cmd = context.command();
cmd.args(["server", "status"]);
fabro_snapshot!(filters.clone(), cmd, @"
@ -45,22 +37,21 @@ fn start_status_stop_lifecycle() {
Server running (pid [PID]) on [SOCKET_PATH], started [UPTIME] ago
");
// Status --json should produce valid JSON with "running" status
let status_output = context
.command()
.args(["server", "status", "--json"])
.assert()
.success();
let stdout = String::from_utf8(status_output.get_output().stdout.clone()).unwrap();
let stdout = std::str::from_utf8(&status_output.get_output().stdout)
.expect("status --json stdout should be valid UTF-8");
let json: serde_json::Value =
serde_json::from_str(&stdout).expect("status --json should be valid JSON");
serde_json::from_str(stdout).expect("status --json should be valid JSON");
assert_eq!(
json["status"].as_str(),
Some("running"),
"status should be running"
);
// Stop the server
let mut cmd = context.command();
cmd.args(["server", "stop"]);
fabro_snapshot!(filters.clone(), cmd, @"
@ -71,10 +62,9 @@ fn start_status_stop_lifecycle() {
Server stopped
");
// Status should report not running
let mut cmd = context.command();
cmd.args(["server", "status"]);
fabro_snapshot!(filters.clone(), cmd, @"
fabro_snapshot!(filters, cmd, @"
success: false
exit_code: 1
----- stdout -----
@ -82,7 +72,6 @@ fn start_status_stop_lifecycle() {
Server is not running
");
// Verify server.json is cleaned up
assert!(
!context.storage_dir.join("server.json").exists(),
"server.json should be removed after stop"