scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-07 03:00:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fabro(01KTM9H228G0Z1ATDMZ10GGS4W): simplify_opus (succeeded)

Browse source 
Fabro-Run: 01KTM9H228G0Z1ATDMZ10GGS4W
Fabro-Completed: 6
Fabro-Checkpoint: e578d9877e

⚒️ Generated with [Fabro](https://fabro.sh)
This commit is contained in:
Fabro 2026-06-08 20:53:31 +00:00
parent 01c9960461
commit 95882b8c5e
11 changed files with 42 additions and 97 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
apps/fabro-web/app/components/run-summary-panel.test.tsx
View file

@ -6,6 +6,7 @@ import {
RunSummaryPanelView,
type RunSummaryPanelViewProps,
} from "./run-summary-panel";
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
function instanceText(instance: TestRenderer.ReactTestInstance): string {
const parts: string[] = [];
@ -34,14 +35,6 @@ function render(props: Partial<RunSummaryPanelViewProps> = {}) {
return tree!;
}
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
function cellAfterLabel(
tree: TestRenderer.ReactTestRenderer,
label: string,
@ -79,9 +72,8 @@ describe("RunSummaryPanelView", () => {
}
});
test("shows unavailable copy for missing optional run fields after load", () => {
test("shows unavailable copy for missing run fields after load", () => {
const tree = render({ run: makeRun() });
expect(instanceText(cellAfterLabel(tree, "Created by"))).toBe("Ttest");
expect(instanceText(cellAfterLabel(tree, "Changes"))).toBe(EMPTY_VALUE);
expect(instanceText(cellAfterLabel(tree, "Cost"))).toBe(EMPTY_VALUE);
});

12
apps/fabro-web/app/components/runs-list/run-table-row.tsx
View file

@ -35,6 +35,7 @@ export function RunTableRow({
}) {
const lifecycleLabel = listLifecycleStatusLabel(run);
const statusDisplay = columnStatusDisplay[run.status];
const createdByDisplay = principalDisplay(run.createdBy);
const show = (col: ToggleableColumn) => !hiddenColumns.has(col);
return (
@ -54,14 +55,9 @@ export function RunTableRow({
</td>
{show("created_by") && (
<td className="relative z-10 w-8 whitespace-nowrap px-3 py-2.5">
{(() => {
const display = principalDisplay(run.createdBy);
return (
<Tooltip label={display.label}>
<span aria-label={`Created by ${display.label}`}>{display.glyph}</span>
</Tooltip>
);
})()}
<Tooltip label={createdByDisplay.label}>
<span aria-label={`Created by ${createdByDisplay.label}`}>{createdByDisplay.glyph}</span>
</Tooltip>
</td>
)}
{show("repo") && (

9
apps/fabro-web/app/data/runs.test.ts
View file

@ -8,14 +8,7 @@ import {
mapRunToRunItem,
runStatusDisplay,
} from "./runs";
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
function makeRun(overrides: Partial<Run> = {}): Run {
return {

10
apps/fabro-web/app/lib/run-actions.test.ts
View file

@ -37,15 +37,9 @@ type CapturedRequest = {
data?: unknown;
};
const originalAdapter = generatedAxios.defaults.adapter;
import { TEST_PRINCIPAL } from "./test-fixtures";
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
const originalAdapter = generatedAxios.defaults.adapter;
function makeRun(status: RunStatus, archived = false): Run {
return {

12
apps/fabro-web/app/lib/test-fixtures.ts Normal file
View file

@ -0,0 +1,12 @@
import type { Principal } from "@qltysh/fabro-api-client";
/**
* Shared frontend test fixture mirroring `fabro_types::test_support::test_principal()`.
*/
export const TEST_PRINCIPAL: Principal = {
kind: "user",
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token",
avatar_url: null,
};

9
apps/fabro-web/app/routes/automations-new.test.tsx
View file

@ -5,6 +5,7 @@ import { createMemoryRouter, RouterProvider } from "react-router";
import { ToastProvider } from "../components/toast";
import { setupReactTestEnv } from "../lib/test-utils";
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
let currentRun: any = null;
let currentRunError: unknown = null;
@ -101,14 +102,6 @@ mock.module("swr", () => ({
const { default: AutomationsNew } = await import("./automations-new");
mock.restore();
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
function makeRun(overrides: Record<string, unknown> = {}) {
return {
id: "run_1",

9
apps/fabro-web/app/routes/run-detail.test.ts
View file

@ -13,6 +13,7 @@ import {
import { ToastProvider } from "../components/toast";
import { DemoModeProvider } from "../lib/demo-mode";
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
let currentRunSummary: any = null;
let currentRunState: any = null;
@ -20,14 +21,6 @@ let currentQuestions: any[] = [];
let deleteRunApiResult: Promise<unknown> | null = null;
const mountedRenderers: TestRenderer.ReactTestRenderer[] = [];
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
const deleteRunApiMock = mock((_id: string) =>
deleteRunApiResult ?? Promise.resolve({}),
);

9
apps/fabro-web/app/routes/run-files.render.test.tsx
View file

@ -5,6 +5,7 @@ import { MemoryRouter, Route, Routes } from "react-router";
import { toast as sonnerToast } from "sonner";
import { ToastProvider } from "../components/toast";
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
let currentFilesPayload: any = null;
let currentCommitsPayload: any = null;
@ -18,14 +19,6 @@ const virtualizerCalls: any[] = [];
const providerCalls: any[] = [];
const mountedRenderers: TestRenderer.ReactTestRenderer[] = [];
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
mock.module("@pierre/diffs/react", () => ({
MultiFileDiff: (props: any) => {
multiFileDiffCalls.push(props);

9
apps/fabro-web/app/routes/runs.preferences.test.tsx
View file

@ -6,14 +6,7 @@ import type { PaginatedRunList, Run } from "@qltysh/fabro-api-client";
import { ToastProvider } from "../components/toast";
import { CHILD_RUNS_LIST_PREFERENCES_STORAGE_KEY } from "../components/runs-list/preferences";
import { setupReactTestEnv } from "../lib/test-utils";
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
class MemoryStorage {
values = new Map<string, string>();

9
apps/fabro-web/app/routes/runs.test.tsx
View file

@ -11,14 +11,7 @@ import {
shouldRefreshBoardForEvent,
} from "./runs";
import { summarizeBatchLifecycleAction } from "../components/runs-list/batch-lifecycle";
const TEST_PRINCIPAL = {
kind: "user" as const,
identity: { issuer: "fabro:test", subject: "test-user" },
login: "test",
auth_method: "dev_token" as const,
avatar_url: null,
};
import { TEST_PRINCIPAL } from "../lib/test-fixtures";
function boardRun(id: string, column: BoardColumn, questionText?: string): Run {
const status =

39
lib/crates/fabro-store/src/run_state.rs
View file

@ -1443,7 +1443,8 @@ mod tests {
"settings": WorkflowSettings::default(),
"graph": Graph::new("test"),
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
);
@ -1471,7 +1472,8 @@ mod tests {
"graph": Graph::new("test"),
"automation": automation,
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
);
@ -1494,7 +1496,8 @@ mod tests {
"settings": WorkflowSettings::default(),
"graph": Graph::new("test"),
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
)])
@ -1516,7 +1519,8 @@ mod tests {
"settings": WorkflowSettings::default(),
"graph": Graph::new("test"),
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
)])
@ -1593,7 +1597,8 @@ mod tests {
"settings": WorkflowSettings::default(),
"graph": Graph::new("test"),
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
),
@ -1640,7 +1645,6 @@ mod tests {
properties: &serde_json::Value,
node_id: Option<&str>,
) -> EventEnvelope {
let properties = run_created_properties(event, properties);
EventEnvelope {
seq,
event: RunEvent::from_value(json!({
@ -1662,7 +1666,6 @@ mod tests {
properties: &serde_json::Value,
node_id: Option<&str>,
) -> EventEnvelope {
let properties = run_created_properties(event, properties);
EventEnvelope {
seq,
event: RunEvent::from_value(json!({
@ -1677,19 +1680,6 @@ mod tests {
}
}
fn run_created_properties(event: &str, properties: &serde_json::Value) -> serde_json::Value {
let mut properties = properties.clone();
if event == "run.created" && properties.get("provenance").is_none() {
if let Some(object) = properties.as_object_mut() {
object.insert(
"provenance".to_string(),
serde_json::to_value(test_support::test_run_provenance()).unwrap(),
);
}
}
properties
}
#[test]
fn live_run_timing_returns_none_before_run_starts() {
let state = initialized_projection();
@ -2927,7 +2917,8 @@ mod tests {
"attrs": { "goal": { "String": "Goal title" } }
},
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
);
@ -2954,7 +2945,8 @@ mod tests {
"attrs": { "goal": { "String": "## Plan: Legacy title\n\nDetails" } }
},
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
);
@ -2983,7 +2975,8 @@ mod tests {
"attrs": { "goal": { "String": "Goal title" } }
},
"labels": {},
"run_dir": "/tmp/run"
"run_dir": "/tmp/run",
"provenance": test_support::test_run_provenance()
}),
None,
),