mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-10-10 03:30:59 +00:00
parent
b0cfd8543e
commit
8dc421d824
5 changed files with 458 additions and 147 deletions
547
run.json
547
run.json
File diff suppressed because one or more lines are too long
31
stages/007-simplify_gpt@1/diff.patch
Normal file
31
stages/007-simplify_gpt@1/diff.patch
Normal file
|
|
@ -0,0 +1,31 @@
|
|||
diff --git a/lib/crates/fabro-workflow/src/handler/structured_output.rs b/lib/crates/fabro-workflow/src/handler/structured_output.rs
|
||||
index 855d6e456..546124b43 100644
|
||||
--- a/lib/crates/fabro-workflow/src/handler/structured_output.rs
|
||||
+++ b/lib/crates/fabro-workflow/src/handler/structured_output.rs
|
||||
@@ -18,6 +18,14 @@ pub(crate) const ROUTING_STATUS_FIELDS: &[&str] = &[
|
||||
"context_updates",
|
||||
];
|
||||
|
||||
+const QUOTED_ROUTING_STATUS_FIELDS: &[&str] = &[
|
||||
+ "\"preferred_next_label\"",
|
||||
+ "\"outcome\"",
|
||||
+ "\"failure_reason\"",
|
||||
+ "\"suggested_next_ids\"",
|
||||
+ "\"context_updates\"",
|
||||
+];
|
||||
+
|
||||
/// Parsed `output_schema` declaration with a precompiled validator so that
|
||||
/// repair turns don't recompile the schema on every iteration.
|
||||
#[derive(Debug, Clone)]
|
||||
@@ -358,9 +366,9 @@ fn contains_routing_field(obj: &serde_json::Map<String, Value>) -> bool {
|
||||
}
|
||||
|
||||
fn raw_mentions_routing_field(candidate: &str) -> bool {
|
||||
- ROUTING_STATUS_FIELDS
|
||||
+ QUOTED_ROUTING_STATUS_FIELDS
|
||||
.iter()
|
||||
- .any(|field| candidate.contains(&format!("\"{field}\"")))
|
||||
+ .any(|quoted_field| candidate.contains(quoted_field))
|
||||
}
|
||||
|
||||
fn routing_validator() -> &'static Validator {
|
||||
16
stages/007-simplify_gpt@1/response.md
Normal file
16
stages/007-simplify_gpt@1/response.md
Normal file
|
|
@ -0,0 +1,16 @@
|
|||
Implemented one cleanup from the simplify review:
|
||||
|
||||
- Optimized routing-field raw text detection in `structured_output.rs` by replacing per-check `format!("\"{field}\"")` allocations with a static quoted-field list.
|
||||
|
||||
No other actionable reuse/quality/efficiency issues were found during the review pass.
|
||||
|
||||
Validation run:
|
||||
|
||||
- `cargo nextest run -p fabro-workflow structured_output handler::agent handler::prompt handler::llm::api handler::llm::acp` ✅
|
||||
- `cargo nextest run -p fabro-workflow` ✅ 1160 passed
|
||||
- `cargo +nightly-2026-04-14 fmt --check --all` ✅
|
||||
- `cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings` ✅
|
||||
|
||||
Changed file:
|
||||
|
||||
- `lib/crates/fabro-workflow/src/handler/structured_output.rs`
|
||||
6
stages/007-simplify_gpt@1/status.json
Normal file
6
stages/007-simplify_gpt@1/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"outcome": "succeeded",
|
||||
"notes": "Stage completed: simplify_gpt",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-23T20:46:05.706573Z"
|
||||
}
|
||||
5
stages/008-verify@1/script_invocation.json
Normal file
5
stages/008-verify@1/script_invocation.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"script": "git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
|
||||
"command": "exec 2>&1\ngit fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
|
||||
"language": "shell"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue