From 8b250019851638de756f9a1940fe8dcf90141dcb Mon Sep 17 00:00:00 2001 From: Christophe de Carvalho Date: Tue, 4 Aug 2026 16:43:42 +0100 Subject: [PATCH] fix(cli): raise doctor health check timeout to 1s 250ms was too aggressive: a server that was reachable but slightly slow to answer /health made `fabro doctor` report a failed health check. Co-Authored-By: Claude Opus 5 --- lib/apps/fabro-cli/src/server_client.rs | 2 +- lib/foundation/fabro-client/src/client.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/apps/fabro-cli/src/server_client.rs b/lib/apps/fabro-cli/src/server_client.rs index 22cca5647..0d20ac36d 100644 --- a/lib/apps/fabro-cli/src/server_client.rs +++ b/lib/apps/fabro-cli/src/server_client.rs @@ -443,7 +443,7 @@ mod tests { let target = ServerTarget::http_url(format!("http://{addr}")).unwrap(); let client = connect_target_api_client_bundle(&target).await.unwrap(); - let result = time::timeout(Duration::from_millis(750), client.get_health()).await; + let result = time::timeout(Duration::from_secs(5), client.get_health()).await; server.abort(); assert!( diff --git a/lib/foundation/fabro-client/src/client.rs b/lib/foundation/fabro-client/src/client.rs index 24a7fd0c9..794cba86a 100644 --- a/lib/foundation/fabro-client/src/client.rs +++ b/lib/foundation/fabro-client/src/client.rs @@ -37,7 +37,7 @@ use crate::{AuthEntry, OAuthEntry, StoredSubject, sse}; const DEFAULT_CONTROL_PLANE_REQUEST_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30); -const DEFAULT_HEALTH_REQUEST_TIMEOUT: std::time::Duration = std::time::Duration::from_millis(250); +const DEFAULT_HEALTH_REQUEST_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(1); type TransportFuture = BoxFuture<'static, Result<(fabro_http::HttpClient, String)>>;