checkpoint

⚒️ Generated with [Fabro](https://fabro.sh)
This commit is contained in:
Fabro 2026-05-25 15:09:38 -04:00
parent 911da274b3
commit 8afbf68222
5 changed files with 406 additions and 19 deletions

343
run.json

File diff suppressed because one or more lines are too long

View file

@ -0,0 +1,70 @@
diff --git a/apps/fabro-web/app/components/stage-insights-sidebar.test.tsx b/apps/fabro-web/app/components/stage-insights-sidebar.test.tsx
index 713f1b4bc..87a6b5360 100644
--- a/apps/fabro-web/app/components/stage-insights-sidebar.test.tsx
+++ b/apps/fabro-web/app/components/stage-insights-sidebar.test.tsx
@@ -5,7 +5,6 @@ import { MemoryRouter } from "react-router";
import {
AgentToolCategory,
AgentSkillActivationSource,
- PermissionLevel,
StageContextWindowCategory,
StageContextWindowCountMethod,
StageContextWindowStaleness,
@@ -148,17 +147,7 @@ describe("StageInsightsSidebar", () => {
expect(dom).not.toContain("31%");
});
- test("renders permission badge for read-only", () => {
- const dom = render(makeStage({ permission_level: PermissionLevel.READ_ONLY }), null);
- expect(dom).toContain("Read-only");
- });
-
- test("renders permission badge for full access", () => {
- const dom = render(makeStage({ permission_level: PermissionLevel.FULL }), null);
- expect(dom).toContain("Full access");
- });
-
- test("renders projected agent tool names, descriptions, categories, and invoked state", () => {
+ test("renders projected agent tool names and invoked state", () => {
const dom = render(
makeStage({
agent_tools: [
@@ -177,29 +166,17 @@ describe("StageInsightsSidebar", () => {
invoked: false,
},
],
- permission_level: PermissionLevel.FULL,
}),
null,
);
expect(dom).toContain("1/2");
expect(dom).toContain("apply_patch");
+ // Description is exposed via the `title` attribute (tooltip) on each row.
expect(dom).toContain("Apply a unified diff patch");
- expect(dom).toContain("write");
- expect(dom).toContain("used");
+ expect(dom).toContain("Used");
expect(dom).toContain("grep");
expect(dom).toContain("Search file contents");
- expect(dom).toContain("read");
- expect(dom).toContain("available");
- // Permission remains secondary compatibility metadata, not the source of
- // the tool list.
- expect(dom).toContain("Full access");
- });
-
- test("legacy stages without agent tools keep permission fallback only", () => {
- const dom = render(makeStage({ permission_level: PermissionLevel.READ_WRITE }), null);
- expect(dom).toContain("Read/write");
- expect(dom).not.toContain("apply_patch");
});
test("renders mcp server used/total count, marks invoked servers as 'used'", () => {
@@ -266,6 +243,5 @@ describe("StageInsightsSidebar", () => {
const dom = render(undefined, null);
// sidebar still renders even with no data
expect(dom).toContain("Agent");
- expect(dom).toContain("Unknown");
});
});

View file

@ -0,0 +1 @@
Tests pass. The fix aligned the test file with the upstream simplification: removed the dropped permission badge tests, trimmed the projected-tools test to drop assertions for the removed category/source labels (keeping only name, count, description-as-tooltip, and the "Used" aria-label), and dropped the "Unknown" assertion from the empty state test since the simplified sidebar no longer renders it.

View file

@ -0,0 +1,6 @@
{
"outcome": "succeeded",
"notes": "Stage completed: fixup",
"failure_reason": null,
"timestamp": "2026-05-25T18:59:33.650332Z"
}

View file

@ -0,0 +1,5 @@
{
"script": "git fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
"command": "exec 2>&1\ngit fetch origin main 2>&1 && git merge --no-edit --no-stat origin/main 2>&1 && cargo +nightly-2026-04-14 fmt --all 2>&1 && cargo dev docs refresh 2>&1 && cargo +nightly-2026-04-14 fmt --check --all 2>&1 && { command -v rg >/dev/null 2>&1 || { echo 'rg is required for verify'; exit 127; }; } && ! rg -n 'AuthMode::Disabled|RunAuthMethod|RunSubjectProvenance|\\bActorRef\\b|\\bActorKind\\b|AuthenticatedSubject|AuthenticatedService|AuthorizeRunScoped|AuthorizeRunBlob|AuthorizeStageArtifact|AuthorizeCommandLog|auth_method\\s*==\\s*\"disabled\"' lib/crates apps lib/packages docs/public/api-reference/fabro-api.yaml 2>&1 && cargo +nightly-2026-04-14 clippy --workspace --all-targets -- -D warnings 2>&1 && cargo nextest run --workspace --status-level slow --profile ci 2>&1 && cargo dev docs check 2>&1 && bun install --frozen-lockfile 2>&1 && (cd apps/fabro-web && bun run typecheck) 2>&1 && (cd apps/fabro-web && bun run test) 2>&1 && (cd lib/packages/fabro-api-client && bun run typecheck) 2>&1 && cargo dev build -- -p fabro-cli --release 2>&1",
"language": "shell"
}