diff --git a/run.json b/run.json index 69cb0e294..02421e960 100644 --- a/run.json +++ b/run.json @@ -517,7 +517,7 @@ "kind": "running" }, "status_updated_at": "2026-05-22T18:56:04.773364Z", - "last_event_at": "2026-05-22T18:58:23.849475Z", + "last_event_at": "2026-05-22T19:24:58.743320Z", "pending_control": null, "checkpoints": [ { @@ -684,9 +684,9 @@ } }, { - "seq": 0, + "seq": 48, "checkpoint": { - "timestamp": "2026-05-22T19:00:39.389387Z", + "timestamp": "2026-05-22T19:00:45.204566Z", "current_node": "preflight_lint", "completed_nodes": [ "start", @@ -696,9 +696,93 @@ ], "node_retries": {}, "context_values": { + "internal.retry_count.toolchain": 0, + "internal.node_visit_count": 1, + "internal.fidelity": "compact", "internal.thread_id": "preflight_compile", + "graph.goal": "---\ntitle: Add run.checkpoint.skip_git_hooks\ntype: feat\nstatus: active\ndate: 2026-05-22\n---\n\n# Add `run.checkpoint.skip_git_hooks`\n\n## Summary\n\nAdd an opt-in setting:\n\n```toml\n[run.checkpoint]\nskip_git_hooks = true\n```\n\nWhen enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.\n\n## Key Changes\n\n- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.\n- Add `skip_git_hooks: Option` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.\n- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.\n- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.\n- Thread the resolved setting into run-branch checkpoint commit creation.\n- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:\n - normal lifecycle checkpoint commits in `sandbox_git.rs`\n - parallel base checkpoint commits through the same helper\n - parallel branch worktree commits in `handler/parallel.rs`\n- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.\n- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.\n\n## Test Plan\n\n- `fabro-config` tests:\n - `[run.checkpoint] skip_git_hooks = true` resolves to `true`.\n - omitted `skip_git_hooks` resolves to `false`.\n - higher-layer `skip_git_hooks = false` overrides lower-layer `true`.\n - `exclude_globs` merging behavior remains unchanged.\n- `fabro-workflow` tests:\n - checkpoint commit command includes the hook-skip option when enabled.\n - checkpoint commit command omits it when disabled.\n - parallel branch commit command respects the setting.\n- API/client tests:\n - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.\n - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.\n- Regression:\n - existing git checkpoint tests still pass, including metadata branch tests.\n\n## Assumptions\n\n- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.\n- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.\n- Default `false` is required for backward compatibility.\n", + "current_node": "preflight_lint", + "graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ", "graph.rankdir": "LR", + "internal.work_dir": "/home/daytona/workspace/fabro", + "command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126", "thread.preflight_compile.current_node": "preflight_lint", + "thread.toolchain.current_node": "preflight_compile", + "internal.retry_count.start": 0, + "outcome": "succeeded", + "internal.run_id": "01KS8GPB6C00GQ6G5A05S9AAC8", + "internal.retry_count.preflight_lint": 0, + "thread.start.current_node": "toolchain", + "failure_signature": "", + "internal.retry_count.preflight_compile": 0, + "failure_class": "" + }, + "node_outcomes": { + "preflight_lint": { + "status": "succeeded", + "context_updates": { + "command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126" + }, + "notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", + "usage": null + }, + "start": { + "status": "succeeded", + "usage": null + }, + "toolchain": { + "status": "succeeded", + "context_updates": { + "command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c" + }, + "notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1", + "usage": null + }, + "preflight_compile": { + "status": "succeeded", + "context_updates": { + "command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126" + }, + "notes": "Script completed: cargo check -q --workspace 2>&1", + "usage": null + } + }, + "next_node_id": "implement", + "git_commit_sha": "8de736302dc08cd679fdb6f546fc4283333ef8ee", + "node_visits": { + "preflight_compile": 1, + "toolchain": 1, + "preflight_lint": 1, + "start": 1 + } + }, + "diff": { + "summary": { + "files_changed": 0, + "additions": 0, + "deletions": 0 + } + } + }, + { + "seq": 0, + "checkpoint": { + "timestamp": "2026-05-22T19:24:58.870152Z", + "current_node": "implement", + "completed_nodes": [ + "start", + "toolchain", + "preflight_compile", + "preflight_lint", + "implement" + ], + "node_retries": {}, + "context_values": { + "internal.thread_id": "preflight_lint", + "graph.rankdir": "LR", + "last_response": "All green. Here's a summary of the changes implemented per the plan:\n\n## Summary\n\n**Types & config (`fabro-types`, `fabro-config`)**\n- `RunCheckpointSettings`: added `skip_git_hooks: bool` (defaults t", + "thread.preflight_compile.current_node": "preflight_lint", + "last_stage": "implement", "thread.start.current_node": "toolchain", "outcome": "succeeded", "internal.run_id": "01KS8GPB6C00GQ6G5A05S9AAC8", @@ -706,16 +790,19 @@ "internal.retry_count.preflight_compile": 0, "internal.work_dir": "/home/daytona/workspace/fabro", "internal.node_visit_count": 1, + "thread.preflight_lint.current_node": "implement", + "response.implement": "All green. Here's a summary of the changes implemented per the plan:\n\n## Summary\n\n**Types & config (`fabro-types`, `fabro-config`)**\n- `RunCheckpointSettings`: added `skip_git_hooks: bool` (defaults to `false`).\n- `RunCheckpointLayer`: added `skip_git_hooks: Option` (sparse, distinguishes unset from explicit `false`).\n- `Combine for RunCheckpointLayer`: `exclude_globs` keeps replace/inherit semantics; `skip_git_hooks` uses normal option-override semantics.\n- `resolve_checkpoint`: missing config now resolves `skip_git_hooks = false`.\n\n**Workflow engine (`fabro-workflow`)**\n- `GitState.checkpoint_skip_hooks` field threaded through `pipeline/execute.rs` and `RunOptions::checkpoint_skip_git_hooks()`.\n- `git_checkpoint` / `checked_git_checkpoint`: new `skip_git_hooks: bool` parameter that appends ` --no-verify` to the `git commit` command when `true`.\n- `lifecycle/git.rs` lifecycle checkpoint path threads the resolved setting through.\n- `handler/parallel.rs`: both the parallel-base checkpoint (via `checked_git_checkpoint`) and the per-branch worktree commit respect the setting; extracted `parallel_branch_commit_cmd` helper for testability.\n\n**OpenAPI / clients**\n- `docs/public/api-reference/fabro-api.yaml` `RunCheckpointSettings`: added `skip_git_hooks: boolean` (required).\n- `lib/packages/fabro-api-client/src/models/run-checkpoint-settings.ts`: regenerated with the new field.\n\n**Docs**\n- `docs/public/execution/run-configuration.mdx`: documents `skip_git_hooks`, default `false`, that it doesn't disable `[[run.hooks]]`.\n- `docs/public/administration/server-configuration.mdx`: same.\n\n**Tests added (TDD: red → green for each)**\n- `fabro-config` (`tests::resolve_run::run_checkpoint_skip_git_hooks::*`): 4 tests — `true` resolves, default `false`, higher-layer `false` overrides lower `true`, and `exclude_globs` replace behavior is preserved when only `skip_git_hooks` is set on a higher layer.\n- `fabro-workflow` (`sandbox_git::tests::*`): 2 new tests — checkpoint commit includes `--no-verify` when enabled, omits when disabled.\n- `fabro-workflow` (`handler::parallel::tests::*`): 2 new tests covering the parallel-branch commit command builder.\n- `fabro-api` (`workflow_settings_round_trip.rs`): JSON round-trip includes `skip_git_hooks`, defaults to `false`.\n\n**Snapshot updates**\n- `lib/crates/fabro-cli/tests/it/cmd/attach.rs` and `inspect.rs` inline JSON updated to include `\"skip_git_hooks\": false`.\n\nFinal status: workspace `cargo nextest run` → 6067 passed, clippy clean, fmt clean.", "failure_class": "", "command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126", - "current_node": "preflight_lint", + "current_node": "implement", "internal.retry_count.start": 0, "failure_signature": "", "internal.retry_count.toolchain": 0, "internal.retry_count.preflight_lint": 0, "graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ", "graph.goal": "---\ntitle: Add run.checkpoint.skip_git_hooks\ntype: feat\nstatus: active\ndate: 2026-05-22\n---\n\n# Add `run.checkpoint.skip_git_hooks`\n\n## Summary\n\nAdd an opt-in setting:\n\n```toml\n[run.checkpoint]\nskip_git_hooks = true\n```\n\nWhen enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.\n\n## Key Changes\n\n- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.\n- Add `skip_git_hooks: Option` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.\n- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.\n- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.\n- Thread the resolved setting into run-branch checkpoint commit creation.\n- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:\n - normal lifecycle checkpoint commits in `sandbox_git.rs`\n - parallel base checkpoint commits through the same helper\n - parallel branch worktree commits in `handler/parallel.rs`\n- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.\n- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.\n\n## Test Plan\n\n- `fabro-config` tests:\n - `[run.checkpoint] skip_git_hooks = true` resolves to `true`.\n - omitted `skip_git_hooks` resolves to `false`.\n - higher-layer `skip_git_hooks = false` overrides lower-layer `true`.\n - `exclude_globs` merging behavior remains unchanged.\n- `fabro-workflow` tests:\n - checkpoint commit command includes the hook-skip option when enabled.\n - checkpoint commit command omits it when disabled.\n - parallel branch commit command respects the setting.\n- API/client tests:\n - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.\n - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.\n- Regression:\n - existing git checkpoint tests still pass, including metadata branch tests.\n\n## Assumptions\n\n- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.\n- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.\n- Default `false` is required for backward compatibility.\n", - "internal.fidelity": "compact" + "internal.fidelity": "compact", + "internal.retry_count.implement": 0 }, "node_outcomes": { "preflight_compile": { @@ -730,6 +817,57 @@ "status": "succeeded", "usage": null }, + "implement": { + "status": "succeeded", + "context_updates": { + "last_response": "All green. Here's a summary of the changes implemented per the plan:\n\n## Summary\n\n**Types & config (`fabro-types`, `fabro-config`)**\n- `RunCheckpointSettings`: added `skip_git_hooks: bool` (defaults t", + "last_stage": "implement", + "response.implement": "All green. Here's a summary of the changes implemented per the plan:\n\n## Summary\n\n**Types & config (`fabro-types`, `fabro-config`)**\n- `RunCheckpointSettings`: added `skip_git_hooks: bool` (defaults to `false`).\n- `RunCheckpointLayer`: added `skip_git_hooks: Option` (sparse, distinguishes unset from explicit `false`).\n- `Combine for RunCheckpointLayer`: `exclude_globs` keeps replace/inherit semantics; `skip_git_hooks` uses normal option-override semantics.\n- `resolve_checkpoint`: missing config now resolves `skip_git_hooks = false`.\n\n**Workflow engine (`fabro-workflow`)**\n- `GitState.checkpoint_skip_hooks` field threaded through `pipeline/execute.rs` and `RunOptions::checkpoint_skip_git_hooks()`.\n- `git_checkpoint` / `checked_git_checkpoint`: new `skip_git_hooks: bool` parameter that appends ` --no-verify` to the `git commit` command when `true`.\n- `lifecycle/git.rs` lifecycle checkpoint path threads the resolved setting through.\n- `handler/parallel.rs`: both the parallel-base checkpoint (via `checked_git_checkpoint`) and the per-branch worktree commit respect the setting; extracted `parallel_branch_commit_cmd` helper for testability.\n\n**OpenAPI / clients**\n- `docs/public/api-reference/fabro-api.yaml` `RunCheckpointSettings`: added `skip_git_hooks: boolean` (required).\n- `lib/packages/fabro-api-client/src/models/run-checkpoint-settings.ts`: regenerated with the new field.\n\n**Docs**\n- `docs/public/execution/run-configuration.mdx`: documents `skip_git_hooks`, default `false`, that it doesn't disable `[[run.hooks]]`.\n- `docs/public/administration/server-configuration.mdx`: same.\n\n**Tests added (TDD: red → green for each)**\n- `fabro-config` (`tests::resolve_run::run_checkpoint_skip_git_hooks::*`): 4 tests — `true` resolves, default `false`, higher-layer `false` overrides lower `true`, and `exclude_globs` replace behavior is preserved when only `skip_git_hooks` is set on a higher layer.\n- `fabro-workflow` (`sandbox_git::tests::*`): 2 new tests — checkpoint commit includes `--no-verify` when enabled, omits when disabled.\n- `fabro-workflow` (`handler::parallel::tests::*`): 2 new tests covering the parallel-branch commit command builder.\n- `fabro-api` (`workflow_settings_round_trip.rs`): JSON round-trip includes `skip_git_hooks`, defaults to `false`.\n\n**Snapshot updates**\n- `lib/crates/fabro-cli/tests/it/cmd/attach.rs` and `inspect.rs` inline JSON updated to include `\"skip_git_hooks\": false`.\n\nFinal status: workspace `cargo nextest run` → 6067 passed, clippy clean, fmt clean." + }, + "notes": "Stage completed: implement", + "usage": { + "input": { + "usage": { + "model": { + "provider": "anthropic", + "model_id": "claude-opus-4-7" + }, + "tokens": { + "input_tokens": 150314, + "output_tokens": 39407, + "reasoning_tokens": 0, + "cache_read_tokens": 15271872, + "cache_write_tokens": 161266 + } + }, + "facts": { + "algorithm": "anthropic", + "cache_write_5m_tokens": 161266, + "cache_write_1h_tokens": 0 + } + }, + "total_usd_micros": 10380593 + }, + "files_touched": [ + "/home/daytona/workspace/fabro/docs/public/administration/server-configuration.mdx", + "/home/daytona/workspace/fabro/docs/public/api-reference/fabro-api.yaml", + "/home/daytona/workspace/fabro/docs/public/execution/run-configuration.mdx", + "/home/daytona/workspace/fabro/lib/crates/fabro-api/tests/workflow_settings_round_trip.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-cli/tests/it/cmd/attach.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-cli/tests/it/cmd/inspect.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-config/src/layers/combine.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-config/src/layers/run.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-config/src/resolve/run.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-config/src/tests/resolve_run.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-types/src/settings/run.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-workflow/src/handler/parallel.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-workflow/src/lifecycle/git.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-workflow/src/pipeline/execute.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-workflow/src/run_options.rs", + "/home/daytona/workspace/fabro/lib/crates/fabro-workflow/src/sandbox_git.rs", + "/home/daytona/workspace/fabro/lib/packages/fabro-api-client/src/models/run-checkpoint-settings.ts" + ] + }, "toolchain": { "status": "succeeded", "context_updates": { @@ -747,8 +885,9 @@ "usage": null } }, - "next_node_id": "implement", + "next_node_id": "simplify_opus", "node_visits": { + "implement": 1, "toolchain": 1, "start": 1, "preflight_lint": 1, @@ -831,7 +970,12 @@ "first_event_seq": 41, "prompt": null, "response": null, - "completion": null, + "completion": { + "outcome": "succeeded", + "notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", + "failure_reason": null, + "timestamp": "2026-05-22T19:00:39.388788Z" + }, "provider_used": null, "diff": null, "script_invocation": { @@ -839,11 +983,27 @@ "command": "exec 2>&1\ncargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", "language": "shell" }, - "script_timing": null, + "script_timing": { + "output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126", + "exit_code": 0, + "duration_ms": 135533, + "termination": "exited", + "output_bytes": 0, + "live_streaming": false + }, "parallel_results": null, "output": null, + "output_bytes": 0, + "live_streaming": false, + "termination": "exited", "started_at": "2026-05-22T18:58:23.848937Z", "handler": "command", + "timing": { + "wall_time_ms": 135538, + "inference_time_ms": 0, + "tool_time_ms": 0, + "active_time_ms": 0 + }, "usage": { "input_tokens": 0, "output_tokens": 0, @@ -852,7 +1012,7 @@ "cache_read_tokens": 0, "cache_write_tokens": 0 }, - "state": "running" + "state": "succeeded" }, "preflight_compile@1": { "first_event_seq": 30, @@ -935,6 +1095,38 @@ "cache_write_tokens": 0 }, "state": "succeeded" + }, + "implement@1": { + "first_event_seq": 51, + "prompt": null, + "response": null, + "completion": null, + "provider_used": { + "mode": "agent", + "provider": "anthropic", + "model": "claude-opus-4-7" + }, + "diff": null, + "script_invocation": null, + "script_timing": null, + "parallel_results": null, + "output": null, + "started_at": "2026-05-22T19:00:45.205970Z", + "handler": "agent", + "usage": { + "input_tokens": 150314, + "output_tokens": 39407, + "total_tokens": 15622859, + "reasoning_tokens": 0, + "cache_read_tokens": 15271872, + "cache_write_tokens": 161266, + "total_usd_micros": 10380593 + }, + "model": { + "provider": "anthropic", + "model_id": "claude-opus-4-7" + }, + "state": "running" } } } \ No newline at end of file diff --git a/stages/004-preflight_lint@1/output.log b/stages/004-preflight_lint@1/output.log new file mode 100644 index 000000000..d87ba9545 --- /dev/null +++ b/stages/004-preflight_lint@1/output.log @@ -0,0 +1 @@ +blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126 \ No newline at end of file diff --git a/stages/004-preflight_lint@1/script_timing.json b/stages/004-preflight_lint@1/script_timing.json new file mode 100644 index 000000000..b0e38ee48 --- /dev/null +++ b/stages/004-preflight_lint@1/script_timing.json @@ -0,0 +1,8 @@ +{ + "output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126", + "exit_code": 0, + "duration_ms": 135533, + "termination": "exited", + "output_bytes": 0, + "live_streaming": false +} \ No newline at end of file diff --git a/stages/004-preflight_lint@1/status.json b/stages/004-preflight_lint@1/status.json new file mode 100644 index 000000000..22c811dc8 --- /dev/null +++ b/stages/004-preflight_lint@1/status.json @@ -0,0 +1,6 @@ +{ + "outcome": "succeeded", + "notes": "Script completed: cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1", + "failure_reason": null, + "timestamp": "2026-05-22T19:00:39.388788Z" +} \ No newline at end of file diff --git a/stages/005-implement@1/prompt.md b/stages/005-implement@1/prompt.md new file mode 100644 index 000000000..39a1e4709 --- /dev/null +++ b/stages/005-implement@1/prompt.md @@ -0,0 +1,74 @@ +Goal: --- +title: Add run.checkpoint.skip_git_hooks +type: feat +status: active +date: 2026-05-22 +--- + +# Add `run.checkpoint.skip_git_hooks` + +## Summary + +Add an opt-in setting: + +```toml +[run.checkpoint] +skip_git_hooks = true +``` + +When enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots. + +## Key Changes + +- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`. +- Add `skip_git_hooks: Option` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`. +- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics. +- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`. +- Thread the resolved setting into run-branch checkpoint commit creation. +- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including: + - normal lifecycle checkpoint commits in `sandbox_git.rs` + - parallel base checkpoint commits through the same helper + - parallel branch worktree commits in `handler/parallel.rs` +- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field. +- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`. + +## Test Plan + +- `fabro-config` tests: + - `[run.checkpoint] skip_git_hooks = true` resolves to `true`. + - omitted `skip_git_hooks` resolves to `false`. + - higher-layer `skip_git_hooks = false` overrides lower-layer `true`. + - `exclude_globs` merging behavior remains unchanged. +- `fabro-workflow` tests: + - checkpoint commit command includes the hook-skip option when enabled. + - checkpoint commit command omits it when disabled. + - parallel branch commit command respects the setting. +- API/client tests: + - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`. + - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field. +- Regression: + - existing git checkpoint tests still pass, including metadata branch tests. + +## Assumptions + +- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks. +- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`. +- Default `false` is required for backward compatibility. + + +## Completed stages +- **toolchain**: succeeded + - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1` + - Output: + ``` + cargo 1.95.0 (f2d3ce0bd 2026-03-21) + ``` +- **preflight_compile**: succeeded + - Script: `cargo check -q --workspace 2>&1` + - Output: (empty) +- **preflight_lint**: succeeded + - Script: `cargo +nightly-2026-04-14 clippy -q --workspace --all-targets -- -D warnings 2>&1` + - Output: (empty) + + +Read the plan file referenced in the goal and implement every step. Make all the code changes described in the plan. Use red/green TDD. \ No newline at end of file diff --git a/stages/005-implement@1/provider_used.json b/stages/005-implement@1/provider_used.json new file mode 100644 index 000000000..672cc50e5 --- /dev/null +++ b/stages/005-implement@1/provider_used.json @@ -0,0 +1,5 @@ +{ + "mode": "agent", + "provider": "anthropic", + "model": "claude-opus-4-7" +} \ No newline at end of file diff --git a/stages/005-implement@1/response.md b/stages/005-implement@1/response.md new file mode 100644 index 000000000..c32a99d95 --- /dev/null +++ b/stages/005-implement@1/response.md @@ -0,0 +1,34 @@ +All green. Here's a summary of the changes implemented per the plan: + +## Summary + +**Types & config (`fabro-types`, `fabro-config`)** +- `RunCheckpointSettings`: added `skip_git_hooks: bool` (defaults to `false`). +- `RunCheckpointLayer`: added `skip_git_hooks: Option` (sparse, distinguishes unset from explicit `false`). +- `Combine for RunCheckpointLayer`: `exclude_globs` keeps replace/inherit semantics; `skip_git_hooks` uses normal option-override semantics. +- `resolve_checkpoint`: missing config now resolves `skip_git_hooks = false`. + +**Workflow engine (`fabro-workflow`)** +- `GitState.checkpoint_skip_hooks` field threaded through `pipeline/execute.rs` and `RunOptions::checkpoint_skip_git_hooks()`. +- `git_checkpoint` / `checked_git_checkpoint`: new `skip_git_hooks: bool` parameter that appends ` --no-verify` to the `git commit` command when `true`. +- `lifecycle/git.rs` lifecycle checkpoint path threads the resolved setting through. +- `handler/parallel.rs`: both the parallel-base checkpoint (via `checked_git_checkpoint`) and the per-branch worktree commit respect the setting; extracted `parallel_branch_commit_cmd` helper for testability. + +**OpenAPI / clients** +- `docs/public/api-reference/fabro-api.yaml` `RunCheckpointSettings`: added `skip_git_hooks: boolean` (required). +- `lib/packages/fabro-api-client/src/models/run-checkpoint-settings.ts`: regenerated with the new field. + +**Docs** +- `docs/public/execution/run-configuration.mdx`: documents `skip_git_hooks`, default `false`, that it doesn't disable `[[run.hooks]]`. +- `docs/public/administration/server-configuration.mdx`: same. + +**Tests added (TDD: red → green for each)** +- `fabro-config` (`tests::resolve_run::run_checkpoint_skip_git_hooks::*`): 4 tests — `true` resolves, default `false`, higher-layer `false` overrides lower `true`, and `exclude_globs` replace behavior is preserved when only `skip_git_hooks` is set on a higher layer. +- `fabro-workflow` (`sandbox_git::tests::*`): 2 new tests — checkpoint commit includes `--no-verify` when enabled, omits when disabled. +- `fabro-workflow` (`handler::parallel::tests::*`): 2 new tests covering the parallel-branch commit command builder. +- `fabro-api` (`workflow_settings_round_trip.rs`): JSON round-trip includes `skip_git_hooks`, defaults to `false`. + +**Snapshot updates** +- `lib/crates/fabro-cli/tests/it/cmd/attach.rs` and `inspect.rs` inline JSON updated to include `"skip_git_hooks": false`. + +Final status: workspace `cargo nextest run` → 6067 passed, clippy clean, fmt clean. \ No newline at end of file