From 855d73630bf6dd0c96229db0f4cc135b1867170d Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Mon, 25 May 2026 13:39:17 -0400 Subject: [PATCH] refactor(web): remove unused RunRow + RUNS_LIST_GRID_TEMPLATE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The grid-based RunRow was the only Children-tab consumer of the runs-list module's row primitive. When Children adopted the full RunsListView (table layout) in 4dfcbc0e0, RunRow became unused — the re-export in runs.tsx was preserved for a release as a precaution, but nothing imports it. Same for RUNS_LIST_GRID_TEMPLATE, which only the grid RunRow needed. Note: automation-runs.tsx still defines its own local RunRow with the same name; that one is unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../components/runs-list/run-table-row.tsx | 63 ------------------- apps/fabro-web/app/routes/runs.tsx | 1 - 2 files changed, 64 deletions(-) diff --git a/apps/fabro-web/app/components/runs-list/run-table-row.tsx b/apps/fabro-web/app/components/runs-list/run-table-row.tsx index 79f11ec47..52efd1152 100644 --- a/apps/fabro-web/app/components/runs-list/run-table-row.tsx +++ b/apps/fabro-web/app/components/runs-list/run-table-row.tsx @@ -9,8 +9,6 @@ import { RowActionsMenu } from "./row-actions-menu"; import { SelectionCheckbox } from "./selection-checkbox"; import type { ToggleableColumn } from "./toggleable-column"; -export const RUNS_LIST_GRID_TEMPLATE = "auto 5rem auto 1fr auto auto 8rem auto"; - function listLifecycleStatusLabel( run: Pick, ): string | null { @@ -21,67 +19,6 @@ function listLifecycleStatusLabel( return run.lifecycleStatusLabel; } -export function RunRow({ run }: { run: RunWithStatus }) { - const lifecycleLabel = listLifecycleStatusLabel(run); - const statusDisplay = columnStatusDisplay[run.status]; - - return ( -
- - - - - - {run.elapsed} - - - {run.repo} - - - - {lifecycleLabel != null && ( - - {lifecycleLabel} - - )} - {run.comments != null && run.comments > 0 && ( - - - {run.comments} - - )} - - - {run.workflow} - - - {run.createdAt != null ? formatRelativeTime(run.createdAt) : ""} - - - - {run.additions != null && +{run.additions.toLocaleString()}} - {run.deletions != null && -{run.deletions.toLocaleString()}} - - - - - {run.pullRequestUrl && run.number != null && ( - - {run.checks != null && } - - )} - -
- ); -} - export function RunTableRow({ run, hiddenColumns, diff --git a/apps/fabro-web/app/routes/runs.tsx b/apps/fabro-web/app/routes/runs.tsx index f34af3c37..d3c6e159b 100644 --- a/apps/fabro-web/app/routes/runs.tsx +++ b/apps/fabro-web/app/routes/runs.tsx @@ -73,7 +73,6 @@ export { RUNS_PREFERENCES_STORAGE_KEY, } from "../components/runs-list/preferences"; export { summarizeBatchLifecycleAction } from "../components/runs-list/bulk-action-toolbar"; -export { RUNS_LIST_GRID_TEMPLATE, RunRow } from "../components/runs-list/run-table-row"; export function meta({}: any) { return [{ title: "Runs — Fabro" }];