From 8345417db2c53bb99940f6919f42827b31f710c4 Mon Sep 17 00:00:00 2001 From: Fabro Date: Sun, 15 Mar 2026 22:00:24 -0400 Subject: [PATCH] checkpoint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ⚒️ Generated with [Fabro](https://fabro.sh) --- checkpoint.json | 32 +++++++++++++++------ nodes/preflight_lint/script_invocation.json | 5 ++++ nodes/preflight_lint/script_timing.json | 5 ++++ nodes/preflight_lint/status.json | 6 ++++ 4 files changed, 39 insertions(+), 9 deletions(-) create mode 100644 nodes/preflight_lint/script_invocation.json create mode 100644 nodes/preflight_lint/script_timing.json create mode 100644 nodes/preflight_lint/status.json diff --git a/checkpoint.json b/checkpoint.json index 301acca48..611340a09 100644 --- a/checkpoint.json +++ b/checkpoint.json @@ -1,33 +1,37 @@ { - "timestamp": "2026-03-16T02:00:05.443804Z", - "current_node": "preflight_compile", + "timestamp": "2026-03-16T02:00:24.568155Z", + "current_node": "preflight_lint", "completed_nodes": [ "start", "toolchain", - "preflight_compile" + "preflight_compile", + "preflight_lint" ], "node_retries": { - "toolchain": 1, + "preflight_lint": 1, "preflight_compile": 1, - "start": 1 + "start": 1, + "toolchain": 1 }, "context_values": { - "internal.thread_id": "toolchain", + "internal.thread_id": "preflight_compile", "internal.retry_count.start": 1, "thread.toolchain.current_node": "preflight_compile", - "current.preamble": "Goal: # Style SVG output from `fabro graph` and API\n\n## Context\n\nSVGs from `fabro graph` use raw Graphviz defaults (black strokes, white bg, Times-serif). The docs SVGs look much better: teal nodes, gray edges, Helvetica font, transparent bg, dark mode CSS. The goal is to make `fabro graph` and the API `get_graph` endpoint produce the same styled output without building a layout engine.\n\n## Approach: DOT defaults + SVG post-processing\n\n### Step 1: `inject_dot_style_defaults(source: &str) -> String` in `graph.rs`\n\nFind first `{`, insert after it:\n```dot\n bgcolor=\"transparent\"\n node [color=\"#357f9e\", fontname=\"Helvetica\", fontsize=12, fontcolor=\"#1a1a1a\"]\n edge [color=\"#666666\", fontname=\"Helvetica\", fontsize=10, fontcolor=\"#666666\"]\n```\nThese are DOT defaults — per-node/edge attrs override them. Applies to both SVG and PNG.\n\n### Step 2: `postprocess_svg(raw: Vec) -> Vec` in `graph.rs`\n\nSVG-only. Two string operations:\n1. Remove line containing `` block after the `` closing `>`\n\n### Step 3: Wire into `render_dot()` in `graph.rs`\n\n- Call `inject_dot_style_defaults` on source before piping to `dot`\n- Call `postprocess_svg` on output when format is SVG\n\n### Step 4: Wire into `get_graph()` in `server.rs` (line ~1440, ~1467, ~1472)\n\n- Wrap `dot_source` with `inject_dot_style_defaults`\n- Wrap `output.stdout` with `postprocess_svg`\n\n### Step 5: Wire into `get_run_graph()` in `demo/mod.rs` (line ~227, ~248, ~252)\n\nSame two wraps.\n\n### Step 6: Tests in `graph.rs`\n\n- `inject_dot_style_defaults` inserts expected attrs\n- `inject_dot_style_defaults` returns unchanged if no `{`\n- `postprocess_svg` removes white background\n- `postprocess_svg` injects dark mode style block\n- Update `graph_valid_workflow_svg` to assert styled output\n\n## Files to modify\n\n1. `lib/crates/fabro-workflows/src/cli/graph.rs` — add 2 pub fns, modify `render_dot`, add tests\n2. `lib/crates/fabro-api/src/server.rs` — 2-line change in `get_graph`\n3. `lib/crates/fabro-api/src/demo/mod.rs` — 2-line change in `get_run_graph`\n\n## Verification\n\n1. `cargo test -p fabro-workflows -- graph` — unit tests pass\n2. `cargo test -p fabro-api` — API tests pass\n3. `cargo clippy --workspace -- -D warnings` — no warnings\n4. `fabro graph fabro/workflows/implement/workflow.fabro -o /tmp/test.svg` — visually inspect:\n - Teal node strokes, gray edges, Helvetica font\n - No white background\n - Dark mode `