From 7a777ebf01d50967c8f677949f5e6c0ab8f0d8a2 Mon Sep 17 00:00:00 2001
From: Bryan Helmkamp <bryan@brynary.com>
Date: Mon, 30 Mar 2026 09:09:06 -0400
Subject: [PATCH] Convert serve help test to fabro_snapshot and delete orphaned
 snap file

Replace ad-hoc insta::assert_snapshot! with TestContext + fabro_snapshot!
for consistency. Delete the orphaned snapshot file from the deleted
cli.rs module.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 lib/crates/fabro-cli/tests/it/cmd/serve.rs    | 13 +++---
 .../it/snapshots/it__cli__serve_help.snap     | 40 -------------------
 2 files changed, 6 insertions(+), 47 deletions(-)
 delete mode 100644 lib/crates/fabro-cli/tests/it/snapshots/it__cli__serve_help.snap

diff --git a/lib/crates/fabro-cli/tests/it/cmd/serve.rs b/lib/crates/fabro-cli/tests/it/cmd/serve.rs
index e37b348ff..f562ec195 100644
--- a/lib/crates/fabro-cli/tests/it/cmd/serve.rs
+++ b/lib/crates/fabro-cli/tests/it/cmd/serve.rs
@@ -1,11 +1,10 @@
 #[test]
 #[cfg(feature = "server")]
 fn help() {
-    #[allow(deprecated)]
-    let mut cmd = assert_cmd::Command::cargo_bin("fabro").unwrap();
-    cmd.arg("--no-upgrade-check");
-    let output = cmd.args(["serve", "--help"]).output().expect("runs");
-    assert!(output.status.success());
-    let stdout = String::from_utf8(output.stdout).unwrap();
-    insta::assert_snapshot!(stdout);
+    use fabro_test::{fabro_snapshot, test_context};
+
+    let context = test_context!();
+    let mut cmd = context.command();
+    cmd.args(["serve", "--help"]);
+    fabro_snapshot!(context.filters(), cmd, @"");
 }
diff --git a/lib/crates/fabro-cli/tests/it/snapshots/it__cli__serve_help.snap b/lib/crates/fabro-cli/tests/it/snapshots/it__cli__serve_help.snap
deleted file mode 100644
index ef7de8301..000000000
--- a/lib/crates/fabro-cli/tests/it/snapshots/it__cli__serve_help.snap
+++ /dev/null
@@ -1,40 +0,0 @@
----
-source: lib/crates/fabro-cli/tests/it/cli.rs
-assertion_line: 747
-expression: stdout
----
-Start the HTTP API server
-
-Usage: fabro serve [OPTIONS]
-
-Options:
-      --debug
-          Enable DEBUG-level logging (default is INFO) [env: FABRO_DEBUG=]
-      --port <PORT>
-          Port to listen on [default: 3000]
-      --host <HOST>
-          Host address to bind to [default: 127.0.0.1]
-      --no-upgrade-check
-          Disable automatic upgrade check [env: FABRO_NO_UPGRADE_CHECK=]
-      --model <MODEL>
-          Override default LLM model
-      --quiet
-          Suppress non-essential output [env: FABRO_QUIET=]
-      --provider <PROVIDER>
-          Override default LLM provider
-      --verbose
-          Enable verbose output [env: FABRO_VERBOSE=]
-      --dry-run
-          Execute with simulated LLM backend
-      --storage-dir <STORAGE_DIR>
-          Storage directory (default: ~/.fabro) [env: FABRO_STORAGE_DIR=]
-      --sandbox <SANDBOX>
-          Sandbox for agent tools
-      --server-url <SERVER_URL>
-          Server URL (overrides server.base_url from user.toml) [env: FABRO_SERVER_URL=]
-      --max-concurrent-runs <MAX_CONCURRENT_RUNS>
-          Maximum number of concurrent run executions
-      --config <CONFIG>
-          Path to server config file (default: ~/.fabro/server.toml)
-  -h, --help
-          Print help