scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-07 08:27:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Reduce Daytona sandbox timeout grace period from 5s to 2s

Browse source
This commit is contained in:
Bryan Helmkamp 2026-03-08 10:06:52 -04:00
parent 7af7fb30d6
commit 736f6dec57
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/arc-workflows/src/daytona_sandbox.rs
View file

@ -916,9 +916,8 @@ impl Sandbox for DaytonaSandbox {
// The Daytona API uses direct exec, not a shell.
let wrapped = wrap_bash_command(&command_with_env);
let timeout_duration = std::time::Duration::from_millis(timeout_ms + 5000); // 5s grace period
let timeout_duration = std::time::Duration::from_millis(timeout_ms + 2000); // 2s grace period
let token = cancel_token.unwrap_or_default();
let exec_future = process_svc.execute_command(&wrapped, options);
let result = tokio::select! {

10
crates/arc-workflows/tests/daytona_integration.rs
View file

@ -146,12 +146,12 @@ async fn daytona_exec_command_local_timeout() {
let env = create_env_with_github_app(Some(creds)).await;
env.initialize().await.unwrap();
// Use a tiny timeout_ms of 100ms, our local timeout is 100 + 5000 = 5100ms.
// Use a tiny timeout_ms of 100ms, our local timeout is 100 + 2000 = 2100ms.
// If the server doesn't enforce the timeout properly or drops the connection,
// our local timeout should catch it. To simulate this without making a bad server,
// we can't easily force the local timeout to hit before the server timeout
// without mocking. But if we run `sleep 10` and Daytona does NOT respect the
// short timeout parameter, the local 5.1s timeout will definitely fire.
// short timeout parameter, the local 2.1s timeout will definitely fire.
// Let's at least test that a 100ms timeout works and doesn't run for 10s.
let start = std::time::Instant::now();
let result = env
@ -161,10 +161,10 @@ async fn daytona_exec_command_local_timeout() {
let duration = start.elapsed();
// It should either fail with Daytona's timeout (duration < 5000ms) or our
// local timeout (duration ~5100ms). Both are valid success conditions for
// It should either fail with Daytona's timeout (duration < 2000ms) or our
// local timeout (duration ~2100ms). Both are valid success conditions for
// the system as a whole avoiding a stall.
assert!(duration < std::time::Duration::from_millis(6000), "Command stalled for longer than the local timeout mechanism");
assert!(duration < std::time::Duration::from_millis(3000), "Command stalled for longer than the local timeout mechanism");
assert!(result.exit_code != 0);
env.cleanup().await.unwrap();