From 6aec33c4f50d2d41ad11ce6baddf3a2cecc1fa96 Mon Sep 17 00:00:00 2001 From: Bryan Helmkamp Date: Fri, 18 Sep 2026 18:39:58 -0400 Subject: [PATCH] Settle clippy and formatting after the sandbox merge Co-Authored-By: Claude Fable 5.1 --- .../src/server/handler/artifacts.rs | 17 +++++++---------- lib/components/fabro-dump/src/lib.rs | 2 +- lib/components/fabro-petri/src/projection.rs | 9 ++++----- .../2026091801_remove_server_slatedb.rs | 1 + 4 files changed, 13 insertions(+), 16 deletions(-) diff --git a/lib/apps/fabro-server/src/server/handler/artifacts.rs b/lib/apps/fabro-server/src/server/handler/artifacts.rs index e06d4b4da..9cae243ab 100644 --- a/lib/apps/fabro-server/src/server/handler/artifacts.rs +++ b/lib/apps/fabro-server/src/server/handler/artifacts.rs @@ -417,16 +417,13 @@ async fn download_run_artifacts( Ok(projection) => projection, Err(error) => return error.into_response(), }; - let entries = match run_artifacts(state.as_ref(), &id, &projection).await { - Ok(entries) => entries, - Err(_) => { - warn!(run_id = %id, "failed to list artifacts for ZIP download"); - return ApiError::new( - StatusCode::INTERNAL_SERVER_ERROR, - "Artifact archive could not be prepared.", - ) - .into_response(); - } + let Ok(entries) = run_artifacts(state.as_ref(), &id, &projection).await else { + warn!(run_id = %id, "failed to list artifacts for ZIP download"); + return ApiError::new( + StatusCode::INTERNAL_SERVER_ERROR, + "Artifact archive could not be prepared.", + ) + .into_response(); }; let artifacts = latest_run_artifacts(entries, &projection); diff --git a/lib/components/fabro-dump/src/lib.rs b/lib/components/fabro-dump/src/lib.rs index 4834e65dd..524c288a8 100644 --- a/lib/components/fabro-dump/src/lib.rs +++ b/lib/components/fabro-dump/src/lib.rs @@ -766,7 +766,7 @@ mod tests { fn hydrate_referenced_blobs_takes_a_plain_reference_as_text() { // A large string leaves the run context as its own bytes, under a // plain reference: the bytes are the text, not JSON. - let blob = b"x".repeat(12).to_vec(); + let blob = b"x".repeat(12); let blob_hash = fabro_types::BlobHash::new(&blob); let blob_ref = fabro_types::format_blob_ref(&blob_hash); let mut dump = RunDump { diff --git a/lib/components/fabro-petri/src/projection.rs b/lib/components/fabro-petri/src/projection.rs index dc22b369d..654ee499b 100644 --- a/lib/components/fabro-petri/src/projection.rs +++ b/lib/components/fabro-petri/src/projection.rs @@ -38,11 +38,10 @@ use fabro_types::{ ModelRef, ModelUsage, ParallelBranchId, ParallelBranchResult, PendingInterviewRecord, PullRequestCreation, PullRequestCreationStatus, PullRequestLink, RunApproval, RunApprovalState, RunArtifact, RunControlAction, RunDiff, RunFailure, RunId, RunProjection, RunSandbox, - RunSandboxFailure, RunSandboxInstance, RunSandboxPlan, RunSandboxRuntime, RunStatus, - RunTiming, SandboxProviderKind, StageCompletion, StageHandler, StageId, - StageInferenceProjection, StageModelUsage, StageOutcome, StageProjection, StageState, - StageTiming, StartRecord, SuccessReason, first_event_seq, format_blob_ref, parse_blob_ref, - timing, usage_rollup, + RunSandboxFailure, RunSandboxInstance, RunSandboxPlan, RunSandboxRuntime, RunStatus, RunTiming, + SandboxProviderKind, StageCompletion, StageHandler, StageId, StageInferenceProjection, + StageModelUsage, StageOutcome, StageProjection, StageState, StageTiming, StartRecord, + SuccessReason, first_event_seq, format_blob_ref, parse_blob_ref, timing, usage_rollup, }; use lithos_llm::catalog::{ModelId, ProviderId}; use lithos_llm::types::Usage; diff --git a/lib/foundation/fabro-config/migrations/2026091801_remove_server_slatedb.rs b/lib/foundation/fabro-config/migrations/2026091801_remove_server_slatedb.rs index 6c918373f..11d454852 100644 --- a/lib/foundation/fabro-config/migrations/2026091801_remove_server_slatedb.rs +++ b/lib/foundation/fabro-config/migrations/2026091801_remove_server_slatedb.rs @@ -13,6 +13,7 @@ #![expect( clippy::disallowed_methods, + clippy::disallowed_types, reason = "temporary startup config migration uses synchronous file I/O before config is loaded" )]