diff --git a/apps/fabro-web/app/components/runs-list/run-table-row.tsx b/apps/fabro-web/app/components/runs-list/run-table-row.tsx index 20c85f63f..0d94927a1 100644 --- a/apps/fabro-web/app/components/runs-list/run-table-row.tsx +++ b/apps/fabro-web/app/components/runs-list/run-table-row.tsx @@ -12,6 +12,18 @@ import { RowActionsMenu } from "./row-actions-menu"; import { SelectionCheckbox } from "./selection-checkbox"; import type { ToggleableColumn } from "./toggleable-column"; +function CreatedByCell({ createdBy }: { createdBy: RunWithStatus["createdBy"] }) { + const display = principalDisplay(createdBy); + + return ( + + + {display.glyph} + + + ); +} + function listLifecycleStatusLabel( run: Pick, ): string | null { @@ -35,7 +47,6 @@ export function RunTableRow({ }) { const lifecycleLabel = listLifecycleStatusLabel(run); const statusDisplay = columnStatusDisplay[run.status]; - const createdByDisplay = principalDisplay(run.createdBy); const show = (col: ToggleableColumn) => !hiddenColumns.has(col); return ( @@ -53,13 +64,7 @@ export function RunTableRow({ {run.statusLabel} - {show("created_by") && ( - - - {createdByDisplay.glyph} - - - )} + {show("created_by") && } {show("repo") && ( {run.repo} diff --git a/apps/fabro-web/app/lib/run-actions.test.ts b/apps/fabro-web/app/lib/run-actions.test.ts index a95fa6b8d..d88fdd3af 100644 --- a/apps/fabro-web/app/lib/run-actions.test.ts +++ b/apps/fabro-web/app/lib/run-actions.test.ts @@ -24,6 +24,7 @@ import { unarchiveRuns, } from "./run-actions"; import { generatedAxios } from "./api-client"; +import { TEST_PRINCIPAL } from "./test-fixtures"; type StubResponseInit = { status: number; @@ -37,8 +38,6 @@ type CapturedRequest = { data?: unknown; }; -import { TEST_PRINCIPAL } from "./test-fixtures"; - const originalAdapter = generatedAxios.defaults.adapter; function makeRun(status: RunStatus, archived = false): Run { diff --git a/apps/fabro-web/app/lib/test-fixtures.ts b/apps/fabro-web/app/lib/test-fixtures.ts index 2c7b1391d..95cefdb41 100644 --- a/apps/fabro-web/app/lib/test-fixtures.ts +++ b/apps/fabro-web/app/lib/test-fixtures.ts @@ -1,8 +1,5 @@ import type { Principal } from "@qltysh/fabro-api-client"; -/** - * Shared frontend test fixture mirroring `fabro_types::test_support::test_principal()`. - */ export const TEST_PRINCIPAL: Principal = { kind: "user", identity: { issuer: "fabro:test", subject: "test-user" },