mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-11-17 09:31:45 +00:00
fix(web): scroll Overview platform records independently of the graph
The Overview tab put RunSummaryPanel and PlatformRecordsPanel in one shrink-0 block with no height cap. As checkpoints accumulated, that block grew without bound and collapsed the flex-1 workflow graph. Mirror the Stages sidebar scroll fix: keep the summary pinned, and let platform records scroll inside a max-height so the graph stays visible. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
parent
1906d7c9ea
commit
66f425fddd
2 changed files with 25 additions and 1 deletions
|
|
@ -142,4 +142,25 @@ describe("RunOverview", () => {
|
|||
const other = renderAt("/runs/run-b");
|
||||
expect(graphTransform(other)).toBe(initial);
|
||||
});
|
||||
|
||||
test("bounds platform records height so the graph keeps a flex share", () => {
|
||||
currentGraphData = "<svg viewBox='0 0 100 100'></svg>";
|
||||
|
||||
const renderer = render();
|
||||
const scroll = renderer.root.findAll(
|
||||
(n) =>
|
||||
typeof n.props?.className === "string" &&
|
||||
n.props.className.includes("max-h-[min(40vh,16rem)]") &&
|
||||
n.props.className.includes("overflow-y-auto"),
|
||||
);
|
||||
expect(scroll).toHaveLength(1);
|
||||
|
||||
const graph = renderer.root.findAll(
|
||||
(n) =>
|
||||
typeof n.props?.className === "string" &&
|
||||
n.props.className.includes("graph-svg") &&
|
||||
n.props.className.includes("flex-1"),
|
||||
);
|
||||
expect(graph).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -154,8 +154,11 @@ export default function RunOverview() {
|
|||
</div>
|
||||
|
||||
<div className="flex min-h-0 min-w-0 flex-1 flex-col gap-4 pb-[var(--fabro-interview-dock-clearance,0px)]">
|
||||
<div className="shrink-0 space-y-4">
|
||||
<div className="shrink-0">
|
||||
<RunSummaryPanel runId={id!} />
|
||||
</div>
|
||||
{/* Cap + scroll so a long checkpoint list cannot starve the graph. */}
|
||||
<div className="min-h-0 max-h-[min(40vh,16rem)] shrink overflow-y-auto overflow-x-hidden">
|
||||
<PlatformRecordsPanel runId={id!} />
|
||||
</div>
|
||||
{graphSvg === undefined && graphQuery.isLoading ? (
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue