scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-08-28 05:27:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(install): don't enable dev-token auth when GitHub App is selected

Browse source 
When the install wizard (or `fabro install github --strategy app`)
writes GitHub App settings, it now removes "dev-token" from
`server.auth.methods`, mirroring how `write_token_settings` removes
"github" in the opposite direction. Users who want both auth methods
can still configure that explicitly by editing `settings.toml`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-04-21 15:27:19 -04:00
parent cdba970891
commit 64e4239534
No known key found for this signature in database
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/crates/fabro-cli/src/commands/install.rs
View file

@ -2300,7 +2300,7 @@ client_id = "client-id"
.iter()
.map(|value| value.as_str().expect("auth method should be a string"))
.collect::<Vec<_>>(),
vec!["dev-token", "github"]
vec!["github"]
);
let allowed_usernames = doc

17
lib/crates/fabro-install/src/lib.rs
View file

@ -215,6 +215,7 @@ pub fn write_github_app_settings(
if !methods.iter().any(|value| value.as_str() == Some("github")) {
methods.push(toml::Value::String("github".to_string()));
}
methods.retain(|value| value.as_str() != Some("dev-token"));
let github_auth = ensure_table(auth, "github")?;
github_auth.insert(
"allowed_usernames".to_string(),
@ -438,6 +439,22 @@ name = "custom"
github.get("client_id").and_then(toml::Value::as_str),
Some("client-id")
);
let methods = doc
.get("server")
.and_then(toml::Value::as_table)
.and_then(|server| server.get("auth"))
.and_then(toml::Value::as_table)
.and_then(|auth| auth.get("methods"))
.and_then(toml::Value::as_array)
.expect("server.auth.methods should exist");
assert_eq!(
methods
.iter()
.map(|value| value.as_str().expect("auth method should be a string"))
.collect::<Vec<_>>(),
vec!["github"]
);
}
#[test]