mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-06 08:18:58 +00:00
parent
b72b51a3ae
commit
59632ea8de
5 changed files with 149 additions and 12 deletions
141
run.json
141
run.json
|
|
@ -517,7 +517,7 @@
|
|||
"kind": "running"
|
||||
},
|
||||
"status_updated_at": "2026-05-22T18:56:04.773364Z",
|
||||
"last_event_at": "2026-05-22T18:56:06.792799Z",
|
||||
"last_event_at": "2026-05-22T18:56:15.184446Z",
|
||||
"pending_control": null,
|
||||
"checkpoints": [
|
||||
{
|
||||
|
|
@ -558,9 +558,9 @@
|
|||
"diff": {}
|
||||
},
|
||||
{
|
||||
"seq": 0,
|
||||
"seq": 27,
|
||||
"checkpoint": {
|
||||
"timestamp": "2026-05-22T18:56:09.856095Z",
|
||||
"timestamp": "2026-05-22T18:56:15.180867Z",
|
||||
"current_node": "toolchain",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
|
|
@ -568,16 +568,76 @@
|
|||
],
|
||||
"node_retries": {},
|
||||
"context_values": {
|
||||
"outcome": "succeeded",
|
||||
"internal.retry_count.toolchain": 0,
|
||||
"internal.thread_id": "start",
|
||||
"graph.goal": "---\ntitle: Add run.checkpoint.skip_git_hooks\ntype: feat\nstatus: active\ndate: 2026-05-22\n---\n\n# Add `run.checkpoint.skip_git_hooks`\n\n## Summary\n\nAdd an opt-in setting:\n\n```toml\n[run.checkpoint]\nskip_git_hooks = true\n```\n\nWhen enabled, Fabro-created run-branch checkpoint commits bypass Git commit hooks. Default remains `false`, preserving current behavior. This setting does not affect Fabro workflow hooks or metadata-branch snapshots.\n\n## Key Changes\n\n- Add `skip_git_hooks: bool` to dense checkpoint settings in `fabro-types`, defaulting to `false`.\n- Add `skip_git_hooks: Option<bool>` to sparse `fabro-config::RunCheckpointLayer` so layered config can distinguish unset from explicit `false`.\n- Update checkpoint layer merging so `exclude_globs` keeps its existing replace/inherit behavior and `skip_git_hooks` uses normal override semantics.\n- Update checkpoint resolution so missing config resolves to `skip_git_hooks = false`.\n- Thread the resolved setting into run-branch checkpoint commit creation.\n- Append the hook-skipping commit option only for Fabro-managed run-branch checkpoint commits, including:\n - normal lifecycle checkpoint commits in `sandbox_git.rs`\n - parallel base checkpoint commits through the same helper\n - parallel branch worktree commits in `handler/parallel.rs`\n- Update OpenAPI `RunCheckpointSettings` and regenerate the TypeScript API client so persisted run settings expose the new field.\n- Update user docs/options reference to document `skip_git_hooks`, its default, and that it does not disable Fabro `[[run.hooks]]`.\n\n## Test Plan\n\n- `fabro-config` tests:\n - `[run.checkpoint] skip_git_hooks = true` resolves to `true`.\n - omitted `skip_git_hooks` resolves to `false`.\n - higher-layer `skip_git_hooks = false` overrides lower-layer `true`.\n - `exclude_globs` merging behavior remains unchanged.\n- `fabro-workflow` tests:\n - checkpoint commit command includes the hook-skip option when enabled.\n - checkpoint commit command omits it when disabled.\n - parallel branch commit command respects the setting.\n- API/client tests:\n - `WorkflowSettings` / `RunCheckpointSettings` round-trip includes `skip_git_hooks`.\n - OpenAPI-generated Rust and TypeScript clients reflect the new boolean field.\n- Regression:\n - existing git checkpoint tests still pass, including metadata branch tests.\n\n## Assumptions\n\n- The setting applies to Git commit hooks for run-branch checkpoint commits; it does not change metadata-branch behavior because metadata snapshots already use `git2` and do not fire local hooks.\n- The setting does not disable Fabro lifecycle hooks under `[[run.hooks]]`.\n- Default `false` is required for backward compatibility.\n",
|
||||
"graph.model_stylesheet": "\n * { model: claude-opus-4-7; }\n ",
|
||||
"graph.rankdir": "LR",
|
||||
"current_node": "toolchain",
|
||||
"internal.run_id": "01KS8GPB6C00GQ6G5A05S9AAC8",
|
||||
"internal.work_dir": "/home/daytona/workspace/fabro",
|
||||
"internal.retry_count.start": 0,
|
||||
"internal.fidelity": "compact",
|
||||
"thread.start.current_node": "toolchain",
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"failure_signature": "",
|
||||
"internal.node_visit_count": 1,
|
||||
"failure_class": ""
|
||||
},
|
||||
"node_outcomes": {
|
||||
"start": {
|
||||
"status": "succeeded",
|
||||
"usage": null
|
||||
},
|
||||
"toolchain": {
|
||||
"status": "succeeded",
|
||||
"context_updates": {
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c"
|
||||
},
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"usage": null
|
||||
}
|
||||
},
|
||||
"next_node_id": "preflight_compile",
|
||||
"git_commit_sha": "ac3c10e4f59bbb96d11ba913024a6c0fedc2866e",
|
||||
"node_visits": {
|
||||
"toolchain": 1,
|
||||
"start": 1
|
||||
}
|
||||
},
|
||||
"diff": {
|
||||
"summary": {
|
||||
"files_changed": 0,
|
||||
"additions": 0,
|
||||
"deletions": 0
|
||||
}
|
||||
}
|
||||
},
|
||||
{
|
||||
"seq": 0,
|
||||
"checkpoint": {
|
||||
"timestamp": "2026-05-22T18:58:19.214351Z",
|
||||
"current_node": "preflight_compile",
|
||||
"completed_nodes": [
|
||||
"start",
|
||||
"toolchain",
|
||||
"preflight_compile"
|
||||
],
|
||||
"node_retries": {},
|
||||
"context_values": {
|
||||
"internal.thread_id": "toolchain",
|
||||
"graph.rankdir": "LR",
|
||||
"thread.start.current_node": "toolchain",
|
||||
"outcome": "succeeded",
|
||||
"internal.run_id": "01KS8GPB6C00GQ6G5A05S9AAC8",
|
||||
"thread.toolchain.current_node": "preflight_compile",
|
||||
"internal.retry_count.preflight_compile": 0,
|
||||
"internal.work_dir": "/home/daytona/workspace/fabro",
|
||||
"internal.node_visit_count": 1,
|
||||
"failure_class": "",
|
||||
"command.output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"current_node": "toolchain",
|
||||
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126",
|
||||
"current_node": "preflight_compile",
|
||||
"internal.retry_count.start": 0,
|
||||
"failure_signature": "",
|
||||
"internal.retry_count.toolchain": 0,
|
||||
|
|
@ -586,6 +646,18 @@
|
|||
"internal.fidelity": "compact"
|
||||
},
|
||||
"node_outcomes": {
|
||||
"preflight_compile": {
|
||||
"status": "succeeded",
|
||||
"context_updates": {
|
||||
"command.output": "blob://sha256/12ae32cb1ec02d01eda3581b127c1fee3b0dc53572ed6baf239721a03d82e126"
|
||||
},
|
||||
"notes": "Script completed: cargo check -q --workspace 2>&1",
|
||||
"usage": null
|
||||
},
|
||||
"start": {
|
||||
"status": "succeeded",
|
||||
"usage": null
|
||||
},
|
||||
"toolchain": {
|
||||
"status": "succeeded",
|
||||
"context_updates": {
|
||||
|
|
@ -593,15 +665,12 @@
|
|||
},
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"usage": null
|
||||
},
|
||||
"start": {
|
||||
"status": "succeeded",
|
||||
"usage": null
|
||||
}
|
||||
},
|
||||
"next_node_id": "preflight_compile",
|
||||
"next_node_id": "preflight_lint",
|
||||
"node_visits": {
|
||||
"start": 1,
|
||||
"preflight_compile": 1,
|
||||
"toolchain": 1
|
||||
}
|
||||
},
|
||||
|
|
@ -633,7 +702,12 @@
|
|||
"first_event_seq": 20,
|
||||
"prompt": null,
|
||||
"response": null,
|
||||
"completion": null,
|
||||
"completion": {
|
||||
"outcome": "succeeded",
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-22T18:56:09.854292Z"
|
||||
},
|
||||
"provider_used": null,
|
||||
"diff": null,
|
||||
"script_invocation": {
|
||||
|
|
@ -641,10 +715,53 @@
|
|||
"command": "exec 2>&1\ncommand -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"language": "shell"
|
||||
},
|
||||
"script_timing": {
|
||||
"output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"exit_code": 0,
|
||||
"duration_ms": 3045,
|
||||
"termination": "exited",
|
||||
"output_bytes": 36,
|
||||
"live_streaming": false
|
||||
},
|
||||
"parallel_results": null,
|
||||
"output": null,
|
||||
"output_bytes": 36,
|
||||
"live_streaming": false,
|
||||
"termination": "exited",
|
||||
"started_at": "2026-05-22T18:56:06.792738Z",
|
||||
"handler": "command",
|
||||
"timing": {
|
||||
"wall_time_ms": 3061,
|
||||
"inference_time_ms": 0,
|
||||
"tool_time_ms": 0,
|
||||
"active_time_ms": 0
|
||||
},
|
||||
"usage": {
|
||||
"input_tokens": 0,
|
||||
"output_tokens": 0,
|
||||
"total_tokens": 0,
|
||||
"reasoning_tokens": 0,
|
||||
"cache_read_tokens": 0,
|
||||
"cache_write_tokens": 0
|
||||
},
|
||||
"state": "succeeded"
|
||||
},
|
||||
"preflight_compile@1": {
|
||||
"first_event_seq": 30,
|
||||
"prompt": null,
|
||||
"response": null,
|
||||
"completion": null,
|
||||
"provider_used": null,
|
||||
"diff": null,
|
||||
"script_invocation": {
|
||||
"script": "cargo check -q --workspace 2>&1",
|
||||
"command": "exec 2>&1\ncargo check -q --workspace 2>&1",
|
||||
"language": "shell"
|
||||
},
|
||||
"script_timing": null,
|
||||
"parallel_results": null,
|
||||
"output": null,
|
||||
"started_at": "2026-05-22T18:56:06.792738Z",
|
||||
"started_at": "2026-05-22T18:56:15.183584Z",
|
||||
"handler": "command",
|
||||
"usage": {
|
||||
"input_tokens": 0,
|
||||
|
|
|
|||
1
stages/002-toolchain@1/output.log
Normal file
1
stages/002-toolchain@1/output.log
Normal file
|
|
@ -0,0 +1 @@
|
|||
blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c
|
||||
8
stages/002-toolchain@1/script_timing.json
Normal file
8
stages/002-toolchain@1/script_timing.json
Normal file
|
|
@ -0,0 +1,8 @@
|
|||
{
|
||||
"output": "blob://sha256/fc14b2ba2d770e5cd3169df7a29525c962adfc4cfa3097b9098c63ebd61a748c",
|
||||
"exit_code": 0,
|
||||
"duration_ms": 3045,
|
||||
"termination": "exited",
|
||||
"output_bytes": 36,
|
||||
"live_streaming": false
|
||||
}
|
||||
6
stages/002-toolchain@1/status.json
Normal file
6
stages/002-toolchain@1/status.json
Normal file
|
|
@ -0,0 +1,6 @@
|
|||
{
|
||||
"outcome": "succeeded",
|
||||
"notes": "Script completed: command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1",
|
||||
"failure_reason": null,
|
||||
"timestamp": "2026-05-22T18:56:09.854292Z"
|
||||
}
|
||||
5
stages/003-preflight_compile@1/script_invocation.json
Normal file
5
stages/003-preflight_compile@1/script_invocation.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"script": "cargo check -q --workspace 2>&1",
|
||||
"command": "exec 2>&1\ncargo check -q --workspace 2>&1",
|
||||
"language": "shell"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue