diff --git a/graph.fabro b/graph.fabro new file mode 100644 index 000000000..c4010026d --- /dev/null +++ b/graph.fabro @@ -0,0 +1,41 @@ +digraph SWEBench { + graph [goal="Django throws error when different apps with different models have the same name table name. +Description + +Error message: +table_name: (models.E028) db_table 'table_name' is used by multiple models: base.ModelName, app2.ModelName. +We have a Base app that points to a central database and that has its own tables. We then have multiple Apps that talk to their own databases. Some share the same table names. +We have used this setup for a while, but after upgrading to Django 2.2 we're getting an error saying we're not allowed 2 apps, with 2 different models to have the same table names. +Is this correct behavior? We've had to roll back to Django 2.0 for now. + + + +## Additional Context + +Regression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS. +I agree with your opinion. Assigning to myself, patch on its way Replying to Claude Paroz: Regression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS."] + rankdir=LR + + start [shape=Mdiamond] + exit [shape=Msquare] + + setup [label="Setup", shape=parallelogram, script="git clone https://github.com/django/django.git . && git checkout 65e86948b80262574058a94ccaae3a9b59c3faea && python -m pip install -e ."] + solve [label="Solve", prompt="Fix this GitHub issue in the repository. Make the minimal code change needed.\n\nDjango throws error when different apps with different models have the same name table name. +Description + +Error message: +table_name: (models.E028) db_table 'table_name' is used by multiple models: base.ModelName, app2.ModelName. +We have a Base app that points to a central database and that has its own tables. We then have multiple Apps that talk to their own databases. Some share the same table names. +We have used this setup for a while, but after upgrading to Django 2.2 we're getting an error saying we're not allowed 2 apps, with 2 different models to have the same table names. +Is this correct behavior? We've had to roll back to Django 2.0 for now. + + + +## Additional Context + +Regression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS. +I agree with your opinion. Assigning to myself, patch on its way Replying to Claude Paroz: Regression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS."] + extract_patch [label="Extract Patch", shape=parallelogram, script="git diff"] + + start -> setup -> solve -> extract_patch -> exit +} diff --git a/manifest.json b/manifest.json new file mode 100644 index 000000000..17eb5ef66 --- /dev/null +++ b/manifest.json @@ -0,0 +1,13 @@ +{ + "run_id": "01KKTJ3NYSF3ATKMXR1RPWGM9T", + "workflow_name": "SWEBench", + "goal": "Django throws error when different apps with different models have the same name table name.\nDescription\n\t\nError message:\ntable_name: (models.E028) db_table 'table_name' is used by multiple models: base.ModelName, app2.ModelName.\nWe have a Base app that points to a central database and that has its own tables. We then have multiple Apps that talk to their own databases. Some share the same table names.\nWe have used this setup for a while, but after upgrading to Django 2.2 we're getting an error saying we're not allowed 2 apps, with 2 different models to have the same table names. \nIs this correct behavior? We've had to roll back to Django 2.0 for now.\n\n\n\n## Additional Context\n\nRegression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS.\nI agree with your opinion. Assigning to myself, patch on its way Replying to Claude Paroz: Regression in [5d25804eaf81795c7d457e5a2a9f0b9b0989136c], ticket #20098. My opinion is that as soon as the project has a non-empty DATABASE_ROUTERS setting, the error should be turned into a warning, as it becomes difficult to say for sure that it's an error. And then the project can add the warning in SILENCED_SYSTEM_CHECKS.", + "start_time": "2026-03-16T05:32:47.079456Z", + "node_count": 5, + "edge_count": 4, + "run_branch": "fabro/run/01KKTJ3NYSF3ATKMXR1RPWGM9T", + "base_sha": "470fcfe1200b2102c0cdf91c73b0ed8d925f258a", + "base_branch": "main", + "workflow_slug": "django__django-11630", + "host_repo_path": "/Users/bhelmkamp/p/fabro-sh/fabro/evals/swe-bench/results/gpt54-baseline/runs/django__django-11630" +} \ No newline at end of file diff --git a/sandbox.json b/sandbox.json new file mode 100644 index 000000000..18dabf6f9 --- /dev/null +++ b/sandbox.json @@ -0,0 +1,5 @@ +{ + "provider": "daytona", + "working_directory": "/home/daytona/workspace", + "identifier": "fabro-01KKTJ3NYSF3ATKMXR1RPWGM9T" +} \ No newline at end of file