From 4ff78ec25777cd31baaeca3f94f079757b4b9ee6 Mon Sep 17 00:00:00 2001 From: Fabro Date: Thu, 19 Mar 2026 11:21:55 -0400 Subject: [PATCH] checkpoint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ⚒️ Generated with [Fabro](https://fabro.sh) --- checkpoint.json | 30 ++++++++++++++----- .../preflight_compile/script_invocation.json | 5 ++++ nodes/preflight_compile/script_timing.json | 5 ++++ nodes/preflight_compile/status.json | 6 ++++ 4 files changed, 38 insertions(+), 8 deletions(-) create mode 100644 nodes/preflight_compile/script_invocation.json create mode 100644 nodes/preflight_compile/script_timing.json create mode 100644 nodes/preflight_compile/status.json diff --git a/checkpoint.json b/checkpoint.json index 90dbe826a..7aebe1380 100644 --- a/checkpoint.json +++ b/checkpoint.json @@ -1,35 +1,48 @@ { - "timestamp": "2026-03-19T15:20:42.523377Z", - "current_node": "toolchain", + "timestamp": "2026-03-19T15:21:55.477681Z", + "current_node": "preflight_compile", "completed_nodes": [ "start", - "toolchain" + "toolchain", + "preflight_compile" ], "node_retries": { + "preflight_compile": 1, "start": 1, "toolchain": 1 }, "context_values": { - "command.output": "cargo 1.94.0 (85eff7c80 2026-01-15)\n", + "command.output": "", "failure_class": "", "thread.start.current_node": "toolchain", "internal.node_visit_count": 1, "failure_signature": "", - "current.preamble": "Goal: # Fix: DaytonaSandbox concurrent test failures from `set_current_dir` poisoning\n\n## Context\n\nTwo Daytona integration tests (`daytona_computer_use_browser_screenshot` and `daytona_playwright_mcp_sandbox_transport`) call `std::env::set_current_dir(tmp.path())` to make `detect_repo_info()` fail so the sandbox skips cloning. Since `set_current_dir` is **process-global**, any concurrent test calling `initialize()` sees the changed cwd, causing `detect_repo_info` to fail and the sandbox to get an empty directory with no git repo. This makes `git rev-parse HEAD` return exit code 128.\n\nThe fix follows the existing `ExeSandbox`/`SshSandbox` pattern: move clone params out of `initialize()` and into the constructor so callers control whether cloning happens.\n\n## Changes\n\n### 1. `lib/crates/fabro-daytona/src/lib.rs` — Core refactor\n\n- Add a `GitCloneParams` struct with `url: String` and `branch: Option` fields\n- Change `DaytonaSandbox` field from `clone_branch: Option` to `clone_params: Option`\n- Update `new()` signature: last param changes from `clone_branch: Option` to `clone_params: Option`\n- Update `reconnect()` (line 84): `clone_params: None`\n- Refactor `initialize()`:\n - Remove `let cwd = std::env::current_dir()` (line 392)\n - Replace `match detect_repo_info(&cwd)` (line 448) with `if let Some(ref params) = self.clone_params`\n - `Some` arm: use `params.url` / `params.branch` directly (already HTTPS, no `ssh_url_to_https` needed inside initialize)\n - `None` arm: create empty working directory (existing `Err` arm logic, lines 607-618)\n - Remove `self.clone_branch.clone().or(detected_branch)` merge — caller provides the final branch\n\n### 2. `lib/crates/fabro-cli/src/commands/run.rs` — Production callers\n\n- **Line 1017** (main `run` path): Construct `GitCloneParams` from `origin_url` and `detected_base_branch` (already extracted at line 557):\n ```rust\n let clone_params = origin_url.as_ref().map(|url| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(url),\n branch: detected_base_branch.clone(),\n });\n ```\n Pass `clone_params` as the last arg to `DaytonaSandbox::new()`\n\n- **Line 2133** (doctor path): Currently passes `None` for `clone_branch`. Under the new API, `None` for `clone_params` means \"skip clone\" — same behavior, just update the type. No logic change needed.\n\n### 3. `lib/crates/fabro-workflows/tests/daytona_integration.rs` — Test fixes\n\n- **`create_env_with_github_app`** (line 30): Detect repo and build `GitCloneParams` before calling `new()`:\n ```rust\n let cwd = std::env::current_dir().unwrap();\n let clone_params = fabro_daytona::detect_repo_info(&cwd)\n .ok()\n .map(|(url, branch)| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(&url),\n branch,\n });\n DaytonaSandbox::new(DaytonaConfig::default(), github_app, None, clone_params)\n ```\n This preserves cloning for all tests that use `create_env()`/`create_env_with_github_app()`.\n\n- **`daytona_snapshot_sandbox`** (line 252) and **`run_daytona_cli_test`** (line 927): Currently pass `None` as `clone_branch`. Under new API, `None` for `clone_params` = skip clone. These tests don't need repo contents (snapshot checks `rg --version`, CLI tests install tools independently). No logic change needed.\n\n- **`daytona_computer_use_browser_screenshot`** (line 1855-1857): Remove `tempfile::tempdir()` and `set_current_dir()`. Already passes `None` as last arg → skip clone.\n\n- **`daytona_playwright_mcp_sandbox_transport`** (line 2015-2017): Same — remove `tempfile::tempdir()` and `set_current_dir()`.\n\n## Verification\n\n1. `cargo build --workspace` — confirms all callers updated (compiler catches type mismatch)\n2. `cargo test -p fabro-workflows --test daytona_integration -- --ignored --test-threads=4` — the previously-failing git tests should pass with concurrent execution\n3. Specifically verify the 5 previously-failing tests pass: `daytona_full_lifecycle`, `daytona_git_checkpoint_remote_emits_events`, `daytona_git_checkpoint_with_shadow_branch`, `daytona_git_push_run_branch_to_origin`, `daytona_parallel_git_branching_e2e`\n\n", + "internal.retry_count.preflight_compile": 1, + "current.preamble": "Goal: # Fix: DaytonaSandbox concurrent test failures from `set_current_dir` poisoning\n\n## Context\n\nTwo Daytona integration tests (`daytona_computer_use_browser_screenshot` and `daytona_playwright_mcp_sandbox_transport`) call `std::env::set_current_dir(tmp.path())` to make `detect_repo_info()` fail so the sandbox skips cloning. Since `set_current_dir` is **process-global**, any concurrent test calling `initialize()` sees the changed cwd, causing `detect_repo_info` to fail and the sandbox to get an empty directory with no git repo. This makes `git rev-parse HEAD` return exit code 128.\n\nThe fix follows the existing `ExeSandbox`/`SshSandbox` pattern: move clone params out of `initialize()` and into the constructor so callers control whether cloning happens.\n\n## Changes\n\n### 1. `lib/crates/fabro-daytona/src/lib.rs` — Core refactor\n\n- Add a `GitCloneParams` struct with `url: String` and `branch: Option` fields\n- Change `DaytonaSandbox` field from `clone_branch: Option` to `clone_params: Option`\n- Update `new()` signature: last param changes from `clone_branch: Option` to `clone_params: Option`\n- Update `reconnect()` (line 84): `clone_params: None`\n- Refactor `initialize()`:\n - Remove `let cwd = std::env::current_dir()` (line 392)\n - Replace `match detect_repo_info(&cwd)` (line 448) with `if let Some(ref params) = self.clone_params`\n - `Some` arm: use `params.url` / `params.branch` directly (already HTTPS, no `ssh_url_to_https` needed inside initialize)\n - `None` arm: create empty working directory (existing `Err` arm logic, lines 607-618)\n - Remove `self.clone_branch.clone().or(detected_branch)` merge — caller provides the final branch\n\n### 2. `lib/crates/fabro-cli/src/commands/run.rs` — Production callers\n\n- **Line 1017** (main `run` path): Construct `GitCloneParams` from `origin_url` and `detected_base_branch` (already extracted at line 557):\n ```rust\n let clone_params = origin_url.as_ref().map(|url| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(url),\n branch: detected_base_branch.clone(),\n });\n ```\n Pass `clone_params` as the last arg to `DaytonaSandbox::new()`\n\n- **Line 2133** (doctor path): Currently passes `None` for `clone_branch`. Under the new API, `None` for `clone_params` means \"skip clone\" — same behavior, just update the type. No logic change needed.\n\n### 3. `lib/crates/fabro-workflows/tests/daytona_integration.rs` — Test fixes\n\n- **`create_env_with_github_app`** (line 30): Detect repo and build `GitCloneParams` before calling `new()`:\n ```rust\n let cwd = std::env::current_dir().unwrap();\n let clone_params = fabro_daytona::detect_repo_info(&cwd)\n .ok()\n .map(|(url, branch)| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(&url),\n branch,\n });\n DaytonaSandbox::new(DaytonaConfig::default(), github_app, None, clone_params)\n ```\n This preserves cloning for all tests that use `create_env()`/`create_env_with_github_app()`.\n\n- **`daytona_snapshot_sandbox`** (line 252) and **`run_daytona_cli_test`** (line 927): Currently pass `None` as `clone_branch`. Under new API, `None` for `clone_params` = skip clone. These tests don't need repo contents (snapshot checks `rg --version`, CLI tests install tools independently). No logic change needed.\n\n- **`daytona_computer_use_browser_screenshot`** (line 1855-1857): Remove `tempfile::tempdir()` and `set_current_dir()`. Already passes `None` as last arg → skip clone.\n\n- **`daytona_playwright_mcp_sandbox_transport`** (line 2015-2017): Same — remove `tempfile::tempdir()` and `set_current_dir()`.\n\n## Verification\n\n1. `cargo build --workspace` — confirms all callers updated (compiler catches type mismatch)\n2. `cargo test -p fabro-workflows --test daytona_integration -- --ignored --test-threads=4` — the previously-failing git tests should pass with concurrent execution\n3. Specifically verify the 5 previously-failing tests pass: `daytona_full_lifecycle`, `daytona_git_checkpoint_remote_emits_events`, `daytona_git_checkpoint_with_shadow_branch`, `daytona_git_push_run_branch_to_origin`, `daytona_parallel_git_branching_e2e`\n\n\n## Completed stages\n- **toolchain**: success\n - Script: `command -v cargo >/dev/null || { curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && sudo ln -sf $HOME/.cargo/bin/* /usr/local/bin/; }; cargo --version 2>&1`\n - Stdout:\n ```\n cargo 1.94.0 (85eff7c80 2026-01-15)\n ```\n - Stderr: (empty)\n", "outcome": "success", "internal.retry_count.start": 1, "internal.run_id": "01KM3AY9Z9FWFBDH954H4W16SG", "internal.retry_count.toolchain": 1, + "thread.toolchain.current_node": "preflight_compile", "graph.goal": "# Fix: DaytonaSandbox concurrent test failures from `set_current_dir` poisoning\n\n## Context\n\nTwo Daytona integration tests (`daytona_computer_use_browser_screenshot` and `daytona_playwright_mcp_sandbox_transport`) call `std::env::set_current_dir(tmp.path())` to make `detect_repo_info()` fail so the sandbox skips cloning. Since `set_current_dir` is **process-global**, any concurrent test calling `initialize()` sees the changed cwd, causing `detect_repo_info` to fail and the sandbox to get an empty directory with no git repo. This makes `git rev-parse HEAD` return exit code 128.\n\nThe fix follows the existing `ExeSandbox`/`SshSandbox` pattern: move clone params out of `initialize()` and into the constructor so callers control whether cloning happens.\n\n## Changes\n\n### 1. `lib/crates/fabro-daytona/src/lib.rs` — Core refactor\n\n- Add a `GitCloneParams` struct with `url: String` and `branch: Option` fields\n- Change `DaytonaSandbox` field from `clone_branch: Option` to `clone_params: Option`\n- Update `new()` signature: last param changes from `clone_branch: Option` to `clone_params: Option`\n- Update `reconnect()` (line 84): `clone_params: None`\n- Refactor `initialize()`:\n - Remove `let cwd = std::env::current_dir()` (line 392)\n - Replace `match detect_repo_info(&cwd)` (line 448) with `if let Some(ref params) = self.clone_params`\n - `Some` arm: use `params.url` / `params.branch` directly (already HTTPS, no `ssh_url_to_https` needed inside initialize)\n - `None` arm: create empty working directory (existing `Err` arm logic, lines 607-618)\n - Remove `self.clone_branch.clone().or(detected_branch)` merge — caller provides the final branch\n\n### 2. `lib/crates/fabro-cli/src/commands/run.rs` — Production callers\n\n- **Line 1017** (main `run` path): Construct `GitCloneParams` from `origin_url` and `detected_base_branch` (already extracted at line 557):\n ```rust\n let clone_params = origin_url.as_ref().map(|url| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(url),\n branch: detected_base_branch.clone(),\n });\n ```\n Pass `clone_params` as the last arg to `DaytonaSandbox::new()`\n\n- **Line 2133** (doctor path): Currently passes `None` for `clone_branch`. Under the new API, `None` for `clone_params` means \"skip clone\" — same behavior, just update the type. No logic change needed.\n\n### 3. `lib/crates/fabro-workflows/tests/daytona_integration.rs` — Test fixes\n\n- **`create_env_with_github_app`** (line 30): Detect repo and build `GitCloneParams` before calling `new()`:\n ```rust\n let cwd = std::env::current_dir().unwrap();\n let clone_params = fabro_daytona::detect_repo_info(&cwd)\n .ok()\n .map(|(url, branch)| fabro_daytona::GitCloneParams {\n url: fabro_github::ssh_url_to_https(&url),\n branch,\n });\n DaytonaSandbox::new(DaytonaConfig::default(), github_app, None, clone_params)\n ```\n This preserves cloning for all tests that use `create_env()`/`create_env_with_github_app()`.\n\n- **`daytona_snapshot_sandbox`** (line 252) and **`run_daytona_cli_test`** (line 927): Currently pass `None` as `clone_branch`. Under new API, `None` for `clone_params` = skip clone. These tests don't need repo contents (snapshot checks `rg --version`, CLI tests install tools independently). No logic change needed.\n\n- **`daytona_computer_use_browser_screenshot`** (line 1855-1857): Remove `tempfile::tempdir()` and `set_current_dir()`. Already passes `None` as last arg → skip clone.\n\n- **`daytona_playwright_mcp_sandbox_transport`** (line 2015-2017): Same — remove `tempfile::tempdir()` and `set_current_dir()`.\n\n## Verification\n\n1. `cargo build --workspace` — confirms all callers updated (compiler catches type mismatch)\n2. `cargo test -p fabro-workflows --test daytona_integration -- --ignored --test-threads=4` — the previously-failing git tests should pass with concurrent execution\n3. Specifically verify the 5 previously-failing tests pass: `daytona_full_lifecycle`, `daytona_git_checkpoint_remote_emits_events`, `daytona_git_checkpoint_with_shadow_branch`, `daytona_git_push_run_branch_to_origin`, `daytona_parallel_git_branching_e2e`\n", "graph.rankdir": "LR", "graph.model_stylesheet": "\n * { backend: api; model: claude-opus-4-6;}\n ", "internal.fidelity": "compact", - "current_node": "toolchain", - "internal.thread_id": "start", + "current_node": "preflight_compile", + "internal.thread_id": "toolchain", "command.stderr": "" }, "logs": [], "node_outcomes": { + "preflight_compile": { + "status": "success", + "context_updates": { + "command.stderr": "", + "command.output": "" + }, + "notes": "Script completed: cargo check -q --workspace 2>&1", + "duration_ms": 69713 + }, "start": { "status": "success", "duration_ms": 0 @@ -44,8 +57,9 @@ "duration_ms": 129 } }, - "next_node_id": "preflight_compile", + "next_node_id": "preflight_lint", "node_visits": { + "preflight_compile": 1, "toolchain": 1, "start": 1 } diff --git a/nodes/preflight_compile/script_invocation.json b/nodes/preflight_compile/script_invocation.json new file mode 100644 index 000000000..ccbef36c7 --- /dev/null +++ b/nodes/preflight_compile/script_invocation.json @@ -0,0 +1,5 @@ +{ + "command": "cargo check -q --workspace 2>&1", + "language": "shell", + "timeout_ms": null +} \ No newline at end of file diff --git a/nodes/preflight_compile/script_timing.json b/nodes/preflight_compile/script_timing.json new file mode 100644 index 000000000..95708535d --- /dev/null +++ b/nodes/preflight_compile/script_timing.json @@ -0,0 +1,5 @@ +{ + "duration_ms": 69711, + "exit_code": 0, + "timed_out": false +} \ No newline at end of file diff --git a/nodes/preflight_compile/status.json b/nodes/preflight_compile/status.json new file mode 100644 index 000000000..92dca300f --- /dev/null +++ b/nodes/preflight_compile/status.json @@ -0,0 +1,6 @@ +{ + "status": "success", + "notes": "Script completed: cargo check -q --workspace 2>&1", + "failure_reason": null, + "timestamp": "2026-03-19T15:21:55.477035+00:00" +} \ No newline at end of file