scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-10-09 03:20:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(web): hide retry on non-recoverable terminal errors

Browse source 
Server-typed errors like "Local sandboxes do not support embedded
terminals" won't change on retry, so the ErrorState now omits the
"Try again" button for them. WebSocket connection failures stay
recoverable and keep the retry affordance.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-05-09 20:21:58 -04:00
parent 85a2cdda64
commit 4f202303bc
No known key found for this signature in database
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
apps/fabro-web/app/routes/run-terminal.tsx
View file

@ -196,7 +196,7 @@ export default function RunTerminal({ params }: { params: { id: string } }) {
const accessCommandLabel = terminalAccessCommandLabel(provider);
const [connectionKey, setConnectionKey] = useState(0);
const [status, setStatus] = useState<ConnectionStatus>("connecting");
const [error, setError] = useState<string | null>(null);
const [error, setError] = useState<{ message: string; recoverable: boolean } | null>(null);
const terminalEl = useRef<HTMLDivElement | null>(null);
const terminalRef = useRef<XtermTerminal | null>(null);
const fitRef = useRef<XtermFitAddon | null>(null);
@ -291,7 +291,10 @@ export default function RunTerminal({ params }: { params: { id: string } }) {
return;
}
setStatus("error");
setError(message.message ?? "Terminal session failed.");
setError({
message: message.message ?? "Terminal session failed.",
recoverable: false,
});
return;
}
const bytes = event.data instanceof ArrayBuffer
@ -304,7 +307,10 @@ export default function RunTerminal({ params }: { params: { id: string } }) {
});
socket.addEventListener("error", () => {
setStatus("error");
setError("Terminal WebSocket connection failed.");
setError({
message: "Terminal WebSocket connection failed.",
recoverable: true,
});
});
resizeObserver = new ResizeObserver(() => {
@ -373,8 +379,8 @@ export default function RunTerminal({ params }: { params: { id: string } }) {
<div className="flex min-h-0 flex-1 items-center justify-center" role="alert">
<ErrorState
title="Terminal unavailable"
description={error}
onRetry={reconnect}
description={error.message}
onRetry={error.recoverable ? reconnect : undefined}
/>
</div>
) : (