mirror of
https://github.com/fabro-sh/fabro.git
synced 2026-09-11 22:53:00 +00:00
parent
4e3f0de225
commit
3f56a03d74
3 changed files with 49 additions and 0 deletions
31
graph.fabro
Normal file
31
graph.fabro
Normal file
|
|
@ -0,0 +1,31 @@
|
|||
digraph SWEBench {
|
||||
graph [goal="UsernameValidator allows trailing newline in usernames
|
||||
Description
|
||||
|
||||
ASCIIUsernameValidator and UnicodeUsernameValidator use the regex
|
||||
r'^[\w.@+-]+$'
|
||||
The intent is to only allow alphanumeric characters as well as ., @, +, and -. However, a little known quirk of Python regexes is that $ will also match a trailing newline. Therefore, the user name validators will accept usernames which end with a newline. You can avoid this behavior by instead using \A and \Z to terminate regexes. For example, the validator regex could be changed to
|
||||
r'\A[\w.@+-]+\Z'
|
||||
in order to reject usernames that end with a newline.
|
||||
I am not sure how to officially post a patch, but the required change is trivial - using the regex above in the two validators in contrib.auth.validators.
|
||||
"]
|
||||
rankdir=LR
|
||||
|
||||
start [shape=Mdiamond]
|
||||
exit [shape=Msquare]
|
||||
|
||||
setup [label="Setup", shape=parallelogram, script="git clone https://github.com/django/django.git . && git checkout d26b2424437dabeeca94d7900b37d2df4410da0c && python -m pip install -e ."]
|
||||
solve [label="Solve", prompt="Fix this GitHub issue in the repository. Make the minimal code change needed.\n\nUsernameValidator allows trailing newline in usernames
|
||||
Description
|
||||
|
||||
ASCIIUsernameValidator and UnicodeUsernameValidator use the regex
|
||||
r'^[\w.@+-]+$'
|
||||
The intent is to only allow alphanumeric characters as well as ., @, +, and -. However, a little known quirk of Python regexes is that $ will also match a trailing newline. Therefore, the user name validators will accept usernames which end with a newline. You can avoid this behavior by instead using \A and \Z to terminate regexes. For example, the validator regex could be changed to
|
||||
r'\A[\w.@+-]+\Z'
|
||||
in order to reject usernames that end with a newline.
|
||||
I am not sure how to officially post a patch, but the required change is trivial - using the regex above in the two validators in contrib.auth.validators.
|
||||
"]
|
||||
extract_patch [label="Extract Patch", shape=parallelogram, script="git diff"]
|
||||
|
||||
start -> setup -> solve -> extract_patch -> exit
|
||||
}
|
||||
13
manifest.json
Normal file
13
manifest.json
Normal file
|
|
@ -0,0 +1,13 @@
|
|||
{
|
||||
"run_id": "01KKTJ36NGEFF7W3RGFTYKHRKA",
|
||||
"workflow_name": "SWEBench",
|
||||
"goal": "UsernameValidator allows trailing newline in usernames\nDescription\n\t\nASCIIUsernameValidator and UnicodeUsernameValidator use the regex \nr'^[\\w.@+-]+$'\nThe intent is to only allow alphanumeric characters as well as ., @, +, and -. However, a little known quirk of Python regexes is that $ will also match a trailing newline. Therefore, the user name validators will accept usernames which end with a newline. You can avoid this behavior by instead using \\A and \\Z to terminate regexes. For example, the validator regex could be changed to\nr'\\A[\\w.@+-]+\\Z'\nin order to reject usernames that end with a newline.\nI am not sure how to officially post a patch, but the required change is trivial - using the regex above in the two validators in contrib.auth.validators.\n",
|
||||
"start_time": "2026-03-16T05:32:31.642306Z",
|
||||
"node_count": 5,
|
||||
"edge_count": 4,
|
||||
"run_branch": "fabro/run/01KKTJ36NGEFF7W3RGFTYKHRKA",
|
||||
"base_sha": "470fcfe1200b2102c0cdf91c73b0ed8d925f258a",
|
||||
"base_branch": "main",
|
||||
"workflow_slug": "django__django-11099",
|
||||
"host_repo_path": "/Users/bhelmkamp/p/fabro-sh/fabro/evals/swe-bench/results/haiku-baseline/runs/django__django-11099"
|
||||
}
|
||||
5
sandbox.json
Normal file
5
sandbox.json
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
{
|
||||
"provider": "daytona",
|
||||
"working_directory": "/home/daytona/workspace",
|
||||
"identifier": "fabro-01KKTJ36NGEFF7W3RGFTYKHRKA"
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue