scriptoriumadmin/fabro
1
0
Fork 0
mirror of https://github.com/fabro-sh/fabro.git synced 2026-09-07 08:27:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Exercise full retro path in dry-run mode

Browse source 
Instead of skipping the retro agent entirely in dry-run, use a
placeholder narrative so derive → apply_narrative → save all run.
This catches bugs in the merge/persistence path without LLM calls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Bryan Helmkamp 2026-03-01 15:47:40 -05:00
parent 73b00f047b
commit 3adecf41bc
2 changed files with 45 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
crates/arc-workflows/src/cli/run.rs
View file

@ -622,35 +622,38 @@ pub async fn run_command(args: RunArgs, styles: &'static Styles) -> anyhow::Resu
let _ = retro.save(&logs_dir);
// Run retro agent session (execution_env still alive via _cleanup_guard)
if !dry_run_mode {
if let Ok(client) = arc_llm::client::Client::from_env().await {
match crate::retro_agent::run_retro_agent(
&execution_env,
&logs_dir,
&client,
provider_enum,
&model,
)
.await
{
Ok(narrative) => {
retro.apply_narrative(narrative);
let _ = retro.save(&logs_dir);
eprintln!(
"{dim}Retro saved to {}/retro.json{reset}",
logs_dir.display(),
dim = styles.dim,
reset = styles.reset,
);
}
Err(e) => {
eprintln!(
"{dim}Retro agent skipped: {e}{reset}",
dim = styles.dim,
reset = styles.reset,
);
}
}
let narrative_result = if dry_run_mode {
Ok(crate::retro_agent::dry_run_narrative())
} else if let Ok(client) = arc_llm::client::Client::from_env().await {
crate::retro_agent::run_retro_agent(
&execution_env,
&logs_dir,
&client,
provider_enum,
&model,
)
.await
} else {
Err(anyhow::anyhow!("No LLM client available"))
};
match narrative_result {
Ok(narrative) => {
retro.apply_narrative(narrative);
let _ = retro.save(&logs_dir);
eprintln!(
"{dim}Retro saved to {}/retro.json{reset}",
logs_dir.display(),
dim = styles.dim,
reset = styles.reset,
);
}
Err(e) => {
eprintln!(
"{dim}Retro agent skipped: {e}{reset}",
dim = styles.dim,
reset = styles.reset,
);
}
}
}

13
crates/arc-workflows/src/retro_agent.rs
View file

@ -190,6 +190,19 @@ pub async fn run_retro_agent(
Ok(narrative)
}
/// Return a placeholder narrative for dry-run mode. Exercises the full
/// derive → apply_narrative → save path without making LLM calls.
pub fn dry_run_narrative() -> RetroNarrative {
RetroNarrative {
smoothness: crate::retro::SmoothnessRating::Smooth,
intent: "[dry-run] No LLM analysis performed".to_string(),
outcome: "[dry-run] Pipeline completed in simulated mode".to_string(),
learnings: vec![],
friction_points: vec![],
open_items: vec![],
}
}
fn build_profile(provider: Provider, model: &str) -> Box<dyn ProviderProfile> {
match provider {
Provider::OpenAi => Box::new(OpenAiProfile::new(model)),